Page MenuHomePhabricator
Create Task
Maniphest T267237

Delay progress bar for a few seconds in IPInfo widget [S]
Closed, ResolvedPublic
Actions

Description

Only show the progress bar in the IPInfo widget after a couple of seconds, to avoid a flash of progress bar when the response time is short.

Details

SubjectRepoBranchLines +/-
Delay displaying progress barmediawiki/extensions/IPInfomaster+21 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Nov 4 2020, 4:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2020, 4:52 PM
Tchanders mentioned this in T260821: Performance review of IP Info extension.Nov 4 2020, 5:01 PM
• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Nov 4 2020, 5:04 PM
• Gilles subscribed.Nov 5 2020, 1:05 PM
ARamirez_WMF renamed this task from Delay progress bar for a few seconds in IPInfo widget to Delay progress bar for a few seconds in IPInfo widget [S].Oct 6 2021, 4:43 PM
phuedx moved this task from Triage/To be Estimated to IP Info on the Anti-Harassment board.Oct 19 2021, 2:27 PM
phuedx added a subtask: T267235: Add performance instrumentation to IP Info extension [M].Oct 19 2021, 2:32 PM
phuedx subscribed.Oct 19 2021, 2:36 PM

☝️ We estimated this as a small but weren't sure if it will actually be an issue and so decided to punt on it until we either had the instrument(s) telling us that it was or we had a little extra bandwidth.

phuedx moved this task from IP Info to Cards ready for development on the Anti-Harassment board.Nov 3 2021, 4:52 PM
Tchanders added a comment.Jan 10 2022, 5:36 PM

Bringing this into the current workboard because I think we have a little extra bandwidth...

Tchanders moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jan 10 2022, 5:36 PM
Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
STran subscribed.Jan 11 2022, 10:52 AM

Did we agree on a time to delay it by?

STran claimed this task.Jan 11 2022, 11:22 AM
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
gerritbot added a comment.Jan 11 2022, 11:24 AM

Change 753013 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPInfo@master] [WIP] Delay displaying progress bar

https://gerrit.wikimedia.org/r/753013

gerritbot added a project: Patch-For-Review.Jan 11 2022, 11:24 AM
STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jan 11 2022, 11:52 AM
Tchanders added a subscriber: • Prtksxna.Jan 11 2022, 1:41 PM

Ah, I missed the subtask. I suppose even though the instrumentation is in place, we don't really have any user data yet. I'd be happy to go with the delay in the patch (250ms) and file another task for reviewing this once we have data (i.e. post-deployment).

@STran @Prtksxna How does that sound?

• Prtksxna added a comment.Jan 12 2022, 7:49 AM
In T267237#7612709, @Tchanders wrote:

@STran @Prtksxna How does that sound?

Sounds good, Thalia!
I know this might be a ton of work for something so simple, but I had worked out some numbers and situations for Who-Wrote-That that might apply here: T231115#5475342

STran added a comment.Jan 13 2022, 6:34 AM

Are we waiting until the results of T267235: Add performance instrumentation to IP Info extension [M] to do anything more complicated than a fixed delay? We could do 100ms like T231115#5475342 proposes to start with.

STran moved this task from Code Review 🔍 to Needs Design/Product 🎨 on the Anti-Harassment (The Letter Song) board.Jan 13 2022, 12:08 PM
Tchanders added a comment.Jan 13 2022, 6:26 PM

I think we should move ahead with this. We can change the delay to 100ms now and file a task for revisiting the delay based on the user data.

@Prtksxna is that OK? @STran would you mind filing the follow-up?

• Prtksxna mentioned this in T299203: IPInfo: Revaluate popup loading indicator delay based on performance analytics.Jan 14 2022, 7:25 AM
In T267237#7620309, @Tchanders wrote:

I think we should move ahead with this. We can change the delay to 100ms now and file a task for revisiting the delay based on the user data.

Sounds good 👍🏾

STran mentioned this in T299221: Evaluate delay time on IPInfo's progress bar.Jan 14 2022, 2:08 PM
STran added a subtask: T299221: Evaluate delay time on IPInfo's progress bar.
In T267237#7620309, @Tchanders wrote:

@STran would you mind filing the follow-up?

T299221: Evaluate delay time on IPInfo's progress bar

STran moved this task from Needs Design/Product 🎨 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jan 14 2022, 2:09 PM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Jan 14 2022, 4:41 PM
gerritbot added a comment.Jan 14 2022, 4:52 PM

Change 753013 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Delay displaying progress bar

https://gerrit.wikimedia.org/r/753013

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 14 2022, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 14 2022, 5:11 PM
• imaigwilo subscribed.Jan 20 2022, 5:19 AM

I do see the delay progress bar for a few seconds in IPInfo widget, for a brief moment.

• imaigwilo moved this task from QA/Testing 🐞 to Done: Q2 2021-22 on the Anti-Harassment (The Letter Song) board.Jan 20 2022, 5:20 AM
• Niharika closed this task as Resolved.Feb 17 2022, 1:41 AM
• Niharika closed subtask T267235: Add performance instrumentation to IP Info extension [M] as Resolved.Feb 17 2022, 1:48 AM
• Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL