Page MenuHomePhabricator

Update cxserver to handle Parsoid HTML change from <figure-inline> to <span>
Closed, ResolvedPublic

Description

Update cxserver to handle Parsoid HTML change from <figure-inline> to <span> as proposed in T266143: Parsoid clients should handle inline media HTML change from <figure-inline> to <span>.

  • MWImage adaptation class would need change to accept span as the tag for inline images. Corresponding tests will require update.
  • As per T266143, figure-inline need to be retained for some more time.
  • Make sure that the above changes are not breaking any tests we have

Event Timeline

santhosh created this task.

Change 642376 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Use <span> for inline images

https://gerrit.wikimedia.org/r/642376

Change 642376 merged by Nik Gkountas:
[mediawiki/services/cxserver@master] Use <span> for inline images

https://gerrit.wikimedia.org/r/642376

Change 649329 had a related patch set uploaded (by KartikMistry; owner: KartikMistry):
[operations/deployment-charts@master] Update cxserver to 2020-12-12-101743-production

https://gerrit.wikimedia.org/r/649329

Change 649329 merged by jenkins-bot:
[operations/deployment-charts@master] Update cxserver to 2020-12-12-101743-production

https://gerrit.wikimedia.org/r/649329

Mentioned in SAL (#wikimedia-operations) [2020-12-15T05:29:10Z] <kart_> Updated cxserver to 2020-12-12-101743-production (T268309)

This might be hard to verify, but I'd check generally that "translating" images work in CX for now. The change on parsoid side is happening later, at which point we probably should check again. If I remember correctly there is some method to ask parsoid to provide new format, but doing that in context of CX is not possible I think.

got this error translating an article on cx2-testing, is this a bug or an issue with the server?

We have plenty of user reports of publishing failures and this matches those. Some of them are apparently persistent and some are not. Maybe you could capture the request payload for further investigation?

I only get this error in cx2, not in prod.
can you tell me how I get the request payload?
you mean the api call from devtools (maybe a har file with the details)?

We have plenty of user reports of publishing failures and this matches those. Some of them are apparently persistent and some are not. Maybe you could capture the request payload for further investigation?

I only get this error in cx2, not in prod.
can you tell me how I get the request payload?
you mean the api call from devtools (maybe a har file with the details)?

I am mostly interested in the request parameters of the api call (including the big base64 encoded blob). HAR would work too but I think it contains your cookies so don't post it publicly.

Pginer-WMF added a subscriber: Pginer-WMF.

I don't recall why this was movd to pending input for QA. @Jpita is there still input needed for QA?

I don't recall why this was movd to pending input for QA. @Jpita is there still input needed for QA?

Niklas asked for more info and I sent it to him over slack, no more word from him on this subject since then
https://phabricator.wikimedia.org/T268309#6698696