Page MenuHomePhabricator

[wmf.16] 'More' tab displays WikiLove label cut off when screen width is less than 820px
Closed, ResolvedPublicBUG REPORT

Description

Split from T265570.

Steps to Reproduce:

  1. Go to a User page with enabled Wikilove tab and start resizing the width of the page.
  2. When the width becomes less than 820px width - "View history" and "WikiLove" tabs would collapse into "More" tab - the "WikiLove" label would be displayed cut-off.


Additional info from comments on T265570:
from @Nardog's comment

Now the link text "WikiLove" is clipped when collapsed inside "More".

#ca-wikilove.icon a

should probably be

#p-views #ca-wikilove.icon a

From @Jdlrobson comment
@MMiller_WMF this looks like an issue when Vector is resized to a lower resolution (I am not sure how widely this is used).
There is some code that collapses tabs under the more menu like so:

Event Timeline

Etonkovidova renamed this task from [wmf.16] 'More' tab displays WikiLove label cut off when screen width is less than 820 to [wmf.16] 'More' tab displays WikiLove label cut off when screen width is less than 820px.Nov 23 2020, 11:01 PM

Thanks, @Etonkovidova. I'm putting this in our Incoming as a quick bug to fix.

Change 650539 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/WikiLove@master] Fix Wikilove for smaller screens

https://gerrit.wikimedia.org/r/650539

Urbanecm triaged this task as Low priority.
Urbanecm moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

Thanks for the patch!

WikiLove itself is not super useful on small screens due to the fixed-width dialog, but I suppose this menu item looked weird and broken even if you were trying to use something else, not WikiLove.

Change 650539 merged by jenkins-bot:
[mediawiki/extensions/WikiLove@master] Fix Wikilove for smaller screens

https://gerrit.wikimedia.org/r/650539

Checked in betalabs - the issue is fixed; added it to the list of fixes to check after the deployment.