Page MenuHomePhabricator

WikiLove icon no longer visible following changes to vector classes
Closed, ResolvedPublic

Description

The WikiLove heart icon which is shown on the WikiLove tab (portlet?) seems to have been replaced by the text 'WikiLove'.

Believed to have been caused by T255718

Present:

Previously:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Soda where exactly are you seeing the text "WikiLove"? The wikilove extension is not enabled on metawiki
I can, however, reproduce this on outreach wiki, where the text is shown, but not on enwiki, where the icon is still shown.
I agree with the assessment that this was caused by T262092, which is now rolling out as part of the train. Marking this as a train blocker accordingly

DannyS712 renamed this task from WikiLove icon not visible (on metawiki) to WikiLove icon no longer visible following changes to vector classes.Oct 15 2020, 8:03 AM
DannyS712 updated the task description. (Show Details)

@DannyS712, my bad, it's on mediawiki.org

Can reproduce there as well

I don't think this should be a blocker. This isn't a major feature lost, it's a cosmetic change only - the extension still works.

Urbanecm lowered the priority of this task from Unbreak Now! to Needs Triage.Oct 15 2020, 2:29 PM

Change 634235 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WikiLove@master] Simplify overqualified selectors

https://gerrit.wikimedia.org/r/634235

@Urbanecm -- would you be able to add screenshots of the change?

@MMiller_WMF Sure! Wikilove now seems to display as:

while it previously displayed as:

Change 634235 merged by jenkins-bot:
[mediawiki/extensions/WikiLove@master] Simplify overqualified selectors

https://gerrit.wikimedia.org/r/634235

Etonkovidova claimed this task.
Etonkovidova added a subscriber: Etonkovidova.

Checked in betalabs - the icon is back and the functionality works as expected

Added the task to the post-deployment checklist for wmf.16.

Now the link text "WikiLove" is clipped when collapsed inside "More".

#ca-wikilove.icon a

should probably be

#p-views #ca-wikilove.icon a

@Nardog -- I think we had believed that we fixed this, but we'll look into it. @Etonkovidova -- do you know under what circumstances WikiLove appears inside the "More" list anyway? Do you have an idea what might be going on here?

@MMiller_WMF this looks like an issue when Vector is resized to a lower resolution (I am not sure how widely this is used).
There is some code that collapses tabs under the more menu like so:

@Nardog -- I think we had believed that we fixed this, but we'll look into it. @Etonkovidova -- do you know under what circumstances WikiLove appears inside the "More" list anyway? Do you have an idea what might be going on here?

The issue is displayed only with the width <820 when the tabs would collapse into More tab. The issue is present in wmf.18 testwiki and wmf.16 enwiki. I created a new task - T268534: [wmf.16] 'More' tab displays WikiLove label cut off when screen width is less than 820px since the issue is not in the scope of this task. I've also added the above comments - from @Nardog and @Jdlrobson to the new task.