The WikiLove heart icon which is shown on the WikiLove tab (portlet?) seems to have been replaced by the text 'WikiLove'.
Believed to have been caused by T255718
Present:
Previously:
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Simplify overqualified selectors | mediawiki/extensions/WikiLove | master | +7 -6 |
Related Objects
Related Objects
- Mentioned In
- T306416: Wikilove text is displayed instead of Wikilove heart icon on Vector 2022 skin
T268534: [wmf.16] 'More' tab displays WikiLove label cut off when screen width is less than 820px
T255718: Gadgets using vectorTabs class require update to use vector-menu-tabs class - Mentioned Here
- T268534: [wmf.16] 'More' tab displays WikiLove label cut off when screen width is less than 820px
T262092: [October] Update to user styles and scripts required: .menu, .vectorTabs and .vectorMenu, .menu and .vectorMenuCheckbox no longer supported
T255718: Gadgets using vectorTabs class require update to use vector-menu-tabs class
Event Timeline
Comment Actions
@Soda where exactly are you seeing the text "WikiLove"? The wikilove extension is not enabled on metawiki
I can, however, reproduce this on outreach wiki, where the text is shown, but not on enwiki, where the icon is still shown.
I agree with the assessment that this was caused by T262092, which is now rolling out as part of the train. Marking this as a train blocker accordingly
Comment Actions
I don't think this should be a blocker. This isn't a major feature lost, it's a cosmetic change only - the extension still works.
Comment Actions
Change 634235 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WikiLove@master] Simplify overqualified selectors
Comment Actions
Change 634235 merged by jenkins-bot:
[mediawiki/extensions/WikiLove@master] Simplify overqualified selectors
Comment Actions
Checked in betalabs - the icon is back and the functionality works as expected
Added the task to the post-deployment checklist for wmf.16.
Comment Actions
Now the link text "WikiLove" is clipped when collapsed inside "More".
#ca-wikilove.icon a
should probably be
#p-views #ca-wikilove.icon a
Comment Actions
@Nardog -- I think we had believed that we fixed this, but we'll look into it. @Etonkovidova -- do you know under what circumstances WikiLove appears inside the "More" list anyway? Do you have an idea what might be going on here?
Comment Actions
@MMiller_WMF this looks like an issue when Vector is resized to a lower resolution (I am not sure how widely this is used).
There is some code that collapses tabs under the more menu like so:
Comment Actions
The issue is displayed only with the width <820 when the tabs would collapse into More tab. The issue is present in wmf.18 testwiki and wmf.16 enwiki. I created a new task - T268534: [wmf.16] 'More' tab displays WikiLove label cut off when screen width is less than 820px since the issue is not in the scope of this task. I've also added the above comments - from @Nardog and @Jdlrobson to the new task.