Page MenuHomePhabricator

Gadgets using vectorTabs class require update to use vector-menu-tabs class
Closed, ResolvedPublic

Description

Due to an oversight, some changes relating to the user notice in T254797 broke several gadgets that were relying on the vectorTabs class. For now this impacts only user and site scripts (not styles). Apologies to those who were impacted.

Given the low number of impacted pages, and staff availability, the change will not be rolled back but we will be more careful in future.

To fix

  • Use of the .vectorTabs selector should be replaced with .vector-menu-tabs

Possibly impacted pages (125)

https://ar.wikipedia.org/wiki/ميدياويكي:Gadget-MenuTabsToggle.js
https://azb.wikipedia.org/wiki/ایشلدن:Alp_Er_Tunqa/Gadget-Twinkle.js
https://azb.wikipedia.org/wiki/ایشلدن:Aymara93/Gadget-Twinkle.js
https://azb.wikipedia.org/wiki/مدیاویکی:Gadget-Twinkle.js
https://bh.wikipedia.org/wiki/मीडियाविकि:Gadget-MenuTabsToggle.js
https://bn.wikibooks.org/wiki/মিডিয়াউইকি:Gadget-Twinkle.js
https://bn.wikibooks.org/wiki/মিডিয়াউইকি:Gadget-UserMessages.js
https://bn.wikibooks.org/wiki/মিডিয়াউইকি:Gadget-twinkle.js
https://bn.wikisource.org/wiki/মিডিয়াউইকি:Gadget-UserMessages.js
https://commons.wikimedia.org/wiki/MediaWiki_talk:Gadget-DropdownToTabbar.js
https://commons.wikimedia.org/wiki/User:Rodejong/vector.js
https://de.wikipedia.org/wiki/Benutzer:8-P/vector.js
https://de.wikipedia.org/wiki/Benutzer:ProkoschLP/vectorDropdownMenus.js
https://de.wikipedia.org/wiki/Benutzer:Seewolf/vectorDropdownMenus.js
https://en.wikibooks.org/wiki/User:Vito_Genovese/Template_helper/Depot.js
https://en.wikipedia.org/wiki/User:Amalthea/VectorMenuToTabs.js
https://en.wikipedia.org/wiki/User:Davidgothberg/vector.js
https://en.wikipedia.org/wiki/User:Dcoetzee/Gadget-DropdownToTabbar.js
https://en.wikipedia.org/wiki/User:DragonflySixtyseven/vector.js
https://en.wikipedia.org/wiki/User:Edokter/MenuTabsToggle.js
https://en.wikipedia.org/wiki/User:Kwiki/vector.js
https://en.wikipedia.org/wiki/User:LTaalik/vector.js
https://en.wikipedia.org/wiki/User:Nihiltres/nothingthree.js
https://en.wikipedia.org/wiki/User:Omkar1234/vector.js
https://en.wikipedia.org/wiki/User:QwerpQwertus/userscript.js
https://en.wikipedia.org/wiki/User:Rodejong/vector.js
https://en.wikipedia.org/wiki/User:Sheldont22/vector.js
https://en.wikipedia.org/wiki/User:Shoaler/vector.js
https://en.wikipedia.org/wiki/User:Splash/vector.js
https://en.wikipedia.org/wiki/User:Svick/DropDownToTabs.js
https://en.wikipedia.org/wiki/User:UncleDouggie/twinkle-minified.js
https://en.wikipedia.org/wiki/User:Wikignome0530/vector.js
https://en.wikiquote.org/wiki/User:Bawolff/vector.js
https://en.wikisource.org/wiki/User:AuFCL/common.js/Gadget-UserMessages.js
https://en.wikiversity.org/wiki/User:Cirt/welcome/vector.js
https://en.wikiversity.org/wiki/User:Devourer09/welcome/vector.js
https://en.wikiversity.org/wiki/User:Thrice43/vector.js
https://en.wiktionary.org/wiki/User:Cirt/welcome/vector.js
https://fa.wikinews.org/wiki/مدیاویکی:Gadget-UserMessages.js
https://fa.wikipedia.org/wiki/مدیاویکی:Gadget-Twinkle.js
https://fa.wikipedia.org/wiki/کاربر:MohandesWiki/Gadget-Twinkle.js
https://fa.wikiquote.org/wiki/مدیاویکی:Gadget-Twinkle.js
https://fa.wikivoyage.org/wiki/مدیاویکی:Gadget-Twinkle.js
https://fa.wikivoyage.org/wiki/کاربر:MohandesWiki/Gadget-Twinkle.js
https://fr.wikipedia.org/wiki/Utilisateur:Stjn/common.js
https://gom.wikipedia.org/wiki/मिडियाविकी:Gadget-MenuTabsToggle.js
https://gu.wikisource.org/wiki/મીડિયાવિકિ:Gadget-UserMessages.js
https://ha.wikipedia.org/wiki/User:Shrikarsan/விக்கியன்பு2.js
https://hi.wikibooks.org/wiki/मीडियाविकि:Gadget-twinkle.js
https://hu.wikipedia.org/wiki/Szerkesztő:Tgr/warning.js
https://hu.wikipedia.org/wiki/Szerkesztő:Y_6/warning.js
https://it.wikipedia.org/wiki/Utente:Frigotoni/AvvisiUtente.js
https://ja.wikipedia.org/wiki/利用者:Atmark-chan/WTECH/CollapseTabWhenNarrow.js
https://ka.wikipedia.org/wiki/მომხმარებელი:Deu/common.js
https://ka.wikipedia.org/wiki/მომხმარებელი:Giorgi13/vector.js
https://ka.wikipedia.org/wiki/მომხმარებელი:MIKHEIL/common.js
https://kk.wikipedia.org/wiki/МедиаУики:Mainpage.js
https://mai.wikipedia.org/wiki/मेडियाविकि:Gadget-MenuTabsToggle.js
https://meta.wikimedia.org/wiki/User:Catherine_Laurence/welcome.js
https://meta.wikimedia.org/wiki/User:Cirt/welcome/vector.js
https://meta.wikimedia.org/wiki/User:GeorgeBarnick/delete.js
https://meta.wikimedia.org/wiki/User:Guandalug/vectorDropdownMenus.js
https://meta.wikimedia.org/wiki/User:Plutarky/welcome.js
https://ne.wikipedia.org/wiki/मीडियाविकि:Gadget-MenuTabsToggle.js
https://nl.wikipedia.org/wiki/Gebruiker:DustSpinner/vector.js
https://nl.wikipedia.org/wiki/Gebruiker:Freaky_Fries/vector.js
https://nl.wikipedia.org/wiki/Gebruiker:Fruggo/vector.js
https://nl.wikipedia.org/wiki/Gebruiker:JZ85/vector.js
https://nl.wikipedia.org/wiki/Gebruiker:Lolsimon/vector.js
https://nl.wikipedia.org/wiki/Gebruiker:Marek69/vector.js
https://nl.wikipedia.org/wiki/Gebruiker:Michiel1972/vector.js
https://nl.wikipedia.org/wiki/Gebruiker:Romaine/insertvector.js
https://nl.wikipedia.org/wiki/Gebruiker:Romaine/vector.js
https://nl.wikipedia.org/wiki/Gebruiker:Skuipers/vector.js
https://or.wikipedia.org/wiki/ମିଡ଼ିଆଉଇକି:Gadget-MenuToTabs.js
https://outreach.wikimedia.org/wiki/User:Cirt/welcome/vector.js
https://pa.wikisource.org/wiki/ਮੀਡੀਆਵਿਕੀ:Gadget-UserMessages.js
https://ps.wikipedia.org/wiki/ميډياويکي:Gadget-MenuTabsToggle.js
https://ps.wikipedia.org/wiki/کارن:Ibrahim_khashrowdi/Mainpage.js
https://ps.wiktionary.org/wiki/ميډياويکي:Gadget-Twinkle.js
https://ru.wikipedia.org/wiki/Участник:NatigKrolik/mediawiki.util.js
https://ru.wikipedia.org/wiki/Участник:Нирваньчик/rq-d.js
https://ru.wikipedia.org/wiki/Участник:Нирваньчик/rq.js
https://sa.wikisource.org/wiki/मीडियाविकि:Gadget-UserMessages.js
https://simple.wikipedia.org/wiki/User:SEPTActaMTA8235/DropDownToTabs.js
https://sr.wikinews.org/wiki/Медијавики:Gadget-UserMessages.js
https://sr.wikipedia.org/wiki/Корисник:Loshmi/vector.js
https://sr.wikipedia.org/wiki/Корисник:Michaello/vector.js
https://sr.wikipedia.org/wiki/Корисник:Михајло_Анђелковић/vector.js
https://sr.wikipedia.org/wiki/Медијавики:Gadget-MenuTabsToggle.js
https://ta.wikipedia.org/wiki/பயனர்:Aathavan_jaffna/UserMessages.js
https://ta.wikipedia.org/wiki/பயனர்:Maathavan/UserMessages.js
https://ta.wikipedia.org/wiki/பயனர்:Maathavan/tagger.js
https://ta.wikipedia.org/wiki/பயனர்:Shanmugamp7/UserMessages.js
https://ta.wikipedia.org/wiki/பயனர்:Shrikarsan/Gadget-விக்கியன்பு2.js
https://ta.wikipedia.org/wiki/பயனர்:Shrikarsan/UserMessages.js
https://ta.wikipedia.org/wiki/பயனர்:Shrikarsan/விக்கியன்பு2.js
https://ta.wikiquote.org/wiki/பயனர்:Maathavan/tagger.js
https://ta.wikisource.org/wiki/பயனர்:Balajijagadesh/Gadget-விக்கியன்பு2.js
https://test.wikipedia.org/wiki/User:Maathavan/tag.js
https://test.wikipedia.org/wiki/User:Maathavan/test.js
https://th.wikipedia.org/wiki/ผู้ใช้:Patsagorn_Y./js/revert.js
https://tr.wikipedia.org/wiki/Kullanıcı:Stultiwikia/Şablon_yardımcısı/Depo.js
https://tr.wikipedia.org/wiki/Kullanıcı:Vito_Genovese/Sürüm_kontrolü.js
https://tr.wikipedia.org/wiki/Kullanıcı:Vito_Genovese/Şablon_yardımcısı/Depo.js
https://ur.wikipedia.org/wiki/میڈیاویکی:Gadget-MenuTabsToggle.js
https://www.mediawiki.org/wiki/User:Sdia45/common.js
https://www.mediawiki.org/wiki/User:Shanmugamp7/userMessages.js
https://www.mediawiki.org/wiki/User:Vanished_user_24kwjf10h32h/UserMessages.js
https://www.wikidata.org/wiki/User:Goldzahn/test.js
https://www.wikidata.org/wiki/User:Napoleon.tan/WikiDataPropertyTool.js
https://www.wikidata.org/wiki/User:PMG/wikidata_useful.js
https://www.wikidata.org/wiki/User:Zuphilip/common.js
https://zh-yue.wikipedia.org/wiki/User:Dabao_qian/common.js
https://zh.wikinews.org/wiki/User:Ou0430/Friendly/morebits.min.js
https://zh.wikipedia.org/wiki/User:A2569875/text.js
https://zh.wikipedia.org/wiki/User:Alexander_Misel/sidebar.js
https://zh.wikipedia.org/wiki/User:Cccmeat/vector.js
https://zh.wikipedia.org/wiki/User:Shizhao/common.js
https://zh.wikipedia.org/wiki/User:SickManWP/common.js
https://zh.wikipedia.org/wiki/User:Tommyang/Script/Friendly.js
https://zh.wikipedia.org/wiki/User:Wetittwinkle/twinkle.js
https://zh.wikipedia.org/wiki/User:YFdyh000/Gadget-noteTAvector.js
https://zh.wikipedia.org/wiki/User:Zyksnowy/JIBANYAN/text.js
https://zh.wikipedia.org/wiki/User:圣本笃/sidebar.js

Impacted site CSS 15

https://ce.wikipedia.org/wiki/MediaWiki:Mainpage.js
https://ce.wikipedia.org/wiki/Декъашхо:Kaiyr/MediaWiki:Mainpage.js
https://commons.wikimedia.org/wiki/MediaWiki:Gadget-DropdownToTabbar.js
https://en.wikibooks.org/wiki/MediaWiki:Gadget-twinkle.js
https://en.wikinews.org/wiki/MediaWiki:Gadget-UserMessages.js
https://en.wikiquote.org/wiki/MediaWiki:Gadget-UserMessages.js
https://en.wikisource.org/wiki/MediaWiki:Gadget-UserMessages.js
https://ky.wikipedia.org/wiki/MediaWiki:Mainpage.js
https://sq.wikinews.org/wiki/MediaWiki:Gadget-UserMessages.js
https://test2.wikipedia.org/wiki/MediaWiki:Gadget-DropdownToTabbar.js
https://test2.wikipedia.org/wiki/MediaWiki:Gadget-MenuTabsToggle.js
https://www.mediawiki.org/wiki/MediaWiki:Gadget-userMessages.js
https://zh.wikipedia.org/wiki/MediaWiki:Gadget-noteTAvector.js
https://zh.wikiquote.org/wiki/MediaWiki:Gadget-noteTAvector.js
https://zh.wikivoyage.org/wiki/MediaWiki:Gadget-noteTAvector.js

Users (83)

@8-P @A2569875 @Aathavan_jaffna @Alexander_Misel @Alp_Er_Tunqa @Amalthea @Atmark-chan @AuFCL @Aymara93 @Balajijagadesh @Bawolff @Catherine_Laurence @Cccmeat @Cirt @Dabao_qian @Davidgothberg @Dcoetzee @Deu @Devourer09 @DragonflySixtyseven @DustSpinner @Edokter @Freaky_Fries @Frigotoni @Fruggo @GeorgeBarnick @Giorgi13 @Goldzahn @Guandalug @Ibrahim_khashrowdi @JZ85 @Kwiki @LTaalik @Lolsimon @Loshmi @MIKHEIL @Maathavan @Mainpage @Marek69 @Michaello @Michiel1972 @MohandesWiki @Napoleon @NatigKrolik @Nihiltres @Omkar1234 @Ou0430 @PMG @Patsagorn_Y @Plutarky @ProkoschLP @QwerpQwertus @Rodejong @Romaine @SEPTActaMTA8235 @Sdia45 @Seewolf @Shanmugamp7 @Sheldont22 @Shizhao @Shoaler @Shrikarsan @SickManWP @Skuipers @Splash @Stjn @Stultiwikia @Svick @Tgr @Thrice43 @Tommyang @UncleDouggie @Vanished_user_24kwjf10h32h @Vito_Genovese @Wetittwinkle @Wikignome0530 @YFdyh000 @Y_6 @Zuphilip @Zyksnowy @Михајло_Анђелковић @Нирваньчик @圣本笃

Event Timeline

Jdlrobson updated the task description. (Show Details)
Jdlrobson added subscribers: Atmark-chan, Deu, A2569875 and 34 others.
Jdlrobson removed subscribers: Tgr, Edokter, Romaine and 37 others.

WikiLove (filed as T265570), Theme and VisualEditor also seem to use the .vectorTabs to add styles; those should also be changed. (code search query)

Change 634233 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/VisualEditor@master] Change selector vectorTabs => vector-menu-tabs

https://gerrit.wikimedia.org/r/634233

Change 634233 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Change selector vectorTabs => vector-menu-tabs

https://gerrit.wikimedia.org/r/634233

This was announced in https://meta.wikimedia.org/wiki/Tech/News/2020/26 ; I guess there is nothing else to do here if there are no plans to ping people individually?

Jdlrobson claimed this task.

WikiLove (filed as T265570), Theme and VisualEditor also seem to use the .vectorTabs to add styles; those should also be changed. (code search query)

Thanks @Soda for pointing these out. these look fixed, but not sure about https://gerrit.wikimedia.org/g/mediawiki/extensions/JsonData/+/322bcf2b5d85465590b75f28e7f8d73bae57c6a3/JsonData_body.php#70 - perhaps that needs a ticket?