Page MenuHomePhabricator
Create Task
Maniphest T270297

[regression] Growth-homepage-banner is not visible anymore on Arabic Wikipedia
Closed, ResolvedPublic
Actions

Description

The banner is not visible anymore on Homepages on ar.wp.

The banner still exists though: https://ar.wikipedia.org/w/index.php?title=%D9%85%D9%8A%D8%AF%D9%8A%D8%A7%D9%88%D9%8A%D9%83%D9%8A:Growth-homepage-banner

Details

SubjectRepoBranchLines +/-
Fix message fallback for homepage bannermediawiki/extensions/GrowthExperimentsmaster+0 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Trizek-WMF created this task.Dec 16 2020, 3:13 PM
Restricted Application added subscribers: alaa, Aklapper. · View Herald TranscriptDec 16 2020, 3:13 PM
Trizek-WMF added a project: Regression.Dec 16 2020, 3:15 PM
Trizek-WMF mentioned this in T269804: Banner module on the Growth homepage.Dec 16 2020, 3:17 PM
Trizek-WMF added a parent task: T269804: Banner module on the Growth homepage.
Etonkovidova subscribed.Dec 16 2020, 4:23 PM

Checked - for old account and a new account - the banner is displayed:

Screen Shot 2020-12-16 at 8.23.30 AM.png (539×843 px, 82 KB)

Trizek-WMF closed this task as Invalid.Dec 16 2020, 4:55 PM

Mmmmh... @MMiller_WMF and I both had no banner on our homepages.

I rechecked using this link: https://ar.wikipedia.org/w/index.php?title=%D8%AE%D8%A7%D8%B5:%D8%B5%D9%81%D8%AD%D8%A9_%D8%B1%D8%A6%D9%8A%D8%B3%D9%8A%D8%A9&source=userpagetab&namespace=2

And then realized that messages are local. Tested with &uselang=ar and it works.

Sorry for the false alarm.

MMiller_WMF added a comment.Dec 16 2020, 5:52 PM

Makes sense. Thank you for checking, @Etonkovidova.

Tgr reopened this task as Open.Dec 16 2020, 6:17 PM
Tgr subscribed.

That's my mistake, forgot about T57473: i18n fallback uses message from i18n file before customized message from DB (MediaWiki: namespace).

gerritbot added a comment.Dec 16 2020, 6:20 PM

Change 649948 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix message fallback for homepage banner

https://gerrit.wikimedia.org/r/649948

gerritbot added a project: Patch-For-Review.Dec 16 2020, 6:20 PM
Tgr claimed this task.Dec 16 2020, 6:22 PM
Tgr added a project: Growth-Team (Sprint 0 (Growth Team)).
Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 18 2020, 5:35 PM
gerritbot added a comment.Dec 18 2020, 5:48 PM

Change 649948 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix message fallback for homepage banner

https://gerrit.wikimedia.org/r/649948

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 18 2020, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 18 2020, 6:10 PM
Etonkovidova added a comment.EditedDec 18 2020, 9:41 PM

The fix works in betalabs - I added the task to my list of post-deployment checking.

One notice though - a user can dismiss the regular banner and the banner won't be shown again (it seems it's not persistent); a user cannot dismissed the Homepage banner.

Etonkovidova closed this task as Resolved.Jan 7 2021, 10:41 PM

Checked in mwf.25 - with uselang=en and with English as the language selected as a user' preference, the banner is displayed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits