Page MenuHomePhabricator
Create Task
Maniphest T272887

(MS 5) expose visual query sharing via URL in the UI
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To
Ladsgroup
Authored By
Lydia_Pintscher
Jan 25 2021, 6:04 PM
Tags
Referenced Files
F34101245: image.png
Feb 12 2021, 4:59 AM
F34101243: image.png
Feb 12 2021, 4:57 AM
F34098358: image.png
Feb 9 2021, 2:38 PM
F34098361: image.png
Feb 9 2021, 2:38 PM
F34098356: image.png
Feb 9 2021, 2:38 PM
F34038041: image.png
Jan 27 2021, 9:53 AM
F34026852: image.png
Jan 26 2021, 5:12 PM
F34026873: image.png
Jan 26 2021, 5:12 PM
Subscribers
Aklapper
• amy_rc
Charlie_WMDE
Ladsgroup
Lydia_Pintscher

Description

As an editor I want to share my visual query via URL in order to make bug reporting easier and to share my query with other editors.

Problem:
T271820 implements URL sharing but doesn't yet expose it in the UI.

Screenshots/mockups:
Desktop (Layout 1-3)

image.png (227×1 px, 18 KB)

Mobile (Layout 4)
image.png (216×339 px, 10 KB)

Tooltip
image.png (196×693 px, 15 KB)

BDD
GIVEN a visual query
AND
WHEN
AND
THEN
AND

Acceptance criteria:

  • UI has functionality to generate and copy a link to the current visual query
  • url is automatically copied to clipboard

Notes:

  • needs button with icon only component
  • use native element as a placeholder for now until the popover component is there: T273041
  • responsive behavior is handled in a separate ticket
  • for now we show the full URL - URL shortening will be handled in a separate ticket

Related Objects
Search...

Event Timeline

Lydia_Pintscher created this task.Jan 25 2021, 6:04 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptJan 25 2021, 6:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lydia_Pintscher added a subtask: T271820: (MS 5) Implement Serialization for Query-Builder URL sharing.Jan 25 2021, 6:05 PM
Lydia_Pintscher moved this task from Incoming to Backlog on the Wikidata Query Builder board.
Lydia_Pintscher triaged this task as Medium priority.Jan 26 2021, 9:29 AM
Lydia_Pintscher added a subtask: T272958: (MS 5) Create link component.
Charlie_WMDE updated the task description. (Show Details)Jan 26 2021, 5:12 PM
Lydia_Pintscher closed subtask T271820: (MS 5) Implement Serialization for Query-Builder URL sharing as Resolved.Jan 27 2021, 8:46 AM
Charlie_WMDE updated the task description. (Show Details)Jan 27 2021, 9:26 AM
Charlie_WMDE updated the task description. (Show Details)Jan 27 2021, 9:53 AM
Lydia_Pintscher renamed this task from (MS 5) expose query sharing via URL in the UI to (MS 5) expose visual query sharing via URL in the UI.Jan 27 2021, 10:21 AM
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher added a subtask: T273041: (MS 6) Create popover component.Jan 27 2021, 10:29 AM
Lydia_Pintscher updated the task description. (Show Details)Jan 27 2021, 10:34 AM
Lydia_Pintscher set the point value for this task to 8.
Lydia_Pintscher moved this task from Backlog to Ready to pick up on the Wikidata Query Builder board.
Sarai-WMDE updated the task description. (Show Details)Jan 27 2021, 3:39 PM
Sarai-WMDE updated the task description. (Show Details)Jan 27 2021, 3:44 PM
Charlie_WMDE claimed this task.Jan 27 2021, 4:36 PM
Sarai-WMDE updated the task description. (Show Details)Jan 28 2021, 12:58 PM
Charlie_WMDE changed the task status from Open to Stalled.Feb 1 2021, 3:51 PM

stalled while i figure some things out

Lydia_Pintscher raised the priority of this task from Medium to High.Feb 8 2021, 9:20 AM
Charlie_WMDE changed the task status from Stalled to Open.Feb 9 2021, 2:38 PM
Charlie_WMDE removed Charlie_WMDE as the assignee of this task.
Charlie_WMDE updated the task description. (Show Details)
Charlie_WMDE subscribed.
• amy_rc closed subtask T273661: Reconstruct the QueryBuilder from a generated URL as Resolved.Feb 10 2021, 10:51 AM
Ladsgroup subscribed.Feb 10 2021, 7:09 PM

The link icon type is not yet released. I'll do a pre-release for this.

Ladsgroup added a comment.Feb 12 2021, 4:57 AM

I made a very WIP PR on this but some notes I figured during the work:

  • While still w3c says you need to show the text through input to able to copy to clipboard (and ooui is the same too) but the new API for copying to clipboad is usable for us because we don't support IE11 anyway (https://caniuse.com/?search=writeText) so in my PR I stopped showing the url altogether.

image.png (143×313 px, 7 KB)

  • OTOH, I think we should not show it on hover. Not just it's complicated to combine with focus state (e.g. user on mouse enter, set it to active, then click on the button and make it focused, it's active again but on mouse leave should trigger hiding it...) and it'll also cause issues in matter of producing short urls all the time, it'll quickly get rate limited if let it generate one per hover. Maybe, we copy the long one on hover but with a different button we copy the short url on click?
Ladsgroup added a comment.Feb 12 2021, 4:59 AM

The new kibana (logstash frontend) has this:

image.png (317×357 px, 24 KB)

Ladsgroup added a comment.Feb 12 2021, 5:11 AM

Also for firefox:

Writing to the clipboard is available without permission in secure contexts and browser extensions, but only from user-initiated event callbacks. Browser extensions with the "clipboardWrite" permission can write to the clipboard at any time.

Ladsgroup added a comment.Feb 12 2021, 5:13 AM

https://github.com/wmde/query-builder/pull/195

• amy_rc closed subtask T274659: "Subtask-Checkbox" should be visible right from the beginning if a datatype wikibase-item is reconstructed as Resolved.Feb 15 2021, 4:23 PM
Michael moved this task from Ready to pick up to ❌ Blocked on the Wikidata Query Builder board.Feb 18 2021, 9:54 AM
Ladsgroup claimed this task.Mar 2 2021, 7:32 PM
Ladsgroup moved this task from ❌ Blocked to Doing on the Wikidata Query Builder board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMar 2 2021, 7:32 PM
Ladsgroup moved this task from Doing to Peer Review on the Wikidata Query Builder board.Mar 3 2021, 5:07 PM
• amy_rc closed subtask T273041: (MS 6) Create popover component as Resolved.Mar 9 2021, 12:11 PM
• amy_rc closed subtask T272958: (MS 5) Create link component as Resolved.
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata Query Builder board.Mar 9 2021, 1:58 PM
• amy_rc moved this task from Test (Verification) to Done on the Wikidata Query Builder board.Mar 10 2021, 11:34 AM
• amy_rc subscribed.

tested and works for the acceptance criteria 🎇

• amy_rc closed this task as Resolved.Mar 15 2021, 11:51 AM

\o/

Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Mar 15 2021, 12:15 PM
• amy_rc closed subtask T273162: (MS 5) shorten URL for visual query sharing as Resolved.Apr 1 2021, 8:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL