DT's CommentFormatter performs various DOM transformations such as
1 & 2 can be mangled by the transformations applied MobileFrontend's formatters. As DT tries to do transformations in the ParserCache, they will usually be run first.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T233443 [Epic] Reply Tool | |||
| Resolved | None | T278588 Mobile talk page improvements | |||
| Resolved | None | T270536 Introduce the Reply Tool on mobile | |||
| Resolved | ovasileva | T276455 MobileFrontend transformations interfere with DiscussionTools transformations |
Change 668082 had a related patch set uploaded (by Esanders; owner: Esanders):
[HtmlFormatter@master] Don't strip comments from HTML by default
@ovasileva please note that although web are implied as maintainers, that's never been made explicit and because nobody in the team is familiar with the library, the HTMLFormatter is in the Code-Stewardship-Reviews process: T258964
Change 668538 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Don't attempt to put comment markers in <noscript> tags
Change 668538 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Don't attempt to put comment markers in <noscript> tags
The two patches above address the issues we are aware of so far, More issues will probably appear as we test further and/or implement new features (e.g. 3 and 4).
Change 668082 merged by jenkins-bot:
[HtmlFormatter@master] Don't strip comments from HTML by default
(Oh, a new version of HtmlFormatter has to be released and updated in MediaWiki, since it's a separate library…)
Change 669043 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/vendor@master] Upgrade wikimedia/html-formatter from 2.0.1 to 3.0.0
Change 669046 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Upgrade wikimedia/html-formatter from 2.0.1 to 3.0.0
Change 669043 merged by jenkins-bot:
[mediawiki/vendor@master] Upgrade wikimedia/html-formatter from 2.0.1 to 3.0.1
Change 669046 merged by jenkins-bot:
[mediawiki/core@master] Upgrade wikimedia/html-formatter from 2.0.1 to 3.0.1
Change 670807 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] MobileFormatter: Don't strip HTML comments
Change 670807 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] MobileFormatter: Don't strip HTML comments
- Adding a subscription affordance to the header (future)
This has also caused issues: T280433