[S] MediaSearch:"Categories and Pages" filter UI discrepancies
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Mar 30 2021, 4:27 PM

Description

This task is a follow-up for T271565

for "Categories and Pages" the Sort by: Relevance filter is placed as the first one. This is inconsistent with other tab filters
the hover state for Namespace filter is blue

typical "Sort by" filter placement and hover state	Categories and Pages

Acceptance Criteria:

Using the same hover state
Sort by should be last on all tabs

Details

	Subject	Repo	Branch	Lines +/-
	MediaSearch:"Categories and Pages" filter UI discrepancies	mediawiki/extensions/MediaSearch	master	+2 -3
	Page filter UI discrepancy and page result tweak	mediawiki/extensions/MediaSearch	master	+31 -7

Customize query in gerrit

Related Objects

Mentioned In: rEMEDeba8abf9ef51: MediaSearch:"Categories and Pages" filter UI discrepancies
rEMEDe10df9b3a9bb: Page filter UI discrepancy and page result tweak
Mentioned Here: T271565: [S] Media Search: Adjustment of filter selects / dropdowns

Event Timeline

Etonkovidova created this task.Mar 30 2021, 4:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2021, 4:27 PM

CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Mar 30 2021, 4:38 PM

CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.

@mwilliams I'm curious to hear what you think about the hover behavior for the namespace filter. Should it match the hover behavior of the select lists, or should it be different? The namespace filter button is an actual button, so we could consider using button hover styles, which I think is what the select lists use too.

@AnneT Having the namespace filter use the same hover state (gray background) makes sense to me!

CBogen renamed this task from MediaSearch:"Categories and Pages" filter UI discrepancies to [S] MediaSearch:"Categories and Pages" filter UI discrepancies.Apr 7 2021, 4:27 PM

CBogen updated the task description. (Show Details)

CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Apr 7 2021, 4:55 PM

• Jseddon claimed this task.Apr 22 2021, 11:33 AM

• Jseddon moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.May 5 2021, 12:43 PM

Change 685499 had a related patch set uploaded (by Seddon; author: Seddon):

[mediawiki/extensions/MediaSearch@master] Page filter UI discrepancy and page result tweak

https://gerrit.wikimedia.org/r/685499

gerritbot added a project: Patch-For-Review.May 5 2021, 3:26 PM

• Jseddon moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.May 5 2021, 3:32 PM

Aklapper reassigned this task from • Jseddon to Seddon.May 17 2021, 7:13 AM

Aklapper added a subscriber: • Jseddon.

Change 685499 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Page filter UI discrepancy and page result tweak

https://gerrit.wikimedia.org/r/685499

Seddon mentioned this in rEMEDe10df9b3a9bb: Page filter UI discrepancy and page result tweak.Jun 22 2021, 7:17 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jun 22 2021, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 22 2021, 8:10 PM

egardner moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jun 24 2021, 8:17 PM

Checked in betalabs.
The first spec is Done. All filters tabs consistently have the same light-grey hover up state, as per this @mwilliams comment.

Using the same hover state

Screen Shot 2021-07-01 at 11.17.18 AM.png (1×1 px, 155 KB)

The second spec seems not to be in place. @Seddon - is it in the patch or another patch is needed?

Sort by should be last on all tabs

Incorrect		Correct
	vs

Etonkovidova updated the task description. (Show Details)Jul 1 2021, 6:27 PM

@Seddon moving back to doing to address the second spec.

Change 704156 had a related patch set uploaded (by Seddon; author: Seddon):

[mediawiki/extensions/MediaSearch@master] MediaSearch:"Categories and Pages" filter UI discrepancies

https://gerrit.wikimedia.org/r/704156

gerritbot added a project: Patch-For-Review.Jul 12 2021, 8:00 PM

Seddon moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Jul 12 2021, 10:36 PM

egardner updated the task description. (Show Details)Jul 13 2021, 7:37 PM

Change 704156 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] MediaSearch:"Categories and Pages" filter UI discrepancies

https://gerrit.wikimedia.org/r/704156

Seddon mentioned this in rEMEDeba8abf9ef51: MediaSearch:"Categories and Pages" filter UI discrepancies.Jul 13 2021, 7:57 PM

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.15; 2021-07-19); removed MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jul 13 2021, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2021, 8:10 PM

egardner moved this task from Code Review to Verify on Production on the Structured-Data-Backlog (Current Work) board.Jul 13 2021, 8:30 PM

Checked on commons wmf.15 -

Screen Shot 2021-07-21 at 2.09.54 PM.png (1×1 px, 283 KB)

	F34559134: Screen Shot 2021-07-21 at 2.09.54 PM.png
	Jul 21 2021, 9:11 PM

	F34534622: Screen Shot 2021-07-01 at 11.17.18 AM.png
	Jul 1 2021, 6:26 PM

	F34534619: Screen Shot 2021-07-01 at 11.17.18 AM.png
	Jul 1 2021, 6:26 PM

	F34534624: Screen Shot 2021-07-01 at 11.21.09 AM.png
	Jul 1 2021, 6:26 PM

	F34197786: Screen Shot 2021-03-30 at 8.48.15 AM.png
	Mar 30 2021, 4:27 PM

	F34197789: Screen Shot 2021-03-30 at 8.48.30 AM.png
	Mar 30 2021, 4:27 PM

[S] MediaSearch:"Categories and Pages" filter UI discrepanciesClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[S] MediaSearch:"Categories and Pages" filter UI discrepancies
Closed, ResolvedPublic
Actions