Page MenuHomePhabricator

Add a link: pulsing dot for editing should not be shown to existing user accounts that opt in to the experiment
Closed, ResolvedPublic

Description

I noticed this using "add a link" on desktop in cswiki in production. The pulsing blue dot that encourages the user to click edit is there upon arrival to the page, but we don't want one at all.

image.png (750×1 px, 413 KB)

This happens because HomepageHooks::onUserGetDefaultOptions defines a default value for the "did you see the blue dot for this task type" preference, but that doesn't apply to existing user accounts:

// Disable blue dot on Edit tab for link-recommendation tasks.
SuggestedEdits::GUIDANCE_BLUE_DOT_PREF => json_encode( [
    'vector' => [
        LinkRecommendationTaskTypeHandler::ID => true,
    ],
    'minerva' => [
        LinkRecommendationTaskTypeHandler::ID => true
    ]
] )

Event Timeline

There was another task about this IIRC. It won’t be an issue for new user accounts. Do we want to fix this for existing users?

@kostajh -- fixing it for existing users can be an "improvements" task. Could you update the task description to reflect that this is just about legacy accounts?

kostajh renamed this task from Add a link: pulsing dot for editing should not be shown to Add a link: pulsing dot for editing should not be shown to existing user accounts that opt in to the experiment.May 4 2021, 7:35 AM
kostajh updated the task description. (Show Details)
kostajh triaged this task as Medium priority.May 4 2021, 10:29 AM
kostajh claimed this task.
kostajh moved this task from Post-release backlog to Done / QA on the Add-Link board.