Page MenuHomePhabricator
Create Task
Maniphest T283094

Implement code for hiding the blue dot on Edit tab for users who opt-in to link recommendation experiment
Closed, DuplicatePublic
Actions

Description

We should fix the UX for users who opt-in to the link-recommendation experiment and then see the blue dot on the Edit tab. One option would be to modify the console snippet we provide to users to read growthexperiments-homepage-suggestededits-guidance-blue-dot, set "link-recommendation\":true}, then write the preference again. Or it might be better to set this on the server-side for all users by default, since it is never used for this task type for new or existing users.

The same issue was reported in T279430 and T280600.
The issue seems to be consistently present only on cswiki (Chrome/FF).

  1. On cswiki wmf.5 select "Add links between articles

(Machine suggestions)" in SE module.

  1. Go to one of the suggested articles, the pulsing blue dot is displayed on the Edit tab.

Screen Shot 2021-05-18 at 9.53.52 AM.png (1×1 px, 604 KB)

Details

SubjectRepoBranchLines +/-
Add Link: Suppress the blue dot on the edit buttonmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.7+7 -3
Add Link: Suppress the blue dot on the edit buttonmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.6+7 -3
Add Link: Suppress the blue dot on the edit buttonmediawiki/extensions/GrowthExperimentsmaster+7 -3
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.May 18 2021, 5:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2021, 5:21 PM
Etonkovidova updated the task description. (Show Details)May 18 2021, 5:21 PM
kostajh added a comment.May 18 2021, 5:22 PM

Does it happen for new user accounts? It is a known problem for existing accounts that opt in to the experiment group and we haven’t made time to fix that.

Etonkovidova updated the task description. (Show Details)May 18 2021, 5:23 PM
Etonkovidova added a comment.May 18 2021, 5:26 PM
In T283094#7096199, @kostajh wrote:

Does it happen for new user accounts? It is a known problem for existing accounts that opt in to the experiment group and we haven’t made time to fix that.

New accounts (as well as users who reset all default settings) do not have the issue.

kostajh renamed this task from [regression-wmf.5] cswiki displays pulsing blue dot for suggested Add link tasks to Implement code for hiding the blue dot on Edit tab for users who opt-in to link recommendation experiment.May 20 2021, 7:46 AM
kostajh updated the task description. (Show Details)
Etonkovidova mentioned this in T283420: Dot next to "Edit" overlaps with the interface during part of the add a link experience.May 23 2021, 5:52 PM
Etonkovidova merged a task: T283420: Dot next to "Edit" overlaps with the interface during part of the add a link experience.
Etonkovidova added a subscriber: • Urbanecm_WMF.
• Urbanecm_WMF added a comment.May 24 2021, 11:53 AM

Thanks Elena for merging this issue. Didn't know it's only for existing users.

kostajh triaged this task as High priority.May 26 2021, 3:32 PM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

We need this before we can switch on the experiment which enables the link recommendation task type for existing users.

Tgr claimed this task.May 26 2021, 4:02 PM
Tgr moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 26 2021, 4:14 PM

Change 695376 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Add Link: Suppress the blue dot on the edit button

https://gerrit.wikimedia.org/r/695376

gerritbot added a project: Patch-For-Review.May 26 2021, 4:14 PM
Tgr moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 26 2021, 4:14 PM
• mewoph moved this task from Backlog to Done / QA on the Add-Link board.May 26 2021, 4:35 PM
• mewoph moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 26 2021, 4:50 PM

Change 695376 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Link: Suppress the blue dot on the edit button

https://gerrit.wikimedia.org/r/695376

Maintenance_bot removed a project: Patch-For-Review.May 26 2021, 5:10 PM
gerritbot added a comment.May 26 2021, 5:40 PM

Change 695430 had a related patch set uploaded (by MewOphaswongse; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Add Link: Suppress the blue dot on the edit button

https://gerrit.wikimedia.org/r/695430

gerritbot added a project: Patch-For-Review.May 26 2021, 5:40 PM

Change 695431 had a related patch set uploaded (by MewOphaswongse; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] Add Link: Suppress the blue dot on the edit button

https://gerrit.wikimedia.org/r/695431

gerritbot added a comment.May 26 2021, 6:23 PM

Change 695430 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Add Link: Suppress the blue dot on the edit button

https://gerrit.wikimedia.org/r/695430

gerritbot added a comment.May 26 2021, 6:23 PM

Change 695431 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] Add Link: Suppress the blue dot on the edit button

https://gerrit.wikimedia.org/r/695431

Maintenance_bot removed a project: Patch-For-Review.May 26 2021, 7:12 PM
Stashbot added a comment.May 26 2021, 7:31 PM

Mentioned in SAL (#wikimedia-operations) [2021-05-26T19:31:41Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.6/extensions/GrowthExperiments/modules/homepage/suggestededits/ext.growthExperiments.SuggestedEdits.Guidance.js: 512d72e8df4ce0325778035d0bc6107e6e5dedf0: Add Link: Suppress the blue dot on the edit button (T283094) (duration: 01m 07s)

Stashbot added a comment.May 26 2021, 7:33 PM

Mentioned in SAL (#wikimedia-operations) [2021-05-26T19:33:08Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.7/extensions/GrowthExperiments/modules/homepage/suggestededits/ext.growthExperiments.SuggestedEdits.Guidance.js: 9f3410b1fc5535b34d49e287846c0b3c08882bc5: Add Link: Suppress the blue dot on the edit button (T283094) (duration: 01m 07s)

Etonkovidova closed this task as Resolved.May 27 2021, 1:40 AM
• mewoph closed this task as a duplicate of T281776: Add a link: pulsing dot for editing should not be shown to existing user accounts that opt in to the experiment.May 27 2021, 4:34 PM
kostajh mentioned this in T281776: Add a link: pulsing dot for editing should not be shown to existing user accounts that opt in to the experiment.May 27 2021, 4:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits