Page MenuHomePhabricator
Create Task
Maniphest T285442

[Bug] Orange talk alert does not disappear in new Vector after clicking "Mark all as read"
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
• nray
Jun 23 2021, 10:35 PM
Tags
Referenced Files
F34570941: Screen Recording 2021-07-30 at 5.23.16 PM.mov.gif
Jul 31 2021, 12:24 AM
F34570930: Screen Recording 2021-07-30 at 5.09.37 PM.mov.gif
Jul 31 2021, 12:16 AM
F34570931: Screen Recording 2021-07-30 at 5.04.34 PM.mov.gif
Jul 31 2021, 12:16 AM
F34569753: record.gif
Jul 29 2021, 8:18 PM
F34569712: Screen Recording 2021-07-29 at 12.35.43 PM.mov.gif
Jul 29 2021, 7:42 PM
F34524175: talk-alert.gif
Jun 23 2021, 10:35 PM
F34524183: id.png
Jun 23 2021, 10:35 PM
Subscribers
Aklapper
bwang
cjming
Edtadros
Jdlrobson
Masumrezarock100
• nray
Tokens
"Like" token, awarded by Jdlrobson.

Description

Steps to reproduce

  1. In an incognito window, go to your user's talk page on beta (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Nray_beta)
  2. Click the "New section" tab.
  3. Write "Hello" for the "Subject/headline" field. Write Hello [[User:Nray_beta]] ~~~~ for the body making sure to replace Nray_beta with your user's username.
  4. Click Publish changes
  5. Go to https://en.wikipedia.beta.wmflabs.org and login with your user.
  6. You should see the orange alert saying "You have a new Talk page message".
  7. Click the bell icon to open the alerts popover.
  8. Click the "Mark all as read" button

Expected results

  • After clicking the "Mark all as read" button, the orange talk alert should disappear

Actual results

  • After clicking the "Mark all as read" button, the orange talk alert remains in place

talk-alert.gif (780×1 px, 438 KB)

Environments observed

  • Browser version: Chrome Version 91.0.4472.77
  • OS version: Big Sur
  • Device model: MacBook Pro
  • Device language: En

Check any additional observations

Developer notes

Echo expects an element with an id of pt-talk-alert. In new Vector (this isn't a problem in legacy Vector), an id of ca-talk-alert gets assigned instead:

id.png (168×654 px, 39 KB)

To fix this, we can explicitly set an id of pt-talk-alert in Echo:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/700717

QA Results - Beta

ACStatusDetails
1✅T285442#7249897

QA Results - Prod

ACStatusDetails
1✅T285442#7249909

Details

SubjectRepoBranchLines +/-
Hardcode talk alert id to be pt-talk-alertmediawiki/extensions/Echomaster+2 -0
Explicitly set 'pt-talk-alert' id for talk alertmediawiki/extensions/Echomaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

• nray created this task.Jun 23 2021, 10:35 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJun 23 2021, 10:35 PM
gerritbot added a comment.Jun 23 2021, 10:35 PM

Change 700717 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/extensions/Echo@master] Explicitly set 'pt-talk-alert' id for talk alert

https://gerrit.wikimedia.org/r/700717

gerritbot added a project: Patch-For-Review.Jun 23 2021, 10:35 PM
• nray updated the task description. (Show Details)Jun 23 2021, 10:36 PM
ovasileva triaged this task as Medium priority.Jun 24 2021, 9:17 AM
Jdlrobson added a project: Notifications.EditedJun 24 2021, 3:37 PM
Jdlrobson subscribed.

Is this a Regression?

Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 24 2021, 3:37 PM
• nray added a comment.EditedJun 24 2021, 8:19 PM

@Jdlrobson This bug will only surface on new Vector when $wgVectorConsolidateUserLinks = [ 'logged_in' => true ] . Given that $wgVectorConsolidateUserLinks is not enabled in production yet, I don't think it's currently affecting users

Edit: More specifically, it will affect anything that uses the data-notifications portlet (which new Vector uses when the wgVectorConsolidateUserLinks flag is enabled). It looks like there is at least one other skin (Mirage) that uses this [1] so it might be affecting that skin as well

[1] https://gerrit.wikimedia.org/g/mediawiki/skins/Mirage/+/e816f43f9f8ec872ed61e2e06b353688b08a7be8/resources/templates/Header.mustache#16

Jdlrobson awarded a token.Jun 24 2021, 8:33 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
• mewoph moved this task from Inbox to Triaged on the Growth-Team board.Jun 24 2021, 9:27 PM
LGoto set the point value for this task to 2.Jun 29 2021, 5:38 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
• nray added a comment.Jun 29 2021, 5:39 PM

We estimated this a small based on the simplest option of changing the id to pt-talk-alert in Echo. If we want to instead change the default id for this in core, then we should reestimate this ticket as that work would likely be larger than a small.

bwang claimed this task.Jul 12 2021, 8:52 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
bwang removed bwang as the assignee of this task.Jul 13 2021, 4:24 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
bwang subscribed.
gerritbot added a comment.Jul 13 2021, 4:40 PM

Change 704351 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/Echo@master] Hardcode talk alert id to be pt-talk-alert

https://gerrit.wikimedia.org/r/704351

LGoto assigned this task to cjming.Jul 13 2021, 5:09 PM
cjming reassigned this task from cjming to Edtadros.Jul 13 2021, 7:22 PM
cjming moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
cjming subscribed.
gerritbot added a comment.Jul 13 2021, 7:29 PM

Change 700717 abandoned by Nray:

[mediawiki/extensions/Echo@master] Explicitly set 'pt-talk-alert' id for talk alert

Reason:

see I3b46a494682b3b5055f525c0c1219a1710655ce5

https://gerrit.wikimedia.org/r/700717

gerritbot added a comment.Jul 13 2021, 7:42 PM

Change 704351 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Hardcode talk alert id to be pt-talk-alert

https://gerrit.wikimedia.org/r/704351

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 13 2021, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 13 2021, 8:10 PM
cjming mentioned this in T284243: User Links: "You have new talk page messages" at lower resolutions.Jul 14 2021, 10:41 PM
Edtadros reassigned this task from Edtadros to bwang.Jul 29 2021, 7:42 PM
Edtadros moved this task from QA to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Edtadros subscribed.

Test Result - Beta

Status: ❌ Fail
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

In an incognito window, go to your user's talk page on beta (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Nray_beta)
Click the "New section" tab.
Write "Hello" for the "Subject/headline" field. Write Hello [[User:Nray_beta]] ~~~~ for the body making sure to replace Nray_beta with your user's username.
Click Publish changes
Go to https://en.wikipedia.beta.wmflabs.org and login with your user.
You should see the orange alert saying "You have a new Talk page message".
Click the bell icon to open the alerts popover.
Click the "Mark all as read" button

❌ AC1: Orange Alert should disappear.

Screen Recording 2021-07-29 at 12.35.43 PM.mov.gif (920×870 px, 744 KB)

Orange alert does not disappear unless I refresh the page.

Edtadros updated the task description. (Show Details)Jul 29 2021, 7:43 PM
• nray added a comment.EditedJul 29 2021, 8:18 PM

Thanks @Edtadros !

Something interesting is going on here as it seems to work for me:

record.gif (1×1 px, 1 MB)

Jdlrobson reassigned this task from bwang to Edtadros.Jul 30 2021, 7:28 PM
Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Also working for me. @Edtadros could you try again? This time could you open your developer console and see if an errors show there?

Edtadros added a comment.Jul 31 2021, 12:12 AM

@nray / @Jdlrobson I must've had some gremlins in my machine. It works fine now. I can't reproduce the issue. I'll update the results and pass it.

Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 31 2021, 12:16 AM

Test Result - Beta

Status: ✅ Pass
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

In an incognito window, go to your user's talk page on beta (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Nray_beta)
Click the "New section" tab.
Write "Hello" for the "Subject/headline" field. Write Hello [[User:Nray_beta]] ~~~~ for the body making sure to replace Nray_beta with your user's username.
Click Publish changes
Go to https://en.wikipedia.beta.wmflabs.org and login with your user.
You should see the orange alert saying "You have a new Talk page message".
Click the bell icon to open the alerts popover.
Click the "Mark all as read" button

✅ AC1: Orange Alert should disappear.
The issue seen in T285442#7247201 was not reproducible

Screen Recording 2021-07-30 at 5.09.37 PM.mov.gif (1×814 px, 556 KB)

Screen Recording 2021-07-30 at 5.04.34 PM.mov.gif (1×814 px, 866 KB)

Edtadros updated the task description. (Show Details)Jul 31 2021, 12:17 AM
Edtadros reassigned this task from Edtadros to ovasileva.Jul 31 2021, 12:24 AM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Test Result - Beta

Status: ✅ Pass
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

In an incognito window, go to your user's talk page on beta (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Nray_beta)
Click the "New section" tab.
Write "Hello" for the "Subject/headline" field. Write Hello [[User:Nray_beta]] ~~~~ for the body making sure to replace Nray_beta with your user's username.
Click Publish changes
Go to https://en.wikipedia.beta.wmflabs.org and login with your user.
You should see the orange alert saying "You have a new Talk page message".
Click the bell icon to open the alerts popover.
Click the "Mark all as read" button

✅ AC1: Orange Alert should disappear.

Screen Recording 2021-07-30 at 5.23.16 PM.mov.gif (1×814 px, 903 KB)

Edtadros updated the task description. (Show Details)Jul 31 2021, 12:24 AM
ovasileva closed this task as Resolved.Aug 2 2021, 4:04 PM
cjming mentioned this in T287996: [testwiki - wmf.17] New user links desktop: long yellow talk message banner pushes user links off screen.Aug 6 2021, 9:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits