| RHo | |
| Jul 28 2021, 9:10 PM |
| F34570042: 2.png | |
| Jul 30 2021, 3:53 AM |
| F34570041: 1.png | |
| Jul 30 2021, 3:53 AM |
| F34568609: Screen Shot 2021-07-28 at 3.39.44 PM.png | |
| Jul 28 2021, 10:40 PM |
| F34568606: Screen Shot 2021-07-28 at 3.38.50 PM.png | |
| Jul 28 2021, 10:40 PM |
| F34568452: image.png | |
| Jul 28 2021, 9:10 PM |
| F33997217: image.png | |
| Jul 28 2021, 9:10 PM |
Per T269644, the expected text below the article title should be the article extract (first sentences of the article), and not the article description (either local short descriptions or from Wikidata). In both cswiki and viwiki (and likely beyond), we are seeing only the article descriptions.
Expected:  | Actual  |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | MMiller_WMF | T252822 [EPIC] Growth: "add a link" structured task 1.0 | |||
| Resolved | kostajh | T268704 Add a link: frontend product specifications | |||
| Resolved | • mewoph | T269644 Add a link: link inspector | |||
| Resolved | • mewoph | T287636 Add a link: link inspector should show article extract, not article description |
The short description presence (or absence) varies per wiki - only about 40% of recommended links articles on cswiki have a short description (bnwiki ~60%, arwiki ~90%).
Currently the link preview is generated via ve.ui.MWInternalLinkContextItem.static.generateBody which uses page description.
Change 708602 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Add a link: Show article extract instead of description in the link inspector
Change 708848 had a related patch set uploaded (by Gergő Tisza; author: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.16] Add a link: Show article extract instead of description in the link inspector
Change 708602 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add a link: Show article extract instead of description in the link inspector
Change 708848 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.16] Add a link: Show article extract instead of description in the link inspector
I was careless with the testing and only caught this issue during backporting (which was aborted): when you display a recommendation for the first time, both the extract and the description are shown. (If you skip it and return it will look OK.)
 |  |
Maybe the description is loaded asynchronously so the code checking for its existence runs too early?
Thanks @Tgr — you're right, it's added asynchronously (I don't have Wikibase set up locally so I faked it so it was always returned before the extract).
linkCache.get( title ).then( function ( linkData ) {
if ( usePageImages ) {
if ( linkData.imageUrl ) {
icon.$element
.addClass( 've-ui-mwInternalLinkContextItem-hasImage' )
.css( 'background-image', 'url(' + linkData.imageUrl + ')' );
} else {
icon.setIcon( ve.init.platform.linkCache.constructor.static.getIconForLink( linkData ) );
}
}
if ( usePageDescriptions && linkData.description ) {
$description = $( '<span>' )
.addClass( 've-ui-mwInternalLinkContextItem-description' )
.text( linkData.description );
$wrapper.append( $description );
// Multiline descriptions may make the context bigger (T183650)
context.updateDimensions();
}
} );Change 709086 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Add a link: Hide ve-ui-mwInternalLinkContextItem-description
Yeah, same here. I wish we could somehow make T282170: Move "Short Descriptions" feature outside of main Wikibase.git code happen - a lot of teams are using descriptions now and it has definitely become a testing pain point. Maybe a topic for the retro.
Change 709086 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add a link: Hide ve-ui-mwInternalLinkContextItem-description
Change 709256 had a related patch set uploaded (by Gergő Tisza; author: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.16] Add a link: Show article extract instead of description in the link inspector
Change 709256 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.16] Add a link: Show article extract instead of description in the link inspector
Mentioned in SAL (#wikimedia-operations) [2021-08-02T18:30:39Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.16/extensions/GrowthExperiments/extension.json: 05cf1d6de1695d2e38531f3fecb26381f4dc0b1d: Add a link: Show article extract instead of description in the link inspector (T287636; 1/2) (duration: 00m 57s)
Mentioned in SAL (#wikimedia-operations) [2021-08-02T18:31:55Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.16/extensions/GrowthExperiments/modules/: 05cf1d6de1695d2e38531f3fecb26381f4dc0b1d: Add a link: Show article extract instead of description in the link inspector (T287636; 2/2) (duration: 00m 56s)