Page MenuHomePhabricator
Create Task
Maniphest T287704

TypeError: Argument 2 passed to Wikibase\Client\DataAccess\Scribunto\Scribunto_LuaWikibaseEntityLibrary::addLabelUsage() must be of the type string, null given, called in /srv/mediawiki/php-1.37.0-wmf.16/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxCallback.php on line 26
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 2 passed to Wikibase\Client\DataAccess\Scribunto\Scribunto_LuaWikibaseEntityLibrary::addLabelUsage() must be of the type string, null given, called in /srv/mediawiki/php-1.37.0-wmf.16/extensions/Scribunto/in
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.16/extensions/Wikibase/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibrary.php(176)
#0 /srv/mediawiki/php-1.37.0-wmf.16/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxCallback.php(26): Wikibase\Client\DataAccess\Scribunto\Scribunto_LuaWikibaseEntityLibrary->addLabelUsage(string, NULL)
#1 [internal function]: Scribunto_LuaSandboxCallback->__call(string, array)
#2 /srv/mediawiki/php-1.37.0-wmf.16/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxInterpreter.php(113): LuaSandboxFunction->call(LuaSandboxFunction)
#3 /srv/mediawiki/php-1.37.0-wmf.16/extensions/Scribunto/includes/engines/LuaCommon/LuaEngine.php(297): Scribunto_LuaSandboxInterpreter->callFunction(LuaSandboxFunction, LuaSandboxFunction)
#4 /srv/mediawiki/php-1.37.0-wmf.16/extensions/Scribunto/includes/engines/LuaCommon/LuaModule.php(68): Scribunto_LuaEngine->executeFunctionChunk(LuaSandboxFunction, PPTemplateFrame_Hash)
#5 /srv/mediawiki/php-1.37.0-wmf.16/extensions/Scribunto/includes/common/Hooks.php(128): Scribunto_LuaModule->invoke(string, PPTemplateFrame_Hash)
#6 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/Parser.php(3393): ScribuntoHooks::invokeHook(Parser, PPTemplateFrame_Hash, array)
#7 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/Parser.php(3078): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#8 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#9 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/Parser.php(2992): PPFrame_Hash->expand(PPNode_Hash_Tree)
#10 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#11 /srv/mediawiki/php-1.37.0-wmf.16/extensions/ParserFunctions/includes/ParserFunctions.php(123): PPFrame_Hash->expand(PPNode_Hash_Tree)
#12 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/Parser.php(3393): MediaWiki\Extensions\ParserFunctions\ParserFunctions::if(Parser, PPTemplateFrame_Hash, array)
#13 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/Parser.php(3078): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#14 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#15 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/PPTemplateFrame_Hash.php(178): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#16 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/PPTemplateFrame_Hash.php(190): PPTemplateFrame_Hash->getNamedArgument(string)
#17 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/Parser.php(3874): PPTemplateFrame_Hash->getArgument(string)
#18 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/PPFrame_Hash.php(280): Parser->argSubstitution(array, PPTemplateFrame_Hash)
#19 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/Parser.php(2992): PPFrame_Hash->expand(PPNode_Hash_Tree)
#20 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#21 /srv/mediawiki/php-1.37.0-wmf.16/extensions/ParserFunctions/includes/ParserFunctions.php(146): PPFrame_Hash->expand(PPNode_Hash_Tree)
#22 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/Parser.php(3393): MediaWiki\Extensions\ParserFunctions\ParserFunctions::ifeq(Parser, PPTemplateFrame_Hash, array)
#23 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/Parser.php(3078): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#24 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#25 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/Parser.php(3267): PPFrame_Hash->expand(PPNode_Hash_Tree)
#26 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#27 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/Parser.php(3267): PPFrame_Hash->expand(PPNode_Hash_Tree)
#28 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPFrame_Hash)
#29 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/Parser.php(2916): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#30 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/Parser.php(1584): Parser->replaceVariables(string)
#31 /srv/mediawiki/php-1.37.0-wmf.16/includes/parser/Parser.php(645): Parser->internalParse(string)
#32 /srv/mediawiki/php-1.37.0-wmf.16/includes/content/WikitextContent.php(375): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#33 /srv/mediawiki/php-1.37.0-wmf.16/includes/content/AbstractContent.php(534): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#34 /srv/mediawiki/php-1.37.0-wmf.16/includes/Revision/RenderedRevision.php(266): AbstractContent->getParserOutput(Title, integer, ParserOptions, boolean)
#35 /srv/mediawiki/php-1.37.0-wmf.16/includes/Revision/RenderedRevision.php(235): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#36 /srv/mediawiki/php-1.37.0-wmf.16/includes/Revision/RevisionRenderer.php(217): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#37 /srv/mediawiki/php-1.37.0-wmf.16/includes/Revision/RevisionRenderer.php(154): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#38 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#39 /srv/mediawiki/php-1.37.0-wmf.16/includes/Revision/RenderedRevision.php(197): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#40 /srv/mediawiki/php-1.37.0-wmf.16/includes/jobqueue/jobs/RefreshLinksJob.php(278): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput(array)
#41 /srv/mediawiki/php-1.37.0-wmf.16/includes/jobqueue/jobs/RefreshLinksJob.php(198): RefreshLinksJob->getParserOutput(MediaWiki\Revision\RevisionRenderer, ParserCache, WikiPage, BufferingStatsdDataFactory)
#42 /srv/mediawiki/php-1.37.0-wmf.16/includes/jobqueue/jobs/RefreshLinksJob.php(136): RefreshLinksJob->runForTitle(Title)
#43 /srv/mediawiki/php-1.37.0-wmf.16/extensions/EventBus/includes/JobExecutor.php(79): RefreshLinksJob->run()
#44 /srv/mediawiki/rpc/RunSingleJob.php(76): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#45 {main}
Impact
Notes

Details

SubjectRepoBranchLines +/-
Fail safely if language in Lua is not a stringmediawiki/extensions/Wikibasemaster+35 -0
Add regression unit-tests for Label/Desc usage without lang codemediawiki/extensions/Wikibasemaster+18 -0
Let language parameter accept null in Scribunto_LuaWikibaseEntityLibrarymediawiki/extensions/Wikibasemaster+6 -6
Let language parameter accept null in Scribunto_LuaWikibaseEntityLibrarymediawiki/extensions/Wikibasewmf/1.37.0-wmf.16+6 -6
Revert "Add types for files touch in the following commits"mediawiki/extensions/Wikibasemaster+321 -161
Customize query in gerrit

Related Objects

Event Timeline

• mmodell created this task.Jul 29 2021, 7:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2021, 7:22 PM
• mmodell triaged this task as Unbreak Now! priority.Jul 29 2021, 7:24 PM
• mmodell added projects: LuaSandbox, Wikibase-Lua.

This is breaking in production, I'm rolling back the train

• mmodell added a parent task: T281157: 1.37.0-wmf.16 deployment blockers.Jul 29 2021, 7:25 PM
• mmodell added a subscriber: Michael.Jul 29 2021, 7:34 PM

Looks like this was caused by rEWBA90f8a7446019: Add types for files touch in the following commits

Legoktm removed a project: LuaSandbox.Jul 29 2021, 7:38 PM
Legoktm subscribed.

Not an issue with LuaSandbox, but the Scribunto_LuaWikibaseEntityLibrary

Legoktm unsubscribed.Jul 29 2021, 7:38 PM
gerritbot added a comment.Jul 29 2021, 7:42 PM

Change 708642 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/Wikibase@master] Revert \"Add types for files touch in the following commits\"

https://gerrit.wikimedia.org/r/708642

gerritbot added a project: Patch-For-Review.Jul 29 2021, 7:42 PM

Change 708642 abandoned by Legoktm:

[mediawiki/extensions/Wikibase@master] Revert \"Add types for files touch in the following commits\"

Reason:

Doesn't cleanly apply

https://gerrit.wikimedia.org/r/708642

Maintenance_bot added a project: Wikidata.Jul 29 2021, 7:45 PM
Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptJul 29 2021, 7:45 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 29 2021, 8:10 PM
Krinkle moved this task from Untriaged to July 2021 on the Wikimedia-production-error board.Jul 29 2021, 8:20 PM
gerritbot added a comment.Jul 29 2021, 8:23 PM

Change 708834 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Wikibase@master] Let language parameter accept null in Scribunto_LuaWikibaseEntityLibrary

https://gerrit.wikimedia.org/r/708834

gerritbot added a project: Patch-For-Review.Jul 29 2021, 8:23 PM
Ladsgroup claimed this task.Jul 29 2021, 8:26 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 29 2021, 8:26 PM
Ladsgroup added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jul 29 2021, 8:26 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jul 29 2021, 8:33 PM

Change 708644 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.16] Let language parameter accept null in Scribunto_LuaWikibaseEntityLibrary

https://gerrit.wikimedia.org/r/708644

Addshore moved this task from Inbox to Active on the [DEPRECATED] wdwb-tech board.Jul 29 2021, 8:49 PM
Addshore subscribed.
Zabe subscribed.Jul 29 2021, 8:53 PM
gerritbot added a comment.Jul 29 2021, 8:57 PM

Change 708644 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.16] Let language parameter accept null in Scribunto_LuaWikibaseEntityLibrary

https://gerrit.wikimedia.org/r/708644

Stashbot added a comment.Jul 29 2021, 8:59 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-29T20:59:37Z] <ladsgroup@deploy1002> Synchronized php-1.37.0-wmf.16/extensions/Wikibase/client: Backport: [[gerrit:708644|Let language parameter accept null in Scribunto_LuaWikibaseEntityLibrary (T287704)]] (duration: 01m 09s)

gerritbot added a comment.Jul 29 2021, 9:00 PM

Change 708834 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Let language parameter accept null in Scribunto_LuaWikibaseEntityLibrary

https://gerrit.wikimedia.org/r/708834

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Jul 29 2021, 9:00 PM
• mmodell lowered the priority of this task from Unbreak Now! to Needs Triage.EditedJul 29 2021, 9:29 PM

The immediate error is resolved. Not sure if there are more code changes needed to call this resolved. At least it's no longer blocking T281157: 1.37.0-wmf.16 deployment blockers

Thanks all for jumping on this and getting the train unblocked in nearly record time!

• mmodell removed a parent task: T281157: 1.37.0-wmf.16 deployment blockers.Jul 29 2021, 9:29 PM
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.17; 2021-08-02); removed MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Jul 29 2021, 10:00 PM
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 30 2021, 6:29 AM

I think the ticket is done, I leave it to my fellow campers and @Addshore to close it or not. The patch wasn't a band-aid.

gerritbot added a comment.Jul 30 2021, 8:26 AM

Change 708978 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Add regression test for Label/Desc usage without lang code

https://gerrit.wikimedia.org/r/708978

Addshore moved this task from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 2 2021, 10:39 AM

Moving to review as there is an open regression test to review

Ladsgroup moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 2 2021, 11:28 AM

Technically doing, the patch is not ready for review.

Ladsgroup reassigned this task from Ladsgroup to Michael.Aug 2 2021, 1:07 PM
Ladsgroup subscribed.

Michael is writing the regression tests.

Restricted Application added a project: User-Michael. · View Herald TranscriptAug 2 2021, 1:07 PM
Michael moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 2 2021, 5:33 PM
gerritbot added a comment.Aug 3 2021, 9:38 AM

Change 708978 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add regression unit-tests for Label/Desc usage without lang code

https://gerrit.wikimedia.org/r/708978

Ladsgroup moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 3 2021, 1:22 PM
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.18; 2021-08-09); removed MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Aug 3 2021, 3:00 PM
gerritbot added a comment.Aug 4 2021, 2:17 PM

Change 710049 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Fail safely if language in Lua is not a string

https://gerrit.wikimedia.org/r/710049

gerritbot added a comment.Aug 6 2021, 3:11 PM

Change 710049 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fail safely if language in Lua is not a string

https://gerrit.wikimedia.org/r/710049

Michael moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 9 2021, 9:07 AM
Lucas_Werkmeister_WMDE subscribed.Aug 9 2021, 11:11 AM

What’s left to review here? All the attached Gerrit changes are merged, as far as I can tell.

Michael moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 9 2021, 11:16 AM

Ah, in my mind https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/710053 was still associated with this task, but you're right that that patch is just additional cleanup and not really related to guarding against a repetition of this incident. Moving this on to verification.

Lucas_Werkmeister_WMDE added a comment.Aug 9 2021, 11:24 AM

I’d also be okay with leaving this in peer review, it should just have some sort of link then ^^

Addshore closed this task as Resolved.Aug 11 2021, 12:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits