@Etonkovidova Thanks for triaging this. Can you say more about why this Needs Discussion/Analysis? :)

In T289722#7310781, @MBinder_WMF wrote:

@Etonkovidova Thanks for triaging this. Can you say more about why this Needs Discussion/Analysis? :)

The priority of the task needs to be evaluated - it might be moved to the Current sprint or, taking into account, this discussion on T283109, the behavior described in this task might be marked as expected.

The underlying technical issue is that editing an article might or might not make the link recommendations incorrect (the recommendations are something like "find the third occurrence of the word 'foo' and link it to 'Bar'" so if an edit removes the first occurrence of 'foo' the recommendation will end up in the wrong place), and instead of trying to deal with that, we just invalidate the recommendation.

You are right that it does not make much sense to allow the user to get back into machine editing mode if that is the case, although I'm not sure if this edge case is worth adding code for.

Resolved - the issue existed due to the the post-edit dialog not being present.
(current behavior in testwiki wmf.23) Testing workflows when a user returns to add more links after only partially completing the Add link structured task:

1. a user goes to add link structured task article and accepts one link. The article has more links to be reviewed.
2. a user submits (publishes) the added link.
3. a user clicks on Edit and then switches back to Suggestions. The Suggestions editing surface presents remaining add links tasks.
4. a user adds another link and after clicking on "Publish changes", the following warning is displayed:

The article would be still present in the user feed, so it's not a genuine conflict.

In T289722#7736260, @Etonkovidova wrote:

Resolved - the issue existed due to the the post-edit dialog not being present.
(current behavior in testwiki wmf.23) Testing workflows when a user returns to add more links after only partially completing the Add link structured task:

1. a user goes to add link structured task article and accepts one link. The article has more links to be reviewed.
2. a user submits (publishes) the added link.
3. a user clicks on Edit and then switches back to Suggestions. The Suggestions editing surface presents remaining add links tasks.
4. a user adds another link and after clicking on "Publish changes", the following warning is displayed:

The article would be still present in the user feed, so it's not a genuine conflict.

From what I can tell (just checked on testwiki), these steps are not possible. When the post-edit dialog is closed, the page is reloaded, and the user cannot enter into suggestions mode again. Could you please verify again if you're still seeing this issue?

In T289722#7744221, @kostajh wrote:

In T289722#7736260, @Etonkovidova wrote:

Resolved - the issue existed due to the the post-edit dialog not being present.

From what I can tell (just checked on testwiki), these steps are not possible. When the post-edit dialog is closed, the page is reloaded, and the user cannot enter into suggestions mode again. Could you please verify again if you're still seeing this issue?

Yes, the issue is not present anymore (I realized that my comment was not clear about that temporary issue). But the original issue (the steps in the task description) is still present. I re-checked it in wmf.23 testwiki.

In T289722#7745947, @Etonkovidova wrote:

In T289722#7744221, @kostajh wrote:

In T289722#7736260, @Etonkovidova wrote:

Resolved - the issue existed due to the the post-edit dialog not being present.

From what I can tell (just checked on testwiki), these steps are not possible. When the post-edit dialog is closed, the page is reloaded, and the user cannot enter into suggestions mode again. Could you please verify again if you're still seeing this issue?

Yes, the issue is not present anymore (I realized that my comment was not clear about that temporary issue). But the original issue (the steps in the task description) is still present. I re-checked it in wmf.23 testwiki.

Hmm, @Etonkovidova I am confused because step 3 ("Switch back to the Suggestions mode (click on Edit, then select Suggestions mode)." should not be possible. But you are seeing that on testwiki?

In T289722#7835305, @kostajh wrote:

Hmm, @Etonkovidova I am confused because step 3 ("Switch back to the Suggestions mode (click on Edit, then select Suggestions mode)." should not be possible. But you are seeing that on testwiki?

I re-checked the steps in the task description on testwiki wmf.6. Yes, the steps still produce "Another user edited this article while you were reviewing it..." message, so the issue is still present.

Switching back to Suggestions mode after making edits in VE (and publishing them) is possible for both structured tasks - Add link and Add image. For Add image tasks there will be no Edit conflict message when a user follows the steps in the task description.

In T289722#7839374, @Etonkovidova wrote:

In T289722#7835305, @kostajh wrote:

Hmm, @Etonkovidova I am confused because step 3 ("Switch back to the Suggestions mode (click on Edit, then select Suggestions mode)." should not be possible. But you are seeing that on testwiki?

I re-checked the steps in the task description on testwiki wmf.6. Yes, the steps still produce "Another user edited this article while you were reviewing it..." message, so the issue is still present.

Switching back to Suggestions mode after making edits in VE (and publishing them) is possible for both structured tasks - Add link and Add image. For Add image tasks there will be no Edit conflict message when a user follows the steps in the task description.

Ah, right. I see. So, I guess this is a product/design question about what the user experience should be cc @RHo @MMiller_WMF. I think this probably happens rarely enough in practice (the user has to start in machine suggestions mode, switch to VE, edit and publish, then try to switch back to suggestions mode) that I don't think we should do anything to try to prevent the behavior documented in the task description.

In T289722#7842211, @kostajh wrote:

In T289722#7839374, @Etonkovidova wrote:

In T289722#7835305, @kostajh wrote:

Hmm, @Etonkovidova I am confused because step 3 ("Switch back to the Suggestions mode (click on Edit, then select Suggestions mode)." should not be possible. But you are seeing that on testwiki?

I re-checked the steps in the task description on testwiki wmf.6. Yes, the steps still produce "Another user edited this article while you were reviewing it..." message, so the issue is still present.

Switching back to Suggestions mode after making edits in VE (and publishing them) is possible for both structured tasks - Add link and Add image. For Add image tasks there will be no Edit conflict message when a user follows the steps in the task description.

Ah, right. I see. So, I guess this is a product/design question about what the user experience should be cc @RHo @MMiller_WMF. I think this probably happens rarely enough in practice (the user has to start in machine suggestions mode, switch to VE, edit and publish, then try to switch back to suggestions mode) that I don't think we should do anything to try to prevent the behavior documented in the task description.

Ideally I think we should remove ability for the user to edit the structured task for links after they have made edits in VE mode, since technically the structured task is invalidated by some change to the text from the edit. And even more ideally the user should be given a message saying <Edit type> is no longer available.
@kostajh and @Tgr - is this something that you think is relatively low effort to implement - with or without the message?

In T289722#7898925, @RHo wrote:

In T289722#7842211, @kostajh wrote:

In T289722#7839374, @Etonkovidova wrote:

In T289722#7835305, @kostajh wrote:

Hmm, @Etonkovidova I am confused because step 3 ("Switch back to the Suggestions mode (click on Edit, then select Suggestions mode)." should not be possible. But you are seeing that on testwiki?

I re-checked the steps in the task description on testwiki wmf.6. Yes, the steps still produce "Another user edited this article while you were reviewing it..." message, so the issue is still present.

Switching back to Suggestions mode after making edits in VE (and publishing them) is possible for both structured tasks - Add link and Add image. For Add image tasks there will be no Edit conflict message when a user follows the steps in the task description.

Ah, right. I see. So, I guess this is a product/design question about what the user experience should be cc @RHo @MMiller_WMF. I think this probably happens rarely enough in practice (the user has to start in machine suggestions mode, switch to VE, edit and publish, then try to switch back to suggestions mode) that I don't think we should do anything to try to prevent the behavior documented in the task description.

Ideally I think we should remove ability for the user to edit the structured task for links after they have made edits in VE mode, since technically the structured task is invalidated by some change to the text from the edit. And even more ideally the user should be given a message saying <Edit type> is no longer available.
@kostajh and @Tgr - is this something that you think is relatively low effort to implement - with or without the message?

We could probably reload the page after the VE edit, so that the link recommendation plugin is unloaded, then the post-edit dialog would prompt the user to edit the article again and/or to take them back to Special:Homepage.

But it looks like we don't show the post-edit dialog in this specific scenario, so that's something we should fix first.

But it looks like we don't show the post-edit dialog in this specific scenario, so that's something we should fix first.

@RHo @kostajh UX-wise I wonder if it would be weird to show the post-edit dialog in this case since the user isn't really doing a suggested edit. I think a custom dialog might make more sense here. To prevent the user from switching back, I think we would need custom behavior anyway since with T301603: Newcomer tasks: increased flexibility at post-edit dialog, the user is no longer prevented from clicking on the article surface when the post-edit dialog is shown.

In T289722#7900033, @mewoph wrote:

But it looks like we don't show the post-edit dialog in this specific scenario, so that's something we should fix first.

@RHo @kostajh UX-wise I wonder if it would be weird to show the post-edit dialog in this case since the user isn't really doing a suggested edit. I think a custom dialog might make more sense here. To prevent the user from switching back, I think we would need custom behavior anyway since with T301603: Newcomer tasks: increased flexibility at post-edit dialog, the user is no longer prevented from clicking on the article surface when the post-edit dialog is shown.

I agree @mewoph - this would be a different dialog explaining that the structured task is no longer available, but give them the option to do another VE or return to their homepage to look at other suggested edits.