Page MenuHomePhabricator
Create Task
Maniphest T290688

Drop support for legacy search in modern Vector
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Jdlrobson
Authored By
Jdlrobson
Sep 9 2021, 7:13 PM
Tags
Referenced Files
F34940078: Screen Recording 2022-02-01 at 2.30.28 PM.mov.gif
Feb 1 2022, 10:45 PM
F34940080: Screen Recording 2022-02-01 at 2.33.44 PM.mov.gif
Feb 1 2022, 10:45 PM
Subscribers
Addshore
Aklapper
bwang
Dereckson
Edtadros
Jdlrobson
karapayneWMDE
View All 10 Subscribers
Tokens
"Love" token, awarded by Jdlrobson.

Description

Modern Vector currently supports WVUI and a legacy jquery autocomplete search. This currently only supports Wikidata and means we have to test multiple implementations when running changes on search.

Going forward, we'd like to not have to do this.

TODO

  • Remove VectorUseWvuiSearch feature flag.
  • Drop VectorSearchTreatmentABTest and related code.
  • For Wikidata, for now we'll hardcode a check isWikidata = mw.config.get( 'wgWikiID' ) === 'wikidatawiki', and not load any search experience in this situation. The Wikimedia DE team will remove this when they are ready.

QA

Expected: search should not autocomplete when search input is focused and I type.

Expected: search should autocomplete when search input is focused and I type.

QA Results - Beta

ACStatusDetails
1✅T290688#7669391
2❌T290688#7669391

Details

SubjectRepoBranchLines +/-
Drop search related feature flagsmediawiki/skins/Vectormaster+11 -304
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Sep 9 2021, 7:13 PM
Jdlrobson triaged this task as High priority.Sep 9 2021, 7:16 PM
Jdlrobson mentioned this in T275251: New Vector Search is not Wikidata aware.
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptSep 9 2021, 7:17 PM
Jdlrobson renamed this task from Drop support for legacy search in Vector to Drop support for legacy search in modern Vector.Sep 9 2021, 7:17 PM
gerritbot added a comment.Sep 9 2021, 7:19 PM

Change 720090 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Drop search related feature flags

https://gerrit.wikimedia.org/r/720090

gerritbot added a project: Patch-For-Review.Sep 9 2021, 7:19 PM
Jdlrobson moved this task from Backlog to Using Codex in web team products / Skin unification on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Sep 9 2021, 7:23 PM
Addshore subscribed.Sep 16 2021, 8:52 AM
Jdlrobson moved this task from Incoming to Search on the Desktop Improvements (Vector 2022) board.Sep 16 2021, 9:49 PM
Addshore moved this task from Inbox to External Realm on the [DEPRECATED] wdwb-tech board.Sep 17 2021, 7:37 AM
gerritbot added a comment.Sep 30 2021, 6:29 PM

Change 720090 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Drop search related feature flags

Reason:

Not working on this now. Waiting to hear back on the Phabricator ticket from WMDE. Will push forward with something along these lines in November.

https://gerrit.wikimedia.org/r/720090

Maintenance_bot removed a project: Patch-For-Review.Sep 30 2021, 7:10 PM
Jdlrobson claimed this task.Nov 1 2021, 5:19 PM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog (Needs Prioritization (Tech)).

November is here, so we will pushing ahead with removing the support for the jquery autocomplete suggestions in modern Vector shortly.

This change will mean that users using the new Vector skin on Wikidata will no longer get autocomplete, and will instead act like grade C browsers (those without JavaScript). Legacy Vector will behave as it did before.

Wikidata is welcome to continue to maintain the old search with Wikidata, by loading the module mediawiki.searchSuggest itself, either as part of the Wikidata extension or MediaWiki:Common.js

gerritbot added a comment.Nov 1 2021, 5:19 PM

Change 720090 restored by Jdlrobson:

[mediawiki/skins/Vector@master] Drop search related feature flags

https://gerrit.wikimedia.org/r/720090

gerritbot added a project: Patch-For-Review.Nov 1 2021, 5:19 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Nov 1 2021, 5:21 PM
Jdlrobson updated the task description. (Show Details)Nov 8 2021, 5:21 PM
Jdlrobson removed Jdlrobson as the assignee of this task.Dec 7 2021, 6:41 PM
Jdlrobson assigned this task to karapayneWMDE.Dec 7 2021, 10:32 PM
Jdlrobson moved this task from Upcoming to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson added a subscriber: karapayneWMDE.

@karapayneWMDE Based on the data in T275251#7534508 (Just under 300 users who made at least one edit in the past 30 days compared to just under 12k having it set to 1.), would you have any objections with me degrading the search for these users so that autocomplete is disabled?

Being able to do this leads to 300 lines of code removal which makes the codebase a bit easier to reason with https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/720090

karapayneWMDE reassigned this task from karapayneWMDE to Jdlrobson.Dec 10 2021, 2:46 PM

Heya!

So, the 100 active users is a non insignificant number for Wikidata, as such we'd like to send a proper communication to them before dropping support. Would it be alright to schedule the droppage for Monday January 31, 2022? This would give us enough time to get the word out and field any questions while taking into account the reduced capacity due to the winter holidays.

Thanks!

Jdlrobson added a comment.Dec 10 2021, 3:15 PM

Works for me!

Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog (Kanbanana-FY-2021-22).Dec 10 2021, 3:15 PM
Jdlrobson moved this task from Using Codex in web team products / Skin unification to WVUI migrations on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jan 19 2022, 10:37 PM
Jdlrobson added a comment.Jan 19 2022, 11:41 PM

@karapayneWMDE any updates from your side? We plan to move ahead with this change on Feb 1st.

Note, one option you have is you could set up a temporary gadget or Wikibase module for Wikidata provided you are happy maintaining that.

Jdlrobson added a project: MW-1.38-release.Jan 21 2022, 10:22 PM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog (Needs Prioritization (Tech)).Jan 24 2022, 4:39 PM
karapayneWMDE added a comment.Jan 25 2022, 8:10 AM

@Jdlrobson , communication went out and seems to have been received well enough. From our side, its okay-go for the change happening on Feb 1.

Jdlrobson removed Jdlrobson as the assignee of this task.Jan 25 2022, 4:35 PM
Jdlrobson awarded a token.
Jdlrobson moved this task from Blocked on Others to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
LGoto set the point value for this task to 2.Jan 27 2022, 6:29 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson claimed this task.Jan 27 2022, 8:31 PM
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson removed Jdlrobson as the assignee of this task.Jan 28 2022, 12:00 AM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
LGoto assigned this task to bwang.Jan 31 2022, 6:27 PM
bwang reassigned this task from bwang to Edtadros.Jan 31 2022, 9:51 PM
bwang moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang subscribed.
gerritbot added a comment.Jan 31 2022, 10:05 PM

Change 720090 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Drop search related feature flags

https://gerrit.wikimedia.org/r/720090

Jdlrobson updated the task description. (Show Details)Jan 31 2022, 10:28 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 31 2022, 11:00 PM
Edtadros reassigned this task from Edtadros to Jdlrobson.Feb 1 2022, 10:45 PM
Edtadros moved this task from QA to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Visit https://wikidata.beta.wmflabs.org/ and opt into modern Vector (2022)
Expected: search should not autocomplete when search input is focused and I type.

Screen Recording 2022-02-01 at 2.30.28 PM.mov.gif (326×858 px, 136 KB)

❌ AC2: Visit https://en.wikipedia.beta.wmflabs.org/wiki/Spain and opt into modern Vector (2022)
Expected: search should autocomplete when search input is focused and I type.
I'm not sure what autocomplete is supposed to look like here. But this doesn't look like autocomplete, and the results displayed after i type "appl" probably shouldn't show up.

Screen Recording 2022-02-01 at 2.33.44 PM.mov.gif (326×858 px, 95 KB)

Jdlrobson moved this task from Needs More Work to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Feb 1 2022, 10:48 PM

I'm not sure what autocomplete is supposed to look like here. But this doesn't look like autocomplete, and the results displayed after i type "appl" probably shouldn't show up.

This is a pass. We're looking for suggestions here so that's fine. Presumably Apollo matches appl as it's doing some kind of spelling correction.

Edtadros updated the task description. (Show Details)Feb 1 2022, 11:23 PM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.Feb 2 2022, 12:53 AM

For testing in production we just need to do the same on wikidata.org and en.wikipedia.org on Thursday.

LGoto reassigned this task from Edtadros to • nray.Feb 17 2022, 6:17 PM
• nray added a comment.EditedFeb 21 2022, 11:38 PM

Expected: search should not autocomplete when search input is focused and I type.

https://www.wikidata.org/wiki/Wikidata:Main_Page does display suggestions but not the WVUI suggestions so I assume this is okay.

cc @Jdlrobson

• nray removed • nray as the assignee of this task.Feb 21 2022, 11:39 PM
• nray updated the task description. (Show Details)
• nray moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
• nray subscribed.
Jdlrobson added a comment.Feb 22 2022, 12:03 AM

Interesting. That wasn't expected, but that seems fine. It looks like this code is being loaded:
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/9d9aa34ce2e4dc12cc1cf5ceadb0349c8300e245/client/resources/jquery.ui/jquery.ui.suggester.js#201 ( mediawiki.searchSuggest is not loaded).

Jdlrobson closed this task as Resolved.Feb 22 2022, 6:06 PM
Jdlrobson claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits