Page MenuHomePhabricator

Drop support for legacy search in modern Vector
Closed, ResolvedPublic2 Estimated Story Points

Description

Modern Vector currently supports WVUI and a legacy jquery autocomplete search. This currently only supports Wikidata and means we have to test multiple implementations when running changes on search.

Going forward, we'd like to not have to do this.

TODO

  • Remove VectorUseWvuiSearch feature flag.
  • Drop VectorSearchTreatmentABTest and related code.
  • For Wikidata, for now we'll hardcode a check isWikidata = mw.config.get( 'wgWikiID' ) === 'wikidatawiki', and not load any search experience in this situation. The Wikimedia DE team will remove this when they are ready.

QA

Expected: search should not autocomplete when search input is focused and I type.

Expected: search should autocomplete when search input is focused and I type.

QA Results - Beta

ACStatusDetails
1T290688#7669391
2T290688#7669391

Event Timeline

Jdlrobson renamed this task from Drop support for legacy search in Vector to Drop support for legacy search in modern Vector.Sep 9 2021, 7:17 PM

Change 720090 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Drop search related feature flags

https://gerrit.wikimedia.org/r/720090

Change 720090 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Drop search related feature flags

Reason:

Not working on this now. Waiting to hear back on the Phabricator ticket from WMDE. Will push forward with something along these lines in November.

https://gerrit.wikimedia.org/r/720090

November is here, so we will pushing ahead with removing the support for the jquery autocomplete suggestions in modern Vector shortly.

This change will mean that users using the new Vector skin on Wikidata will no longer get autocomplete, and will instead act like grade C browsers (those without JavaScript). Legacy Vector will behave as it did before.

Wikidata is welcome to continue to maintain the old search with Wikidata, by loading the module mediawiki.searchSuggest itself, either as part of the Wikidata extension or MediaWiki:Common.js

Change 720090 restored by Jdlrobson:

[mediawiki/skins/Vector@master] Drop search related feature flags

https://gerrit.wikimedia.org/r/720090

Jdlrobson added a subscriber: karapayneWMDE.

@karapayneWMDE Based on the data in T275251#7534508 (Just under 300 users who made at least one edit in the past 30 days compared to just under 12k having it set to 1.), would you have any objections with me degrading the search for these users so that autocomplete is disabled?

Being able to do this leads to 300 lines of code removal which makes the codebase a bit easier to reason with https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/720090

Heya!

So, the 100 active users is a non insignificant number for Wikidata, as such we'd like to send a proper communication to them before dropping support. Would it be alright to schedule the droppage for Monday January 31, 2022? This would give us enough time to get the word out and field any questions while taking into account the reduced capacity due to the winter holidays.

Thanks!

@karapayneWMDE any updates from your side? We plan to move ahead with this change on Feb 1st.

Note, one option you have is you could set up a temporary gadget or Wikibase module for Wikidata provided you are happy maintaining that.

@Jdlrobson , communication went out and seems to have been received well enough. From our side, its okay-go for the change happening on Feb 1.

bwang moved this task from Code Review to QA on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
bwang added a subscriber: bwang.

Change 720090 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Drop search related feature flags

https://gerrit.wikimedia.org/r/720090

Edtadros added a subscriber: Edtadros.

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Visit https://wikidata.beta.wmflabs.org/ and opt into modern Vector (2022)
Expected: search should not autocomplete when search input is focused and I type.

Screen Recording 2022-02-01 at 2.30.28 PM.mov.gif (326×858 px, 136 KB)

❌ AC2: Visit https://en.wikipedia.beta.wmflabs.org/wiki/Spain and opt into modern Vector (2022)
Expected: search should autocomplete when search input is focused and I type.
I'm not sure what autocomplete is supposed to look like here. But this doesn't look like autocomplete, and the results displayed after i type "appl" probably shouldn't show up.

Screen Recording 2022-02-01 at 2.33.44 PM.mov.gif (326×858 px, 95 KB)

I'm not sure what autocomplete is supposed to look like here. But this doesn't look like autocomplete, and the results displayed after i type "appl" probably shouldn't show up.

This is a pass. We're looking for suggestions here so that's fine. Presumably Apollo matches appl as it's doing some kind of spelling correction.

For testing in production we just need to do the same on wikidata.org and en.wikipedia.org on Thursday.

Expected: search should not autocomplete when search input is focused and I type.

https://www.wikidata.org/wiki/Wikidata:Main_Page does display suggestions but not the WVUI suggestions so I assume this is okay.

cc @Jdlrobson

nray removed nray as the assignee of this task.Feb 21 2022, 11:39 PM
nray updated the task description. (Show Details)
nray added a subscriber: nray.

Interesting. That wasn't expected, but that seems fine. It looks like this code is being loaded:
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/9d9aa34ce2e4dc12cc1cf5ceadb0349c8300e245/client/resources/jquery.ui/jquery.ui.suggester.js#201 ( mediawiki.searchSuggest is not loaded).

Jdlrobson claimed this task.