Page MenuHomePhabricator
Create Task
Maniphest T293310

Unable to change the target of internal links
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce:

  • Open a page with VisualEditor.
  • Type hello, select this word and open Link insertion tool.
  • Type Cat#diet as link target.

What happens?:

  • [[Cat]] page is displayed as a suggestion, but not in bold.
  • After pressing Done button, hello links to [[Hello]].

What should have happened instead?:

  • [[cat#diet]] should be displayed as a suggestion, in bold (as soon as [[Cat]] exists).
  • After pressing Done button, hello should link to [[cat#diet]].

Regression info:
In MW 1.38.0-wmf.3, we can add anchored link, but the page name with fragment is no more displayed in suggestions (I am pretty sure it was previously displayed, isn’t it?)
In MW 1.38.0-wmf.4, we cannot add any anchored link. Maybe because of 2984539f42128e5a445aaf6857b01584c2af2041.

Details

SubjectRepoBranchLines +/-
Fix value of 'namespacesWithSubpages' in wgVisualEditorConfigmediawiki/extensions/VisualEditormaster+2 -2
Fix value of 'namespacesWithSubpages' in wgVisualEditorConfigmediawiki/extensions/VisualEditorwmf/1.38.0-wmf.4+2 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasedancyT281168 1.38.0-wmf.4 deployment blockers
 ResolvedBUG REPORTmatmarexT293310 Unable to change the target of internal links

Event Timeline

Pols12 created this task.Oct 13 2021, 9:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2021, 9:44 PM
matmarex subscribed.Oct 13 2021, 11:10 PM

I can reproduce on https://en.wikipedia.beta.wmflabs.org/.

Error in browser console:

Uncaught TypeError: namespacesWithSubpages.indexOf is not a function
    at VeUiMWInternalLinkAnnotationWidget.ve.ui.MWInternalLinkAnnotationWidget.onTextChange (load.php?lang=en&modules=ext.visualEditor.core%2Cmwlink%2Cmwtransclusion%2Cwelcome|ext.visualEditor.mwimage.core&skin=vector&version=15snd:877)
    at OoUiSearchInputWidget.OO.EventEmitter.emit (<anonymous>:275:652)
    at OoUiSearchInputWidget.OO.ui.InputWidget.setValue (load.php?lang=en&modules=jquery%2Coojs-ui-core&skin=vector&version=15gmv:265)
    at load.php?lang=en&modules=jquery%2Coojs-ui-core&skin=vector&version=15gmv:265

The value of mw.config.get( 'wgVisualEditorConfig' ).namespacesWithSubpages is:

{
    "0": 1,
    "1": 2,
    "2": 3,
    "3": 4,
    "4": 5,
    "5": 7,
    "6": 9,
    "7": 10,
    "8": 11,
    "9": 12,
    "10": 13,
    "11": 14,
    "12": 15,
    "13": 100,
    "14": 101,
    "31": 118,
    "32": 119,
    "33": 190,
    "34": 191,
    "37": 828,
    "38": 829
}
matmarex triaged this task as Unbreak Now! priority.Oct 13 2021, 11:12 PM

Actually, the problem is more significant. I'm unable to change the target of any internal link.

matmarex renamed this task from We should still be able to add anchored link to page sections to Unable to change the target of internal links.Oct 13 2021, 11:12 PM
matmarex added a parent task: T281168: 1.38.0-wmf.4 deployment blockers.
Zabe subscribed.Oct 13 2021, 11:14 PM
gerritbot added a comment.Oct 13 2021, 11:16 PM

Change 730655 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Fix value of 'namespacesWithSubpages' in wgVisualEditorConfig

https://gerrit.wikimedia.org/r/730655

gerritbot added a project: Patch-For-Review.Oct 13 2021, 11:16 PM
ppelberg added a project: Editing-team (Kanban Board).Oct 13 2021, 11:21 PM
ppelberg moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.
ppelberg subscribed.
ppelberg added a comment.EditedOct 13 2021, 11:23 PM
In T293310#7426935, @matmarex wrote:

I'm unable to change the target of any internal link.

I too can reproduce this issue: https://meta.wikimedia.org/w/index.php?title=WikiArabia/2021/Program/07&diff=prev&oldid=22185109&diffmode=source.

ppelberg moved this task from Doing to Code Review on the Editing-team (Kanban Board) board.Oct 13 2021, 11:23 PM
DannyS712 added a comment.Oct 13 2021, 11:51 PM

+2'ed the patch, sorry for not catching this in my initial work

gerritbot added a comment.Oct 14 2021, 12:08 AM

Change 730655 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix value of 'namespacesWithSubpages' in wgVisualEditorConfig

https://gerrit.wikimedia.org/r/730655

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2021, 12:10 AM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 14 2021, 1:00 AM
gerritbot added a comment.Oct 14 2021, 2:29 PM

Change 730729 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.4] Fix value of 'namespacesWithSubpages' in wgVisualEditorConfig

https://gerrit.wikimedia.org/r/730729

gerritbot added a project: Patch-For-Review.Oct 14 2021, 2:29 PM
gerritbot added a comment.Oct 14 2021, 3:00 PM

Change 730729 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.4] Fix value of 'namespacesWithSubpages' in wgVisualEditorConfig

https://gerrit.wikimedia.org/r/730729

Stashbot added a comment.Oct 14 2021, 3:06 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-14T15:06:08Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.4/extensions/VisualEditor/includes/VisualEditorHooks.php: Backport: [[gerrit:730729|Fix value of 'namespacesWithSubpages' in wgVisualEditorConfig (T293310)]] (duration: 01m 04s)

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2021, 3:10 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Oct 14 2021, 3:19 PM
matmarex added a project: Editing QA.
matmarex added a subscriber: dancy.

Deployed by @dancy

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.4; 2021-10-12); removed MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 14 2021, 4:00 PM
EAkinloose subscribed.Oct 14 2021, 4:32 PM

I just checked this and it works as desired. Refer to the screenshot:

Screenshot 2021-10-14 at 17.28.18.png (586×1 px, 79 KB)

dancy closed this task as Resolved.Oct 14 2021, 6:05 PM
Jdforrester-WMF mentioned this in T293404: TypeError: namespacesWithSubpages.indexOf is not a function.Oct 14 2021, 7:23 PM
Jdforrester-WMF reopened this task as Open.Oct 14 2021, 7:29 PM
Jdforrester-WMF merged a task: T293404: TypeError: namespacesWithSubpages.indexOf is not a function.
Jdforrester-WMF added subscribers: Jdlrobson, Jdforrester-WMF.

@Jdlrobson filed a new task which looks like a dupe of this one, so re-opening.

matmarex added a comment.Oct 14 2021, 7:33 PM

Yes, that's the same error as I copied above, in T293310#7426928.

However, the issue is already fixed. The entries in Logstash stopped when we deployed the fix (a few stragglers must be coming from users who opened the editor before the patch and still have it open, or possibly cached code). You can see it here: https://logstash.wikimedia.org/goto/fab39a031e1915ecd6b147d5ad2890aa

image.png (489×2 px, 77 KB)

Jdforrester-WMF closed this task as Resolved.Oct 14 2021, 7:37 PM
Jdforrester-WMF assigned this task to matmarex.

Brilliant, thanks for confirming.

EAkinloose edited projects, added Verified; removed Editing QA.Oct 14 2021, 9:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL