Page MenuHomePhabricator
Create Task
Maniphest T293895

PHP Deprecated: Use of ParserOutput::getProperty was deprecated in MediaWiki 1.38. [Called from LqtDiscussionPager::getPageLimit]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of ParserOutput::getProperty was deprecated in MediaWiki 1.38. [Called from LqtDiscussionPager::getPageLimit]
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.5/extensions/LiquidThreads/pages/LqtDiscussionPager.php(30)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(375): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(351): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(230): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.38.0-wmf.5/includes/GlobalFunctions.php(1005): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/ParserOutput.php(1185): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.38.0-wmf.5/extensions/LiquidThreads/pages/LqtDiscussionPager.php(30): ParserOutput->getProperty(string)
#7 /srv/mediawiki/php-1.38.0-wmf.5/extensions/LiquidThreads/pages/LqtDiscussionPager.php(17): LqtDiscussionPager->getPageLimit()
#8 /srv/mediawiki/php-1.38.0-wmf.5/extensions/LiquidThreads/pages/TalkpageView.php(402): LqtDiscussionPager->__construct(Article, string)
#9 /srv/mediawiki/php-1.38.0-wmf.5/extensions/LiquidThreads/pages/TalkpageView.php(346): TalkpageView->getPager()
#10 /srv/mediawiki/php-1.38.0-wmf.5/extensions/LiquidThreads/classes/LqtDispatch.php(67): TalkpageView->show()
#11 /srv/mediawiki/php-1.38.0-wmf.5/extensions/LiquidThreads/classes/LqtDispatch.php(223): LqtDispatch::talkpageMain(OutputPage, Article, Title, User, WebRequest)
#12 /srv/mediawiki/php-1.38.0-wmf.5/includes/HookContainer/HookContainer.php(338): LqtDispatch::tryPage(OutputPage, Article, Title, User, WebRequest, MediaWiki)
#13 /srv/mediawiki/php-1.38.0-wmf.5/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#14 /srv/mediawiki/php-1.38.0-wmf.5/includes/HookContainer/HookRunner.php(2491): MediaWiki\HookContainer\HookContainer->run(string, array)
#15 /srv/mediawiki/php-1.38.0-wmf.5/includes/MediaWiki.php(507): MediaWiki\HookContainer\HookRunner->onMediaWikiPerformAction(OutputPage, Article, Title, User, WebRequest, MediaWiki)
#16 /srv/mediawiki/php-1.38.0-wmf.5/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
#17 /srv/mediawiki/php-1.38.0-wmf.5/includes/MediaWiki.php(925): MediaWiki->performRequest()
#18 /srv/mediawiki/php-1.38.0-wmf.5/includes/MediaWiki.php(559): MediaWiki->main()
#19 /srv/mediawiki/php-1.38.0-wmf.5/index.php(53): MediaWiki->run()
#20 /srv/mediawiki/php-1.38.0-wmf.5/index.php(46): wfIndexMain()
#21 /srv/mediawiki/w/index.php(3): require(string)
#22 {main}
Impact
Notes

Details

Request URL
https://en.wikinews.org/wiki/Comments:Israeli_Health_minister_Ya%27akov_Litzman_resigns_in_protest_after_Jews_made_to_work_on_Jewish_rest_day
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
LqtDiscussionPager: Remove deprecated usage of setPropertymediawiki/extensions/LiquidThreadswmf/1.38.0-wmf.5+6 -1
LqtDiscussionPager: Remove deprecated usage of setPropertymediawiki/extensions/LiquidThreadsmaster+6 -1
Rename use of deprecated ParserOutput::getProperty()mediawiki/extensions/LiquidThreadsmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Oct 20 2021, 1:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2021, 1:34 PM
hashar added a parent task: T287216: ParserOutput should implement ContentMetadataCollector.Oct 20 2021, 1:41 PM
hashar mentioned this in T287216: ParserOutput should implement ContentMetadataCollector.
hashar mentioned this in T281169: 1.38.0-wmf.5 deployment blockers.Oct 20 2021, 1:45 PM
gerritbot added a comment.Oct 20 2021, 1:59 PM

Change 732323 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/LiquidThreads@master] LqtDiscussionPager: Remove deprecated usage of setProperty

https://gerrit.wikimedia.org/r/732323

gerritbot added a project: Patch-For-Review.Oct 20 2021, 1:59 PM
Nikerabbit added a project: affects-translatewiki.net.Oct 20 2021, 1:59 PM
abi_ claimed this task.Oct 20 2021, 2:00 PM
Nikerabbit subscribed.Oct 20 2021, 2:09 PM

This issue was flooding our logs after today's translatewiki.net deployment. We figured it's simplest if we just fix the issue immediately and deploy the fix.

gerritbot added a comment.Oct 20 2021, 3:10 PM

Change 732357 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/LiquidThreads@master] Rename use of deprecated ParserOutput::getProperty()

https://gerrit.wikimedia.org/r/732357

gerritbot added a comment.Oct 20 2021, 3:12 PM

Change 732357 abandoned by C. Scott Ananian:

[mediawiki/extensions/LiquidThreads@master] Rename use of deprecated ParserOutput::getProperty()

Reason:

Abandon in favor of I78b15a6e12c462eb7f3c75b2549801e8324bc591

https://gerrit.wikimedia.org/r/732357

cscott subscribed.Oct 20 2021, 3:18 PM

Thanks, @Nikerabbit

gerritbot added a comment.Oct 20 2021, 3:36 PM

Change 732323 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] LqtDiscussionPager: Remove deprecated usage of setProperty

https://gerrit.wikimedia.org/r/732323

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 20 2021, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 20 2021, 4:10 PM
gerritbot added a comment.Oct 20 2021, 4:34 PM

Change 732331 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@wmf/1.38.0-wmf.5] LqtDiscussionPager: Remove deprecated usage of setProperty

https://gerrit.wikimedia.org/r/732331

Stashbot added a comment.Oct 20 2021, 4:53 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-20T16:53:03Z] <hashar@deploy1002> Synchronized php-1.38.0-wmf.5/extensions/LiquidThreads/pages/LqtDiscussionPager.php: Remove deprecated usage of setProperty - T293895 (duration: 01m 03s)

hashar closed this task as Resolved.Oct 20 2021, 4:55 PM

I have deployed the change to Wikimedia production. Looks like the issue is gone \o/

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.5; 2021-10-19); removed MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 20 2021, 5:00 PM
Krinkle moved this task from Untriaged to Oct 2021 on the Wikimedia-production-error board.Oct 25 2021, 6:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits