Page MenuHomePhabricator

PHP Deprecated: Use of ParserOutput::getProperty was deprecated in MediaWiki 1.38. [Called from LqtDiscussionPager::getPageLimit]
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of ParserOutput::getProperty was deprecated in MediaWiki 1.38. [Called from LqtDiscussionPager::getPageLimit]
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.5/extensions/LiquidThreads/pages/LqtDiscussionPager.php(30)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(375): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(351): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(230): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.38.0-wmf.5/includes/GlobalFunctions.php(1005): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/ParserOutput.php(1185): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.38.0-wmf.5/extensions/LiquidThreads/pages/LqtDiscussionPager.php(30): ParserOutput->getProperty(string)
#7 /srv/mediawiki/php-1.38.0-wmf.5/extensions/LiquidThreads/pages/LqtDiscussionPager.php(17): LqtDiscussionPager->getPageLimit()
#8 /srv/mediawiki/php-1.38.0-wmf.5/extensions/LiquidThreads/pages/TalkpageView.php(402): LqtDiscussionPager->__construct(Article, string)
#9 /srv/mediawiki/php-1.38.0-wmf.5/extensions/LiquidThreads/pages/TalkpageView.php(346): TalkpageView->getPager()
#10 /srv/mediawiki/php-1.38.0-wmf.5/extensions/LiquidThreads/classes/LqtDispatch.php(67): TalkpageView->show()
#11 /srv/mediawiki/php-1.38.0-wmf.5/extensions/LiquidThreads/classes/LqtDispatch.php(223): LqtDispatch::talkpageMain(OutputPage, Article, Title, User, WebRequest)
#12 /srv/mediawiki/php-1.38.0-wmf.5/includes/HookContainer/HookContainer.php(338): LqtDispatch::tryPage(OutputPage, Article, Title, User, WebRequest, MediaWiki)
#13 /srv/mediawiki/php-1.38.0-wmf.5/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#14 /srv/mediawiki/php-1.38.0-wmf.5/includes/HookContainer/HookRunner.php(2491): MediaWiki\HookContainer\HookContainer->run(string, array)
#15 /srv/mediawiki/php-1.38.0-wmf.5/includes/MediaWiki.php(507): MediaWiki\HookContainer\HookRunner->onMediaWikiPerformAction(OutputPage, Article, Title, User, WebRequest, MediaWiki)
#16 /srv/mediawiki/php-1.38.0-wmf.5/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
#17 /srv/mediawiki/php-1.38.0-wmf.5/includes/MediaWiki.php(925): MediaWiki->performRequest()
#18 /srv/mediawiki/php-1.38.0-wmf.5/includes/MediaWiki.php(559): MediaWiki->main()
#19 /srv/mediawiki/php-1.38.0-wmf.5/index.php(53): MediaWiki->run()
#20 /srv/mediawiki/php-1.38.0-wmf.5/index.php(46): wfIndexMain()
#21 /srv/mediawiki/w/index.php(3): require(string)
#22 {main}
Impact
Notes

Event Timeline

Change 732323 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/LiquidThreads@master] LqtDiscussionPager: Remove deprecated usage of setProperty

https://gerrit.wikimedia.org/r/732323

This issue was flooding our logs after today's translatewiki.net deployment. We figured it's simplest if we just fix the issue immediately and deploy the fix.

Change 732357 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/LiquidThreads@master] Rename use of deprecated ParserOutput::getProperty()

https://gerrit.wikimedia.org/r/732357

Change 732357 abandoned by C. Scott Ananian:

[mediawiki/extensions/LiquidThreads@master] Rename use of deprecated ParserOutput::getProperty()

Reason:

Abandon in favor of I78b15a6e12c462eb7f3c75b2549801e8324bc591

https://gerrit.wikimedia.org/r/732357

Change 732323 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] LqtDiscussionPager: Remove deprecated usage of setProperty

https://gerrit.wikimedia.org/r/732323

Change 732331 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@wmf/1.38.0-wmf.5] LqtDiscussionPager: Remove deprecated usage of setProperty

https://gerrit.wikimedia.org/r/732331

Mentioned in SAL (#wikimedia-operations) [2021-10-20T16:53:03Z] <hashar@deploy1002> Synchronized php-1.38.0-wmf.5/extensions/LiquidThreads/pages/LqtDiscussionPager.php: Remove deprecated usage of setProperty - T293895 (duration: 01m 03s)

I have deployed the change to Wikimedia production. Looks like the issue is gone \o/