Remove or fix the config option to have both mobile DiscussionTools and MobileFrontend talk page interface enabled at the same time
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Nov 16 2021, 8:18 PM

Description

We should remove or fix the config option to have both mobile DiscussionTools and MobileFrontend talk page interface enabled at the same time. ($wgDiscussionToolsEnableMobile = 'behind-overlay')

It is currently enabled on the beta cluster (e.g. https://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:Editnotice_test). This is because Editing team wanted to test mobile DiscussionTools on the beta cluster for T282638: [RELEASE TICKET] Offer Mobile Reply and New Discussion Tools at Partner Wikis, but when we made changes to enable it and disable the MobileFrontend interface, this caused failures in browser tests there and general annoyance because T293946: Enable talk for mobile users on enwiki is in progress and Reading team wanted to be able to test that on the beta cluster too.

The option to have both was thus hastily implemented in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/738012. Naturally this turns out to be buggy:

The "Add discussion" button opens both interfaces at once
The newly posted comment/topic is not highlighted after saving it
(not sure if there are any other bugs).

If we're going to use that option in production, we'll need to find and fix the bugs. @Esanders insists that we might not use it, and that we should remove it instead. (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/738226)

Details

	Subject	Repo	Branch	Lines +/-
	Revert "Split DiscussionToolsEnableMobile=true into 'behind-overlay' and 'remove-overlay'"	mediawiki/extensions/DiscussionTools	master	+4 -8
	Disable DT mobile on enwiki beta	operations/mediawiki-config	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T276497 Scale DiscussionTools to all projects
Open	None	T251207 [Epic] Scale DiscussionTools to all Wikipedias
Resolved	None	T278588 Mobile talk page improvements
Resolved	ppelberg	T282638 [RELEASE TICKET] Offer Mobile Reply and New Discussion Tools at Partner Wikis
Resolved	ppelberg	T295816 Remove or fix the config option to have both mobile DiscussionTools and MobileFrontend talk page interface enabled at the same time

Event Timeline

matmarex created this task.Nov 16 2021, 8:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2021, 8:18 PM

matmarex added a project: Editing-team (Kanban Board).Nov 16 2021, 8:19 PM

matmarex added a parent task: T282638: [RELEASE TICKET] Offer Mobile Reply and New Discussion Tools at Partner Wikis.

matmarex added a project: DiscussionTools.

matmarex mentioned this in T280051: Make mobilefrontend talk overlay disableable.Nov 16 2021, 8:30 PM

matmarex updated the task description. (Show Details)Nov 17 2021, 3:44 PM

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Nov 18 2021, 2:53 AM

We initially turned off the talk page overlay in MobileFrontend on beta, but this broken their daily selenium test (T295491), although given @Jdlrobson's comment there (T295491#7497461), it sounds like those tests aren't that important,

We could also turn off the talk page overlay on Simple English for now (https://simple.m.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page) as that would not break the tests.

ppelberg claimed this task.Nov 25 2021, 12:43 AM

ppelberg moved this task from Incoming to Blocked / Needs More Work on the Editing-team (Kanban Board) board.

ppelberg added a project: Goal.

I think given the editing team is now maintaining the talk page experience, it's ultimately your decision whether there's any value in the existing talk page tests. I have no objections to removing the tests.

I'm also wondering if it makes sense to move this code from MobileFrontend to the DiscussionTools extension so that you don't have to jump between two codebases? I'd be happy to help with anything towards helping clean up that separation.

ppelberg mentioned this in T291893: Show edit notices within the New Discussion Tool on mobile .Dec 4 2021, 12:58 AM

Change 738226 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Revert \"Split DiscussionToolsEnableMobile=true into 'behind-overlay' and 'remove-overlay'\"

https://gerrit.wikimedia.org/r/738226

gerritbot added a project: Patch-For-Review.Dec 6 2021, 5:25 PM

ppelberg mentioned this in T278590: Review outstanding mobile talk page bugs.Dec 8 2021, 1:30 AM

Update RE disabling the MobileFrontend talk page overlay
Per the conversation the Editing Team had on 8-December, and the meeting the Editing and Web Teams had on 9-December, going forward, the Editing Team will disable the MobileFrontend talk page overlayon projects as mobile DiscussionTools are introduced there.

In doing the above, the Editing Team will be explicitly assuming responsibility for any mobile talk page issues that surface within the "Read as wikipage view" that all mobile DiscussionTools features will depend on.

Also during the meeting the Editing and Web Teams had on 9-December, we decided that we will NOT disable the MobileFrontend talk page overlay on https://en.wikipedia.beta.wmflabs.org/ until T294503 is resolved.

cc @ovasileva

Change 745819 had a related patch set uploaded (by Esanders; author: Esanders):

[operations/mediawiki-config@master] Disable DT mobile on enwiki beta

https://gerrit.wikimedia.org/r/745819

Change 745819 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable DT mobile on enwiki beta

https://gerrit.wikimedia.org/r/745819

Change 738226 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Revert \"Split DiscussionToolsEnableMobile=true into 'behind-overlay' and 'remove-overlay'\"

https://gerrit.wikimedia.org/r/738226

Maintenance_bot removed a project: Patch-For-Review.Dec 10 2021, 4:10 PM