[beta] Minerva browser tests are broken on beta cluster since disabling the talk page overlay
Closed, ResolvedPublic
Actions

Description

It looks like the OOUI button needs to add the class minerva-talk-add-button for this to work.

https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-daily-beta-Minerva/1021/#showFailuresLink

Compare:
https://en.m.wikipedia.org/wiki/Talk:Sandwich
https://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:Sandwich

Developer notes

Not sure what's adding the button but it doesn't have the required class or data-event-name (see T295490)

Details

	Subject	Repo	Branch	Lines +/-
	Split DiscussionToolsEnableMobile=true into 'behind-overlay' and 'remove-overlay'	mediawiki/extensions/DiscussionTools	master	+8 -4

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T233443 [Epic] Reply Tool
Resolved	None	T278588 Mobile talk page improvements
Resolved	None	T270536 Introduce the Reply Tool on mobile
Resolved	Jdlrobson	T295491 [beta] Minerva browser tests are broken on beta cluster since disabling the talk page overlay

Event Timeline

Jdlrobson created this task.Nov 10 2021, 4:51 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptNov 10 2021, 4:51 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald Transcript

Jdlrobson renamed this task from Minerva browser tests are broken on beta cluster since disabling the talk page overlay to [beta] Minerva browser tests are broken on beta cluster since disabling the talk page overlay.Nov 10 2021, 4:51 PM

Jdlrobson triaged this task as High priority.

Jdlrobson updated the task description. (Show Details)

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.

We disabled the talk overlay on beta deliberately in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/736918 so we can start testing DiscussionTools mobile.

Change 738012 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Split DiscussionToolsEnableMobile=true into 'behind-overlay' and 'remove-overlay'

https://gerrit.wikimedia.org/r/738012

gerritbot added a project: Patch-For-Review.Nov 10 2021, 9:29 PM

Change 738012 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Split DiscussionToolsEnableMobile=true into 'behind-overlay' and 'remove-overlay'

https://gerrit.wikimedia.org/r/738012

Sorry, we weren't aware of the browser tests. Does that patch fix the issue for now?

In T295491#7497437, @matmarex wrote:

Does that patch fix the issue for now?

it does! thanks - https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-daily-beta-Minerva/1023/

yes thank you!
When you want to turn this on again, let me know and I'll make sure the test is disabled on the beta cluster prior to doing so.

• Esanders mentioned this in T295816: Remove or fix the config option to have both mobile DiscussionTools and MobileFrontend talk page interface enabled at the same time.Nov 19 2021, 3:35 PM

• Esanders mentioned this in T317467: Enable DiscussionTools mobile on beta en.wiki, disable MobileFrontend talk page selenium test.Sep 10 2022, 12:06 PM

[beta] Minerva browser tests are broken on beta cluster since disabling the talk page overlayClosed, ResolvedPublicActions