Page MenuHomePhabricator
Create Task
Maniphest T317467

Enable DiscussionTools mobile on beta en.wiki, disable MobileFrontend talk page selenium test
Closed, ResolvedPublic
Actions

Description

Last time we tried to do this we caused a daily selenium test in MobileFrontend to fail (T295491).

The web team indicated they would be happy to disable the test:

In T295491#7497461, @Jdlrobson wrote:

When you want to turn this on again, let me know and I'll make sure the test is disabled on the beta cluster prior to doing so.

Details

SubjectRepoBranchLines +/-
Enable DiscussionTools mobile on enwiki betaoperations/mediawiki-configmaster+0 -1
Remove Minerva talk pages Selenium testsmediawiki/skins/MinervaNeuemaster+0 -164
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Sep 10 2022, 12:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2022, 12:06 PM
ppelberg added a project: Editing-team.Sep 22 2022, 3:32 PM
ppelberg added a parent task: T298060: [RELEASE TICKET] Offer Mobile DiscussionTools at All Wikis.
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.
gerritbot added a comment.Sep 29 2022, 10:16 PM

Change 836944 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] Remove Minerva talk pages Selenium tests

https://gerrit.wikimedia.org/r/836944

gerritbot added a project: Patch-For-Review.Sep 29 2022, 10:16 PM
matmarex claimed this task.Sep 29 2022, 10:16 PM
gerritbot added a comment.Sep 30 2022, 12:48 PM

Change 837105 had a related patch set uploaded (by Esanders; author: Esanders):

[operations/mediawiki-config@master] Enable DiscussionTools mobile on enwiki beta

https://gerrit.wikimedia.org/r/837105

gerritbot added a comment.Sep 30 2022, 7:46 PM

Change 836944 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove Minerva talk pages Selenium tests

https://gerrit.wikimedia.org/r/836944

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.4; 2022-10-03).Sep 30 2022, 8:00 PM
matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.Oct 2 2022, 1:27 PM
matmarex moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.
Esanders moved this task from Doing to Ready to Be Worked On on the Editing-team (Kanban Board) board.Oct 16 2022, 11:32 AM

This should be ready to deploy now.

gerritbot added a comment.Oct 17 2022, 8:02 PM

Change 837105 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable DiscussionTools mobile on enwiki beta

https://gerrit.wikimedia.org/r/837105

matmarex moved this task from Ready to Be Worked On to QA on the Editing-team (Kanban Board) board.Oct 17 2022, 8:16 PM
matmarex added a project: Editing QA.
Maintenance_bot removed a project: Patch-For-Review.Oct 17 2022, 8:30 PM
EAkinloose subscribed.EditedNov 25 2022, 12:59 AM

@Esanders ,

Kindly check https://photos.app.goo.gl/CUQpULgCMrcUmLuU9(Android) and https://photos.app.goo.gl/9kos7kjvG6B8mVWdA(iOS) out, something funky is up.

context: Testing for Discussion tools on https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:TestUserEsther

For clarity, the funky behaviour isn't an enwiki beta thing, it's a DT thing from observation.

Cc: @matmarex

EAkinloose moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Nov 25 2022, 1:00 AM
matmarex mentioned this in T323833: "Add topic" button gets duplicated when previewing and saving in mobile DiscussionTools.Nov 25 2022, 3:58 PM
matmarex added a comment.Nov 25 2022, 4:01 PM

Thanks, that's pretty funky :) I filed T323833: "Add topic" button gets duplicated when previewing and saving in mobile DiscussionTools, and we already have T323400: The sticky "Add topic" button behaves inconsistently when scrolled to the top of a talk page on iOS. I think this covers all of the problems I see in the recordings.

(For anyone getting an error when clicking the links, try these fixed versions: https://photos.app.goo.gl/CUQpULgCMrcUmLuU9 (Android) and https://photos.app.goo.gl/9kos7kjvG6B8mVWdA (iOS))

EAkinloose edited projects, added Verified; removed Editing QA.Nov 26 2022, 1:13 AM
In T317467#8421909, @matmarex wrote:

Thanks, that's pretty funky :) I filed T323833: "Add topic" button gets duplicated when previewing and saving in mobile DiscussionTools, and we already have T323400: The sticky "Add topic" button behaves inconsistently when scrolled to the top of a talk page on iOS. I think this covers all of the problems I see in the recordings.

(For anyone getting an error when clicking the links, try these fixed versions: https://photos.app.goo.gl/CUQpULgCMrcUmLuU9 (Android) and https://photos.app.goo.gl/9kos7kjvG6B8mVWdA (iOS))

Thanks Bartosz!

I'll go ahead to verify this.

EAkinloose moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.Nov 26 2022, 1:14 AM
ppelberg closed this task as Resolved.Dec 2 2022, 12:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits