Page MenuHomePhabricator
Create Task
Maniphest T319145

Remove MobileFrontend/Minerva code for talk page tools
Closed, ResolvedPublic
Actions

Description

  • After mobile DiscussionTools are enabled for everyone on all wikis (T298060), we should remove the MobileFrontend/Minerva code that implemented the previous mobile talk page tools.
  • We should also remove little bits of related code were added in DiscussionTools code to avoid conflicts with that feature.
  • After that is done, we should also review outstanding bug reports about them again (like T278590), and close them or re-tag with DiscussionTools as appropriate.

Details

SubjectRepoBranchLines +/-
Remove integration with removed MobileFrontend talk page toolsmediawiki/extensions/DiscussionToolsmaster+9 -61
Remove talk page toolsmediawiki/extensions/MobileFrontendmaster+1 -1 K
Remove talk page toolsmediawiki/skins/MinervaNeuemaster+11 -504
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedmatmarexT319145 Remove MobileFrontend/Minerva code for talk page tools
 ResolvedJdlrobsonT312312 Deprecate MobileFrontend's "About this page" functionality on talk pages
 ResolvedNoneT298060 [RELEASE TICKET] Offer Mobile DiscussionTools at All Wikis
 ResolvedppelbergT298062 [A/B Test] Run an A/B test to evaluate impact of mobile DiscussionTools
 DeclinedNoneT298065 [Impact Analysis] Evaluate Impact of mobile Topic Subscriptions + Usability Improvements
 Resolved• Whatamidoing-WMFT314950 Identify wikis for mobile DiscussionTools A/B test
 ResolvedppelbergT302108 Ensure logging is in place to compare MobileFrontend and DiscussionTools new topic and new comment completion rates
 ResolvedMNeislerT301026 Create instrumentation spec for mobile DiscussionTools
 DuplicateMNeislerT303653 [SPIKE] Investigate how sessionID is used in various *mobile* talk page schemas
 ResolvedDLynchT303654 [SPIKE] Investigate practicality of making sampling rate consistent across mobile talk page schemas
 ResolvedppelbergT307640 Add page view token to UIAction schemas
 ResolvedppelbergT311612 Reduce weight and/or size of headings on talk pages
 ResolvedmatmarexT318110 Overflow menu does not appear within sections that do not contain signed comments
 ResolvedDLynchT318302 [Config Change] Enable all DiscussionTools by default at partner wikis (mobile)
 ResolvedDLynchT318871 Implement config that enables us to exclude ja.wiki from receiving mobile visual enhancements/usability improvemets
 ResolvedmatmarexT318870 [Config Change] Enable all DiscussionTools by default at ja.wiki (mobile)
 ResolvedmatmarexT319148 Reply Tool (mobile) remains visible when section is collapsed
 ResolvedmatmarexT320755 "Start a discussion" and "Read as wiki page" buttons have incorrect margins
 ResolvedDLynchT320993 Implement mobile DiscussionTools A/B test bucketing
 ResolvedppelbergT321961 [Config Change] Start mobile DiscussionTools A/B test
 ResolvedRyasmeenT323400 The sticky "Add topic" button behaves inconsistently when scrolled to the top of a talk page on iOS
 ResolvedRyasmeenT320997 Verify suite of mobile DiscussionTools are working as expected prior to A/B test start
 ResolvedmatmarexT316175 Make the mobile Add Topic button easier for people to access
ResolvedppelbergT321734 Extend the MobileWebUIActions sampling rate to A/B test wiki
 ResolvedmatmarexT323171 "Learn more about this page" button doesn't appear as expected in mobile DiscussionTools
 ResolvedppelbergT312309 Unify experience for making lead section content available on mobile talk pages
 ResolvedmatmarexT324686 [Regression ?] The section edit icon on MobileFrontend stops working after posting a reply on production
 ResolvedmatmarexT324702 Deemphasize treatment of "Learn more about this page" Link
 ResolvedppelbergT298066 Disable MobileFrontend talk page overlay
 ResolvedDLynchT328942 [Config Change] Enable all DiscussionTools as default-on features at Phase 2 wikis (mobile)
 ResolvedmatmarexT317467 Enable DiscussionTools mobile on beta en.wiki, disable MobileFrontend talk page selenium test
 ResolvedmatmarexT324690 [Regression ?] The notification counter on mobile does not get updated after receiving a notification from a comment on a subscribed section
 ResolvedmatmarexT328940 [Config Change] Enable all DiscussionTools as default-on features at Phase 1 wikis (mobile)
 ResolvedNoneT309462 Make reply buttons more easily clickable
 ResolvedNoneT309464 Make content editing less obvious on Talk Pages

Event Timeline

matmarex created this task.Oct 2 2022, 12:40 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptOct 2 2022, 12:40 PM
gerritbot added a comment.Oct 2 2022, 1:26 PM

Change 837223 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] [WIP] Remove talk page tools

https://gerrit.wikimedia.org/r/837223

gerritbot added a project: Patch-For-Review.Oct 2 2022, 1:26 PM

Change 837224 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] [WIP] Remove talk page tools

https://gerrit.wikimedia.org/r/837224

Izno subscribed.Oct 3 2022, 7:49 AM

Related to T312312: Deprecate MobileFrontend's "About this page" functionality on talk pages and T257394: Tmbox template not displayed on WMF wikis on mobile (MinervaNeue skin)?

matmarex updated the task description. (Show Details)Nov 10 2022, 10:45 PM
In T319145#8278701, @Izno wrote:

Related to T312312: Deprecate MobileFrontend's "About this page" functionality on talk pages

Yes

… and T257394: Tmbox template not displayed on WMF wikis on mobile (MinervaNeue skin)?

Not reallllyyy…

matmarex added a subtask: T312312: Deprecate MobileFrontend's "About this page" functionality on talk pages.Nov 10 2022, 10:47 PM
matmarex added a project: Technical-Debt.
HouseBlaster moved this task from Unsorted to Needs removal on the Technical-Debt board.Dec 3 2022, 7:50 PM
matmarex mentioned this in T302993: Minerva Selenium tests blocking merges in DiscussionTools.Dec 7 2022, 8:09 PM
ppelberg mentioned this in T298066: Disable MobileFrontend talk page overlay.Mar 13 2023, 5:18 PM
DLynch subscribed.Mar 13 2023, 5:18 PM
matmarex claimed this task.Mar 13 2023, 6:22 PM
matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
matmarex closed subtask T312312: Deprecate MobileFrontend's "About this page" functionality on talk pages as Resolved.Mar 13 2023, 6:35 PM
matmarex mentioned this in T312312: Deprecate MobileFrontend's "About this page" functionality on talk pages.
Jdlrobson reopened subtask T312312: Deprecate MobileFrontend's "About this page" functionality on talk pages as Open.Mar 13 2023, 6:47 PM
Jdlrobson closed subtask T312312: Deprecate MobileFrontend's "About this page" functionality on talk pages as Resolved.
gerritbot added a comment.Mar 21 2023, 7:03 PM

Change 837224 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove talk page tools

https://gerrit.wikimedia.org/r/837224

gerritbot added a comment.Mar 21 2023, 7:03 PM

Change 837223 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Remove talk page tools

https://gerrit.wikimedia.org/r/837223

Maintenance_bot removed a project: Patch-For-Review.Mar 21 2023, 7:10 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 21 2023, 8:00 PM
matmarex updated the task description. (Show Details)Mar 21 2023, 10:26 PM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.
matmarex added a project: Skipped QA.
matmarex updated the task description. (Show Details)Apr 3 2023, 7:39 PM
matmarex moved this task from Ready for Sign Off to Code Review on the Editing-team (Kanban Board) board.
matmarex removed a project: Skipped QA.
gerritbot added a comment.Apr 3 2023, 7:41 PM

Change 905299 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Remove integration with removed MobileFrontend talk page tools

https://gerrit.wikimedia.org/r/905299

gerritbot added a project: Patch-For-Review.Apr 3 2023, 7:41 PM
gerritbot added a comment.Apr 4 2023, 4:19 PM

Change 905299 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Remove integration with removed MobileFrontend talk page tools

https://gerrit.wikimedia.org/r/905299

Maintenance_bot removed a project: Patch-For-Review.Apr 4 2023, 4:30 PM
DLynch closed this task as Resolved.Apr 4 2023, 4:56 PM
DLynch added a project: Skipped QA.
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.4; 2023-04-10); removed MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Apr 4 2023, 5:00 PM
matmarex updated the task description. (Show Details)Apr 4 2023, 5:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL