Page MenuHomePhabricator
Create Task
Maniphest T311612

Reduce weight and/or size of headings on talk pages
Closed, ResolvedPublic
Actions

Assigned To
ppelberg
Authored By
Esanders
Jun 29 2022, 11:18 AM
Tags
Referenced Files
F35489997: image.png
Aug 25 2022, 5:25 PM
F35489999: image.png
Aug 25 2022, 5:25 PM
F35489995: image.png
Aug 25 2022, 5:25 PM
F35489993: image.png
Aug 25 2022, 5:25 PM
F35286401: image.png
Jun 29 2022, 11:18 AM
F35286399: image.png
Jun 29 2022, 11:18 AM
F35286390: image.png
Jun 29 2022, 11:18 AM
F35286394: image.png
Jun 29 2022, 11:18 AM
View All 18 Files
Subscribers
Aklapper
• alexhollender_WMF
EAkinloose
Esanders
matmarex
nayoub
ppelberg
Tokens
"Love" token, awarded by alexhollender_WMF.

Description

DiscussionTools changes h2's from serif-24px, to sansserif-bold-24px.

The change of font is probably enough to distinguish talk pages from article pages, which was the motivation behind this change.

As talk page headers (topic subjects) are typically longer than article headers, it may be helpful to reduce the font-weight and/or size to fit more text in, especially on mobile:

Original (24px bold)24px + normal20px + bold20px + normal
Mobile
image.png (681×393 px, 80 KB)
image.png (683×391 px, 79 KB)
image.png (679×389 px, 79 KB)
image.png (678×385 px, 75 KB)
Expanded
image.png (683×392 px, 101 KB)
image.png (684×386 px, 101 KB)
image.png (680×389 px, 103 KB)
image.png (683×387 px, 102 KB)
Desktop
image.png (920×975 px, 275 KB)
image.png (921×969 px, 273 KB)
image.png (912×975 px, 273 KB)
image.png (909×968 px, 271 KB)

Note that the existing MobileFrontend talk page experience uses and even smaller font size (16px, same as body text) for the heading also with no bold, although the heading is never shown next to text (it becomes a dialog header)

image.png (685×391 px, 44 KB)
image.png (681×390 px, 78 KB)

Details

SubjectRepoBranchLines +/-
Reduce size of topic headings to 18px on mobilemediawiki/extensions/DiscussionToolsmaster+14 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Jun 29 2022, 11:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2022, 11:18 AM
Esanders added a project: Editing-team (Kanban Board).Jul 8 2022, 10:15 PM
Esanders moved this task from Incoming to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
ppelberg added a project: Design.Jul 18 2022, 5:13 PM
ppelberg edited projects, added Editing-team; removed Editing-team (Kanban Board).
ppelberg moved this task from Untriaged to Needs Discussion / Investigation on the Editing-team board.Jul 18 2022, 5:16 PM
ppelberg added a subscriber: nayoub.
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Jul 28 2022, 3:27 PM
ppelberg added a parent task: T302547: [Usability Improvements] Deploy as Beta Feature at all wikis (desktop).
gerritbot added a comment.Aug 18 2022, 2:53 PM

Change 824515 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Reduce size of topic headings to 18px on mobile

https://gerrit.wikimedia.org/r/824515

gerritbot added a project: Patch-For-Review.Aug 18 2022, 2:53 PM
Esanders added a comment.Aug 18 2022, 2:54 PM

The above patch implements an 18px normal-weight heading, as suggested by @nayoub yesterday.

PatchDemoBot added a comment.Aug 18 2022, 2:56 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/a53bf33300/wiki/Talk:DiscussionTools

• alexhollender_WMF awarded a token.Aug 18 2022, 2:57 PM
Esanders added a comment.Aug 18 2022, 3:01 PM

Thanks to @alexhollender_WMF who initially suggested the de-bolding.

matmarex subscribed.Aug 19 2022, 1:09 AM

It seemed weird at first but I got used to it. However, there is too much white space around the headings with the smaller font size. We should probably reduce or remove some margins, especially on the "Latest comment" line.

ppelberg assigned this task to nayoub.Aug 19 2022, 11:28 PM
ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.
ppelberg subscribed.
In T311612#8165718, @Esanders wrote:

The above patch implements an 18px normal-weight heading, as suggested by @nayoub yesterday.

Lowering the font size sounds good to me. Although, a question in response to the above:

I do not recall us converging on returning the headings to "normal-weight."

@nayoub you might very well have suggested we do the above and I might've missed it.

So, can you please clarify: do you advise that we both 1) reduce the size of mobile talk page headings to 18px and 2) present them using a "normal-weight"? I default to what you think is best here, I just want to make sure I'm clear about that is.

ppelberg moved this task from Blocked / Needs More Work to Design Review on the Editing-team (Kanban Board) board.Aug 19 2022, 11:28 PM
ppelberg mentioned this in T315710: Revisit mobile Topic Container spacing.Aug 19 2022, 11:43 PM
ppelberg added a comment.Aug 19 2022, 11:47 PM
In T311612#8167847, @matmarex wrote:

However, there is too much white space around the headings with the smaller font size. We should probably reduce or remove some margins, especially on the "Latest comment" line.

Good spot and agreed. Here's a ticket for us to iterate on the mobile topic container spacing: T315710.

Esanders added a comment.Aug 25 2022, 5:25 PM
NormalBold
image.png (693×411 px, 63 KB)
image.png (687×407 px, 65 KB)
image.png (689×399 px, 83 KB)
image.png (688×395 px, 83 KB)
nayoub added a comment.EditedAug 26 2022, 5:05 PM

To be consistent with the visual design of Talk pages on the apps, it's best to go with bold text for the headers on mobile.

nayoub removed nayoub as the assignee of this task.Aug 26 2022, 5:06 PM
ppelberg moved this task from Design Review to Ready to Be Worked On on the Editing-team (Kanban Board) board.Aug 26 2022, 5:23 PM
PatchDemoBot added a comment.Aug 26 2022, 8:11 PM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/a53bf33300/w/

PatchDemoBot added a comment.Aug 26 2022, 8:13 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/657c5ad0fd/wiki/Talk:DiscussionTools

ppelberg assigned this task to nayoub.Aug 29 2022, 5:30 PM
ppelberg moved this task from Ready to Be Worked On to Design Review on the Editing-team (Kanban Board) board.
nayoub moved this task from Design Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 8 2022, 4:00 AM

Looks great, thanks @Esanders! Moving to sign off.
cc @ppelberg

nayoub reassigned this task from nayoub to ppelberg.Sep 9 2022, 4:44 AM
ppelberg moved this task from Ready for Sign Off to QA on the Editing-team (Kanban Board) board.Sep 10 2022, 12:20 AM
ppelberg added a project: Editing QA.
ppelberg edited parent tasks, added: T298062: [A/B Test] Run an A/B test to evaluate impact of mobile DiscussionTools; removed: T302547: [Usability Improvements] Deploy as Beta Feature at all wikis (desktop).
ppelberg moved this task from Inbox to High Priority on the Editing QA board.
gerritbot added a comment.Sep 10 2022, 11:53 AM

Change 824515 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Reduce size of topic headings to 18px on mobile

https://gerrit.wikimedia.org/r/824515

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 10 2022, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 10 2022, 12:30 PM
EAkinloose edited projects, added Verified; removed Editing QA.Sep 13 2022, 4:05 PM
EAkinloose subscribed.
In T311612#8186332, @Esanders wrote:
NormalBold
image.png (693×411 px, 63 KB)
image.png (687×407 px, 65 KB)
image.png (689×399 px, 83 KB)
image.png (688×395 px, 83 KB)

✅ Reduce weight and/or size of headings on talk pages

Looks like the attached Bold screenshots

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 13 2022, 4:06 PM
ppelberg mentioned this in T318302: [Config Change] Enable all DiscussionTools by default at partner wikis (mobile).Sep 22 2022, 1:15 AM
ppelberg closed this task as Resolved.Sep 22 2022, 4:44 PM
ppelberg mentioned this in T318870: [Config Change] Enable all DiscussionTools by default at ja.wiki (mobile).Sep 28 2022, 9:05 PM
PatchDemoBot added a comment.Oct 18 2022, 1:56 PM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/657c5ad0fd/w/

ppelberg mentioned this in T321618: DiscussionTools mobile: Always collapse sections by default, even on a wide screen.Nov 11 2022, 5:15 AM
ppelberg mentioned this in T328940: [Config Change] Enable all DiscussionTools as default-on features at Phase 1 wikis (mobile).Feb 10 2023, 10:34 PM
ppelberg mentioned this in T328942: [Config Change] Enable all DiscussionTools as default-on features at Phase 2 wikis (mobile).Feb 13 2023, 7:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits