Overflow menu does not appear within sections that do not contain signed comments
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	Sep 19 2022, 6:32 PM

Description

This task deals with the issue of the overflow menu (read: •••) from appearing alongside talk page sections that do not contain signed comments.

Behavior

Step	Description	Actual	Expected
1.	Using MinervaNeue, visit a talk page where Topic Containers are available. E.g. https://fr.m.wikipedia.org/wiki/Citron .
2.	Look up and down the page	❗️Notice the section titled `contradiction...` and `Huile de citron` lack ••• affordances: Note: the two sections above lack any signed comments.	✅ Notice every section on the page is accompanied by a ••• affordance

Details

	Subject	Repo	Branch	Lines +/-
	CommentFormatter: Always add the overflow menu	mediawiki/extensions/DiscussionTools	master	+55 -54

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		matmarex	T319145 Remove MobileFrontend/Minerva code for talk page tools
Resolved		Jdlrobson	T312312 Deprecate MobileFrontend's "About this page" functionality on talk pages
Resolved		None	T278588 Mobile talk page improvements
Resolved	BUG REPORT	matmarex	T326080 User talk page seems to be empty in mobile
Resolved		matmarex	T327047 English Wikipedia WikiProject banners no longer visible on mobile
Resolved		None	T298060 [RELEASE TICKET] Offer Mobile DiscussionTools at All Wikis
Resolved		ppelberg	T298062 [A/B Test] Run an A/B test to evaluate impact of mobile DiscussionTools
Resolved		matmarex	T318110 Overflow menu does not appear within sections that do not contain signed comments

Event Timeline

ppelberg created this task.Sep 19 2022, 6:32 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptSep 19 2022, 6:32 PM

ppelberg added a parent task: T298062: [A/B Test] Run an A/B test to evaluate impact of mobile DiscussionTools.Sep 19 2022, 6:33 PM

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.

ppelberg moved this task from Untriaged to Needs Discussion / Investigation on the Editing-team board.

Esanders renamed this task from Overflow menu does not appear within sections that do not contain sign comments to Overflow menu does not appear within sections that do not contain signed comments.Sep 19 2022, 8:56 PM

Change 837226 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Always add the overflow menu

https://gerrit.wikimedia.org/r/837226

gerritbot added a project: Patch-For-Review.Oct 2 2022, 1:47 PM

matmarex claimed this task.Oct 2 2022, 1:47 PM

matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

ppelberg added a project: Goal.Oct 17 2022, 6:33 PM

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Oct 18 2022, 4:07 PM

DLynch added a project: Editing QA.

Change 837226 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Always add the overflow menu

https://gerrit.wikimedia.org/r/837226

Maintenance_bot removed a project: Patch-For-Review.Oct 18 2022, 4:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 18 2022, 5:00 PM

✅ Overflow menu appear within sections that do not contain signed comments

Screenshot 2022-10-20 at 06.26.59.png (826×550 px, 72 KB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 20 2022, 5:28 AM

ppelberg closed this task as Resolved.Oct 20 2022, 5:09 PM

	F35602320: Screenshot 2022-10-20 at 06.26.59.png
	Oct 20 2022, 5:28 AM

Overflow menu does not appear within sections that do not contain signed commentsClosed, ResolvedPublicActions