Page MenuHomePhabricator

Deprecate and remove ParserOutput::isLinkInternal() (or at least mark it as @internal)
Closed, ResolvedPublic

Description

I'm not sure exactly where this function 'belongs', but it's a simple static function which does a regexp match with no special relationship to MediaWiki; I'm pretty sure it doesn't belong in ParserOutput.

Related Objects

StatusSubtypeAssignedTask
OpenReleaseNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenDLynch
OpenFeatureNone
OpenNone
OpenNone
Resolvedssastry
Resolvedssastry
Resolvedcscott
Resolvedcscott
Resolvedcscott
ResolvedNone
Resolvedssastry
Resolvedcscott
Resolvedcscott
Resolvedcscott
Resolvedcscott
ResolvedPRODUCTION ERRORLucas_Werkmeister_WMDE
ResolvedPRODUCTION ERRORabi_
ResolvedPRODUCTION ERRORcscott
ResolvedPRODUCTION ERRORroman-stolar
ResolvedNone
ResolvedNone
Resolved• matmarex
Resolved• matmarex
Resolvedcscott
Resolvedcscott
Resolvedcscott
Resolvedihurbain
ResolvedNone
Resolvedcscott
ResolvedNone
Resolvedssastry
Declinedssastry
ResolvedPRODUCTION ERRORssastry
Resolvedcscott
Resolvedssastry
ResolvedMSantos
Resolvedihurbain
OpenNone
Resolvedcscott
DeclinedNone
DeclinedNone
DeclinedNone
DeclinedNone
Resolvedppelberg
ResolvedBUG REPORTNone
ResolvedPRODUCTION ERRORJdlrobson-WMF
ResolvedEsanders
OpenNone
OpenBUG REPORTNone
OpenNone
DeclinedNone
StalledNone
OpenBUG REPORTNone
OpenNone
OpenNone
Openihurbain
OpenNone
Resolvedcscott
Resolvedcscott
OpenNone
Resolved• matmarex
Resolvedcscott
OpenNone
Resolvedcscott
ResolvedABreault-WMF
Resolvedcscott
Opencscott
Resolvedssastry
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedJgiannelos
OpenNone

Event Timeline

cscott renamed this task from Deprecate and remove ParserOutput::isLinkInternal() to Deprecate and remove ParserOutput::isLinkInternal() (or at least mark it as @internal).

It's been marked @internal now, but I believe it is used by one external extension still. Could be hard-deprecated/renamed and then made private.

ssastry assigned this task to cscott.

This function has been marked internal. Closing.