[S] Investigate and update jQuery.lazyload library from UploadWizard from using deprecated navigator.appVersion
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	SimoneThisDot
	Dec 1 2021, 1:16 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

matthiasmullie

SimoneThisDot

Description

Due to future changes highlighted in the parent task, we have to update our code to make sure that deprecated methods will no longer be used.

As highlighted by this search filter: code filter, the jQuery.lazyload library from UploadWizard uses navigator.appVersion that will be removed in future version of chrome.

The impact of this deprecation to the client is unknown and investigation is required as part of this ticket

Acceptance criteria

Investigate the impact of the deprecated navigator.appVersion in the uploadWIzard code
Search for an updated version of the library in which the deprecated code is removed
If necessary, follow the required step to update the library in the source code

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Check for appversion to handle deprecation	Seddon	mediawiki/extensions/UploadWizard	master	+11 -8

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• DAbad	T295073 <Org-Wide Impact> Google Chrome User-Agent Deprecation Impact
Resolved	kostajh	T242825 Deal with Google Chrome User-Agent deprecation
Resolved	Seddon	T296840 [S] Investigate and update jQuery.lazyload library from UploadWizard from using deprecated navigator.appVersion

Event Timeline

SimoneThisDot created this task.Dec 1 2021, 1:16 PM

• Kormat unsubscribed.Dec 1 2021, 1:17 PM

Isaac unsubscribed.Dec 1 2021, 1:31 PM

nshahquinn-wmf unsubscribed.Dec 1 2021, 3:39 PM

JJMC89 removed projects: Web-Team-Backlog-Archived, Analytics-Radar, Product-Analytics, Anti-Harassment-Team, Privacy Engineering, User-revi, CheckUser.Dec 1 2021, 4:02 PM

JJMC89 removed subscribers: revi, Bradv, L235 and 52 others.

CBogen added a project: Structured-Data-Backlog.Dec 2 2021, 2:36 PM

SimoneThisDot updated the task description. (Show Details)Dec 2 2021, 2:43 PM

CBogen edited projects, added: Structured-Data-Backlog (Current Work); removed: Structured-Data-Backlog.Dec 13 2021, 5:39 PM

CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.

There is no navigator.userAgent in UW - do you mean navigator.appVersion? (https://gerrit.wikimedia.org/g/mediawiki/extensions/UploadWizard/+/17ac2997b8af96d5026fe235bfe0b8f22615a5a0/resources/jquery/jquery.lazyload.js#151)

Yes apologies, it was the app version! I created a ticket from a template as I had to create 7 and forgot to change it here!

SimoneThisDot renamed this task from Investigate and update jQuery.lazyload library from UploadWizard from using deprecated navigator.userAgent to Investigate and update jQuery.lazyload library from UploadWizard from using deprecated navigator.appVersion.Dec 17 2021, 8:46 AM

SimoneThisDot updated the task description. (Show Details)

CBogen renamed this task from Investigate and update jQuery.lazyload library from UploadWizard from using deprecated navigator.appVersion to [S] Investigate and update jQuery.lazyload library from UploadWizard from using deprecated navigator.appVersion.Feb 9 2022, 5:28 PM

CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Feb 9 2022, 6:13 PM

Seddon claimed this task.Feb 18 2022, 11:40 AM

Seddon moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.

Seddon changed the task status from Open to In Progress.Feb 18 2022, 1:07 PM

Change 764362 had a related patch set uploaded (by Seddon; author: Seddon):

[mediawiki/extensions/UploadWizard@master] Check for appversion to handle deprecation

https://gerrit.wikimedia.org/r/764362

gerritbot added a project: Patch-For-Review.Feb 21 2022, 1:42 PM

Seddon moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Feb 21 2022, 1:59 PM

Change 764362 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Check for appversion to handle deprecation

https://gerrit.wikimedia.org/r/764362