| dancy | |
| Dec 9 2021, 3:51 PM |
| F34877079: Screen Shot 2021-12-10 at 09.27.58.png | |
| Dec 10 2021, 2:29 PM |
'.search_result_page_id' should be integer
This was originally reported by @elukey on T293953:
Hi everybody,
there is an alert for Eventgate Analytics External event validation errors for the schema mediawiki.mediasearch_interaction, that lines up with the deployment timings:
https://sal.toolforge.org/log/xYr_m30B8Fs0LHO53sGB
Grafana dashboard
Logstash shows the same error over and over: '.search_result_page_id' should be integer
I'm not sure if this should be a train blocker, this is an analytics instrumentation event.
I am not totally sure of the owners of this stream, but @egardner designed the initial schema, so hopefully he can find the culprit. I bet some instrumentation code bug was introduced.
I'm on call for our team, happy to help. This looks like an instrumentation problem, but I'm here in case the obvious fix doesn't work. (ping me on IRC or slack)
I think this looks like the commit that introduced the problem:
I'll ping @Seddon here and in chat.
I wrote the original analytics code here but am no longer working on the team that maintains MediaSearch. Previously the page ID was used as an identifier whenever the "quickview" element of the UI was activated, and the instrumentation logged the ID to help provide a sense of where & how users were using this feature.
Now the code has been changed and the page title is used instead, so there is no ID to log. This is just a case of the schema getting out of sync with the current UI changes.
It sounds like @Seddon is working on a patch to disable the logging of this event for now (to go out in a backport). But long-term the MediaSearch Interaction schema will need to be updated to reflect how this feature currently works.
wmf.12 is currently already out to test and commons and MediaSearch isn't deployed on any group 2 wiki's so not a train blocker.
Change 745578 had a related patch set uploaded (by Seddon; author: Seddon):
[mediawiki/extensions/MediaSearch@master] Search_result_page_id should be integer
Change 745578 merged by jenkins-bot:
[mediawiki/extensions/MediaSearch@master] Search_result_page_id should be integer
Change 745646 had a related patch set uploaded (by Clare Ming; author: Seddon):
[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.12] Search_result_page_id should be integer
Change 745646 merged by jenkins-bot:
[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.12] Search_result_page_id should be integer
Mentioned in SAL (#wikimedia-operations) [2021-12-10T00:34:35Z] <cjming@deploy1002> Synchronized php-1.38.0-wmf.12/extensions/MediaSearch/resources/components/QuickView.vue: Backport: [[gerrit:745646|Search_result_page_id should be integer (T297400)]] (duration: 00m 55s)
Change 745639 had a related patch set uploaded (by Seddon; author: Seddon):
[mediawiki/extensions/MediaSearch@master] search_result_page_id should be integer
wmf.12 is currently already out to test and commons and MediaSearch isn't deployed on any group 2 wiki's so not a train blocker.
@Seddon you sure? Since yesterday the validation error rate jumped a ton and is causing more alerts
wmf.12 is currently already out to test and commons and MediaSearch isn't deployed on any group 2 wiki's so not a train blocker.
@Seddon you sure? Since yesterday the validation error rate jumped a ton and is causing more alerts
@Ottomata The second big jump occurred on Wednesday according to that but this was only brought to our attention Thursday so nothing should get worse. The first patch submitted missed something. The second patch if I can't get deployed today will get deployed Monday first thing.
Change 745966 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):
[schemas/event/secondary@master] Mediasearch_Interaction: Add search_result_page_title field
Change 745639 merged by jenkins-bot:
[mediawiki/extensions/MediaSearch@master] Disable event logging for Quickview interactions
Change 746810 had a related patch set uploaded (by Urbanecm; author: Seddon):
[mediawiki/extensions/MediaSearch@wmf/1.37.0-wmf.12] Disable event logging for Quickview interactions
Change 746810 abandoned by Urbanecm:
[mediawiki/extensions/MediaSearch@wmf/1.37.0-wmf.12] Disable event logging for Quickview interactions
Reason:
Change 746811 had a related patch set uploaded (by Urbanecm; author: Seddon):
[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.12] Disable event logging for Quickview interactions
Change 746811 merged by jenkins-bot:
[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.12] Disable event logging for Quickview interactions
Mentioned in SAL (#wikimedia-operations) [2021-12-13T12:25:28Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.12/extensions/MediaSearch/resources/components/SearchResults.vue: 7d0fa97dcfe4f3c0b5a5f98e722f54930c18bad0: Disable event logging for Quickview interactions (T297400) (duration: 00m 56s)
Update from @Seddon:
We disabled the logging error back in mid-December before I went on leave. Eric has submitted a patch for a schema update which needs code reviewing. Unfortunately we don't though have event logging as standard as part of our dev environment it seems and getting it fully working locally has proven troublesome. Matthias is helping with that and I've also pinged Eric to try and get to the bottom of the issue. Once that is resolved I can complete the CR and push out the schema change. After the schema change is done we can reenable the event that we suppressed.
Change 745966 merged by jenkins-bot:
[schemas/event/secondary@master] Mediasearch_Interaction: Add search_result_page_title field
Schema update has been merged. Will write a patch to update the logging in MediaSearch.
Change 754611 had a related patch set uploaded (by Seddon; author: Seddon):
[mediawiki/extensions/MediaSearch@master] Update logging. New schema. Page id to title
Change 754611 merged by jenkins-bot:
[mediawiki/extensions/MediaSearch@master] Update logging. New schema. Page id to title