Exception: No recommendation found for page: *
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	thcipriani
	Dec 9 2021, 4:25 PM

Description

Error

mwversion: 1.38.0-wmf.12
reqId: d412fd63-77c6-4ec9-b9f3-e9bbe3b6d507
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   Exception: No recommendation found for page: Petrognathini

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.12/extensions/GrowthExperiments/includes/Util.php(181)
#0 /srv/mediawiki/php-1.38.0-wmf.12/extensions/GrowthExperiments/includes/HomepageHooks.php(371): GrowthExperiments\Util::logStatus(StatusValue)
#1 /srv/mediawiki/php-1.38.0-wmf.12/includes/HookContainer/HookContainer.php(160): GrowthExperiments\HomepageHooks->onBeforePageDisplay(OutputPage, SkinMinerva)
#2 /srv/mediawiki/php-1.38.0-wmf.12/includes/HookContainer/HookRunner.php(935): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#3 /srv/mediawiki/php-1.38.0-wmf.12/includes/OutputPage.php(2686): MediaWiki\HookContainer\HookRunner->onBeforePageDisplay(OutputPage, SkinMinerva)
#4 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(909): OutputPage->output(boolean)
#5 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(922): MediaWiki::{closure}()
#6 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(554): MediaWiki->main()
#7 /srv/mediawiki/php-1.38.0-wmf.12/index.php(53): MediaWiki->run()
#8 /srv/mediawiki/php-1.38.0-wmf.12/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

Impact

Notes

Very low frequency
Only seen on testwiki in the past 24 hours
Reproducible via GET request
Strange that this is hitting the error logs as an exception

Details

Request URL: https://test.wikipedia.org/w/index.php?title=*&getasktype=*&gesuggestededit=*&veaction=*&section=*&geclickid=*&genewcomertasktoken=*

Related Objects

Mentioned Here: T306032: Adapt GrowthExperiments to new Image Suggestions API
T309803: Exception: No recommendation found for page: Genshin_Impact
T295316: Add an image: pre-deployment model refresh
T297656: Exception: All recommendations were filtered for page: البيئة_في_لبنان
rEGRE5b0057b80d56: Add Link: Do not log "no suggestion found" errors in production log

Event Timeline

thcipriani created this task.Dec 9 2021, 4:25 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptDec 9 2021, 4:25 PM

This error is for when the data from the image suggestion API have empty pages or when there is a page but there are no suggestions.

@Sgs and I talked about this. We can implement the same fix as rEGRE5b0057b80d56: Add Link: Do not log "no suggestion found" errors in production log, which is to use a Status::newGood()->error instead of $status->fatal() for the instances in includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php where we don't want error messages appearing in the production error log, but do want them visible on the Growth team dashboard.

In T297406#7564028, @mewoph wrote:

This error is for when the data from the image suggestion API have empty pages or when there is a page but there are no suggestions.

If that's the case with the raw API response (and not a result of our filtering), I think that would be a bug in the API, or the search infrastructure which tells which pages to get suggestions for from the API.

In T297406#7568808, @kostajh wrote:

@Sgs and I talked about this. We can implement the same fix as rEGRE5b0057b80d56: Add Link: Do not log "no suggestion found" errors in production log, which is to use a Status::newGood()->error instead of $status->fatal() for the instances in includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php where we don't want error messages appearing in the production error log, but do want them visible on the Growth team dashboard.

Sorry, I commented on the wrong task -- the comment above is for T297656: Exception: All recommendations were filtered for page: البيئة_في_لبنان

In T297406#7571552, @Tgr wrote:

In T297406#7564028, @mewoph wrote:

This error is for when the data from the image suggestion API have empty pages or when there is a page but there are no suggestions.

If that's the case with the raw API response (and not a result of our filtering), I think that would be a bug in the API, or the search infrastructure which tells which pages to get suggestions for from the API.

For the errors from testwiki, some of the articles have infoboxes (ex: Petrognathini). Since we are not filtering out infoboxes on testwiki, so I think the error is expected. However, some articles (ex: Honoré Flaugergues) only have recommendations from MediaSearch (https://image-suggestion-api.wmcloud.org/image-suggestions/v0/wikipedia/en/pages?id=591646), so perhaps these shouldn't be suggested at all. @Tgr — would this exclusion be on the search infrastructure side or ours?

In the last 30 days, the only non-testwiki errors are from bnwiki from Nov 24, which was around when the model was refreshed. All the images in these were added via #WPWP #WPWPBN campaign.

T295316: Add an image: pre-deployment model refresh was not done for the testwiki search index but it requests enwiki data from the API, which was affected by the refresh, so those discrepancies are expected (same on beta wikis). We could update the search index, not sure it's worth the effort though.

Errors on Nov 24 are presumably from time discrepancy between API update and search index update.

So sounds like there isn't anything unexpected happening here. Thanks for looking into it @mewoph!

@thcipriani not sure how to go about this. We'd want these errors in the production error log if they happened in a real wiki. Should we try to get rid of them for testwiki? They are only triggered via manual testing so I'd expect them to be very rare.

Tgr changed the task status from Open to Stalled.Dec 16 2021, 5:47 AM

I'll assume it's not an issue but feel free to reopen if these errors are problematic.

Krinkle changed the task status from Resolved to Invalid.Jan 13 2022, 6:51 PM

Krinkle moved this task from Untriaged to Jan 2022 on the Wikimedia-production-error board.Feb 4 2022, 1:06 AM

Sounds like we still have work to do on this, from T309803.

These seem to have disappeared since we switched to the new image suggestion API (T306032: Adapt GrowthExperiments to new Image Suggestions API) so I am moving it to QA, and think it can be resolved.

In T297406#8111810, @kostajh wrote:

These seem to have disappeared since we switched to the new image suggestion API (T306032: Adapt GrowthExperiments to new Image Suggestions API) so I am moving it to QA, and think it can be resolved.

The errors stopped on July 7 (the last timestamp: Jul 7, 2022 @ 13:23:18.031) - the link.

	F35399008: Screen Shot 2022-08-04 at 6.00.09 PM.png
	Aug 5 2022, 1:02 AM

Exception: No recommendation found for page: *Closed, ResolvedPublicPRODUCTION ERRORActions