Maniphest T298643

It should be possible to style pages differently in AMC mode to normal mode
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jan 5 2022, 5:26 PM

Tags

Referenced Files

None

Subscribers

Masumrezarock100

Description

Going forward we'll want to style the Special:Contributions page differently depending on whether the user is in AMC or non-AMC mode.

To support this, we'll need to update MobileFrontend to add a class to the body when AMC is enabled.

I suggest the class is mw-mf-amc-enabled.

Needed

I should be able to target the desktop Minerva experience ?useskin=minerva&useformat=desktop
I should be able to target the mobile Minerva experience ?useskin=minerva&useformat=mobile with AMC disabled
I should be able to target the mobile Minerva experience ?useskin=minerva&useformat=mobile with AMC enabled

Details

	Subject	Repo	Branch	Lines +/-
	Add 'mw-mf-amc-enabled' class when AMC is enabled	mediawiki/extensions/MobileFrontend	master	+21 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
		Duplicate		None	T265402 Diff links in mobile watchlist and recent changes go to page instead of diff
		Resolved		Jdlrobson	T210168 [EPIC] Get rid of MobileFrontend's special pages for changes list where equivalents exist in core
		Open		None	T286641 Entry points to improve discoverability of Section Translation
		Open		None	T296994 Observations from research study for Section Translation on Thai Wikipedia
		Open		None	T311647 [Goal] Develop a new menu system API in core
		Open		None	T322740 Contribute entry point
		Resolved		Jdlrobson	T286466 Persistent contribution entry point on the mobile navigation menu
		Resolved		ovasileva	T293268 [GOAL] Remove the mobile version of Special:Contributions
		Resolved		Jdlrobson	T298643 It should be possible to style pages differently in AMC mode to normal mode

Event Timeline

Jdlrobson created this task.Jan 5 2022, 5:26 PM

Jdlrobson moved this task from Backlog to [active] Remove Special:MobileContributions on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jan 5 2022, 5:33 PM

Jdlrobson triaged this task as High priority.Jan 5 2022, 10:58 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog (Needs Prioritization (Tech)).

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

LGoto set the point value for this task to 2.Jan 11 2022, 6:26 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 14 2022, 5:52 PM

bwang claimed this task.Jan 14 2022, 6:45 PM

Change 754030 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/MobileFrontend@master] Add 'mw-mf-amc-enabled' class when AMC is enabled

https://gerrit.wikimedia.org/r/754030

gerritbot added a project: Patch-For-Review.Jan 14 2022, 8:27 PM

bwang removed bwang as the assignee of this task.Jan 14 2022, 8:31 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

bwang subscribed.

Jdlrobson updated the task description. (Show Details)Jan 14 2022, 9:13 PM

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 14 2022, 9:49 PM

bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 18 2022, 5:01 PM

LGoto assigned this task to bwang.Jan 18 2022, 6:29 PM

bwang moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 18 2022, 6:29 PM

bwang removed bwang as the assignee of this task.Jan 19 2022, 3:17 PM

bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Technical task so can skip QA. I'll sign off.

Change 754030 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Add 'mw-mf-amc-enabled' class when AMC is enabled

https://gerrit.wikimedia.org/r/754030

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 19 2022, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2022, 6:10 PM

Workign as expected. Thanks @bwang !

Jdlrobson updated the task description. (Show Details)Jan 28 2022, 12:01 AM