Page MenuHomePhabricator

Diff links in mobile watchlist and recent changes go to page instead of diff
Closed, DuplicatePublic

Description

Steps to reproduce:

Note that fawiki does not use the same "Watchlist" view in the mobile frontend as most other projects. We are part of some of the design programs (I bet @Ladsgroup can clarify which ones). Don't be surprised if https://fa.m.wikipedia.org/wiki/Special:Watchlist?uselang=en does not look like https://en.m.wikipedia.org/wiki/Special:Watchlist?uselang=en to you.

Note also that the RecentChanges page on mobile view is also broken in the same way.

Of note, the issue with curid confusing what should be rendered is coming up twice now (previously in T260713 where I assumed it was intended behavior, so I revised CheckUser code to simply not return curid when not applicable). Could we have possibly messed up the order in which parameters are consumed such that curid is now being checked before others? The issue reported here, with diff links, is certainly new.

Related Objects

Event Timeline

Huji added a subscriber: Ladsgroup.

The title of this issue undersells the problem quite a bit. In other words, mobile recent changes and watchlist are basically unusable right now, since all (diff) links are broken (leading to the full view instead of the diff).

Pcoombe renamed this task from Diff link from mobile view doesn't take user to a diff if curid is present to Diff links in mobile watchlist and recent changes go to page instead of diff.Oct 14 2020, 2:31 PM

Someone reported same problem in vi.wp

Someone reported same problem in kowiki too

Ammarpad changed the task status from Open to Stalled.EditedOct 15 2020, 10:56 AM
Ammarpad added a subscriber: Ammarpad.

This is caused by using mixture of core special page (AMC mode) and sending request from there to MobileFontend mobile special page. In desktop request of the diff cur_id is a valid substitute for page title. However, Jdlrobson made it clear in T174194 that there is no desire to continue fixing these mobile special page issues severally, instead, they should all wait for the eventual switch of the pages to use the original core special pages directly.

@Uncitoyen has reported that it also happens at trwiki. The diff button on Special:RecentChanges provides an URL in the following form:

https://tr.m.wikipedia.org/w/index.php?title=Daniel_Amokachi&curid=52793&diff=23782154&oldid=23659619

This turns into the following and you end up on the actual article page, not the diff page as intended:

https://tr.m.wikipedia.org/w/index.php?title=%C3%96zel:MobileDiff/23782154&curid=52793

@Uncitoyen has reported that it also happens at trwiki. The diff button on Special:RecentChanges provides an URL in the following form:

https://tr.m.wikipedia.org/w/index.php?title=Daniel_Amokachi&curid=52793&diff=23782154&oldid=23659619

This turns into the following and you end up on the actual article page, not the diff page as intended:

https://tr.m.wikipedia.org/w/index.php?title=%C3%96zel:MobileDiff/23782154&curid=52793
https://tr.m.wikipedia.org/w/index.php?title=%C3%96zel:MobileDiff/23782154

This is works normally.

https://tr.m.wikipedia.org/w/index.php?title=%C3%96zel:MobileDiff/23782154

This is works normally.

Sure, if you get rid of the curid, then it works. But this is the not the link you get. Including the curid basically overrides the title parameter, so

https://tr.m.wikipedia.org/w/index.php?title=%C3%96zel:MobileDiff/23782154&curid=52793

and

https://tr.m.wikipedia.org/w/index.php?curid=52793

result in the same output.

https://tr.m.wikipedia.org/w/index.php?title=%C3%96zel:MobileDiff/23782154

This is works normally.

Sure, if you get rid of the curid, then it works. But this is the not the link you get. Including the curid basically overrides the title parameter, so

https://tr.m.wikipedia.org/w/index.php?title=%C3%96zel:MobileDiff/23782154&curid=52793

and

https://tr.m.wikipedia.org/w/index.php?curid=52793

result in the same output.

Both links are currently not functioning normally and need to be modified. So I left this message here. Thanks.

AFAICS this happens for everyone who has Advanced mobile contributions enabled.

You are spot on!