Page MenuHomePhabricator
Create Task
Maniphest T265402

Diff links in mobile watchlist and recent changes go to page instead of diff
Closed, DuplicatePublic
Actions

Description

Steps to reproduce:

Note that fawiki does not use the same "Watchlist" view in the mobile frontend as most other projects. We are part of some of the design programs (I bet @Ladsgroup can clarify which ones). Don't be surprised if https://fa.m.wikipedia.org/wiki/Special:Watchlist?uselang=en does not look like https://en.m.wikipedia.org/wiki/Special:Watchlist?uselang=en to you.

Note also that the RecentChanges page on mobile view is also broken in the same way.

Of note, the issue with curid confusing what should be rendered is coming up twice now (previously in T260713 where I assumed it was intended behavior, so I revised CheckUser code to simply not return curid when not applicable). Could we have possibly messed up the order in which parameters are consumed such that curid is now being checked before others? The issue reported here, with diff links, is certainly new.

Related Objects
Search...

StatusSubtypeAssignedTask
 DuplicateNoneT265402 Diff links in mobile watchlist and recent changes go to page instead of diff
 ResolvedJdlrobsonT210168 [EPIC] Get rid of MobileFrontend's special pages for changes list where equivalents exist in core
 ResolvedJdlrobsonT210120 Suppressed username appears weird when viewing history
 ResolvedovasilevaT216420 [EPIC] Display core version of history page
 ResolvedovasilevaT219874 It should be possible to view the desktop history page in AMC
 ResolvedovasilevaT224970 Deploy new history page to AMC users
 ResolvedovasilevaT219895 Style the history page for AMC users
 ResolvedBUG REPORTovasilevaT222394 [subtask] Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist"
 ResolvedNoneT205581 History, Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements
 ResolvedJdlrobsonT212613 Change tags in some interfaces are missing parenthesis
 ResolvedGTrangT219714 History shows "((empty))" for blank revisions
 ResolvedovasilevaT214531 History links with curid set do not redirect properly on mobile
 ResolvedovasilevaT293268 [GOAL] Remove the mobile version of Special:Contributions
 ResolvedJdlrobsonT298636 All pagers should have a shared ResourceLoader module
 ResolvedJdlrobsonT298637 Add diff link to Pager HTML generating class
 ResolvedJdlrobsonT298638 Make modifications to Pager HTML to add heading separators to support Minerva skinning
 ResolvedNoneT298639 Add time element to Pager rows
 ResolvedJdlrobsonT298643 It should be possible to style pages differently in AMC mode to normal mode
 ResolvedJdlrobsonT298644 How should ContentTranslation work on mobile contributions page
 ResolvedAmmarpadT298645 On contributions page add hidden "No edit summary" element when an edit had no edit summary
 ResolvedovasilevaT300185 Always show AMC mode of contributions page to mobile users

Event Timeline

Huji created this task.Oct 13 2020, 7:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2020, 7:57 PM
Huji updated the task description. (Show Details)Oct 13 2020, 8:04 PM
Huji added a subscriber: Ladsgroup.
XanonymusX subscribed.Oct 14 2020, 8:09 AM
Stegosaurus_Rex subscribed.Oct 14 2020, 11:09 AM
Pcoombe merged a task: T265475: Diff links not working on mobile view - watchlist.Oct 14 2020, 12:37 PM
Pcoombe added a subscriber: LeeVilenski.
Pcoombe added a project: MediaWiki-Watchlist.Oct 14 2020, 12:41 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 14 2020, 12:41 PM
Count_Count subscribed.Oct 14 2020, 1:29 PM
Mormegil subscribed.Oct 14 2020, 2:12 PM

The title of this issue undersells the problem quite a bit. In other words, mobile recent changes and watchlist are basically unusable right now, since all (diff) links are broken (leading to the full view instead of the diff).

Huji updated the task description. (Show Details)Oct 14 2020, 2:14 PM
Pcoombe renamed this task from Diff link from mobile view doesn't take user to a diff if curid is present to Diff links in mobile watchlist and recent changes go to page instead of diff.Oct 14 2020, 2:31 PM
minhhuy subscribed.Oct 14 2020, 5:15 PM

Someone reported same problem in vi.wp

Gomdoli4696 subscribed.Oct 14 2020, 11:27 PM

Someone reported same problem in kowiki too

Ammarpad changed the task status from Open to Stalled.EditedOct 15 2020, 10:56 AM
Ammarpad edited projects, added Advanced Mobile Contributions; removed Growth-Team, MediaWiki-Watchlist, MediaWiki-Page-diffs.
Ammarpad subscribed.

This is caused by using mixture of core special page (AMC mode) and sending request from there to MobileFontend mobile special page. In desktop request of the diff cur_id is a valid substitute for page title. However, Jdlrobson made it clear in T174194 that there is no desire to continue fixing these mobile special page issues severally, instead, they should all wait for the eventual switch of the pages to use the original core special pages directly.

Ammarpad mentioned this in T174194: Display user account blocks in mobile view on Special:Contributions.Oct 15 2020, 11:07 AM
Ammarpad added a subtask: T210168: [EPIC] Get rid of MobileFrontend's special pages for changes list where equivalents exist in core.
Vito-Genovese added subscribers: Uncitoyen, Vito-Genovese.Oct 15 2020, 4:13 PM

@Uncitoyen has reported that it also happens at trwiki. The diff button on Special:RecentChanges provides an URL in the following form:

https://tr.m.wikipedia.org/w/index.php?title=Daniel_Amokachi&curid=52793&diff=23782154&oldid=23659619

This turns into the following and you end up on the actual article page, not the diff page as intended:

https://tr.m.wikipedia.org/w/index.php?title=%C3%96zel:MobileDiff/23782154&curid=52793
Count_Count added a project: Regression.Oct 15 2020, 5:21 PM
Count_Count added a comment.Oct 15 2020, 5:27 PM

AFAICS this happens for everyone who has Advanced mobile contributions enabled.

Gomdoli4696 added a comment.Oct 15 2020, 11:25 PM
In T265402#6547354, @Vito-Genovese wrote:

@Uncitoyen has reported that it also happens at trwiki. The diff button on Special:RecentChanges provides an URL in the following form:

https://tr.m.wikipedia.org/w/index.php?title=Daniel_Amokachi&curid=52793&diff=23782154&oldid=23659619

This turns into the following and you end up on the actual article page, not the diff page as intended:

https://tr.m.wikipedia.org/w/index.php?title=%C3%96zel:MobileDiff/23782154&curid=52793
https://tr.m.wikipedia.org/w/index.php?title=%C3%96zel:MobileDiff/23782154

This is works normally.

Vito-Genovese added a comment.Oct 15 2020, 11:44 PM
In T265402#6548933, @Gomdoli4696 wrote:
https://tr.m.wikipedia.org/w/index.php?title=%C3%96zel:MobileDiff/23782154

This is works normally.

Sure, if you get rid of the curid, then it works. But this is the not the link you get. Including the curid basically overrides the title parameter, so

https://tr.m.wikipedia.org/w/index.php?title=%C3%96zel:MobileDiff/23782154&curid=52793

and

https://tr.m.wikipedia.org/w/index.php?curid=52793

result in the same output.

Gomdoli4696 added a comment.Oct 15 2020, 11:46 PM
In T265402#6548966, @Vito-Genovese wrote:
In T265402#6548933, @Gomdoli4696 wrote:
https://tr.m.wikipedia.org/w/index.php?title=%C3%96zel:MobileDiff/23782154

This is works normally.

Sure, if you get rid of the curid, then it works. But this is the not the link you get. Including the curid basically overrides the title parameter, so

https://tr.m.wikipedia.org/w/index.php?title=%C3%96zel:MobileDiff/23782154&curid=52793

and

https://tr.m.wikipedia.org/w/index.php?curid=52793

result in the same output.

Both links are currently not functioning normally and need to be modified. So I left this message here. Thanks.

Izno subscribed.Oct 16 2020, 1:42 PM
Huji added a comment.Oct 16 2020, 2:46 PM
In T265402#6547624, @Count_Count wrote:

AFAICS this happens for everyone who has Advanced mobile contributions enabled.

You are spot on!

Sakretsu subscribed.Oct 17 2020, 5:57 PM
Pcoombe closed this task as a duplicate of T265654: Accessing diff pages from the watchlist points to revision page rather than diff page as curid parameter is not unset.Oct 18 2020, 12:44 PM
Jdlrobson closed subtask T210168: [EPIC] Get rid of MobileFrontend's special pages for changes list where equivalents exist in core as Resolved.Mar 30 2022, 10:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL