Page MenuHomePhabricator

[Regression] Can't search on mobile on grade C browsers
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

Likely caused by T294164

QA

  • Disable JS or use an older device
  • Visit any page
  • Type in search box
  • Click search icon

Expected: search performed
actual: nothing

Source: https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=1070657405#Search_button_is_broken

Developer notes

The submit button for the search is outside the form. The HTML should be updated so that's not the case.

QA Results - Beta

ACStatusDetails
1T301257#7745157 T301257#7751330

QA Results - Prod

ACStatusDetails
1T301257#7757713

Event Timeline

Xaosflux changed the subtype of this task from "Task" to "Bug Report".

Change 764846 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Search icon should be part of search form for grade C browsers

https://gerrit.wikimedia.org/r/764846

Change 764846 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Search icon should be part of search form for grade C browsers

https://gerrit.wikimedia.org/r/764846

Edtadros added a subscriber: Edtadros.

Test Result - Beta

Status: ❌ Fail
Environment: beta
OS: macOS Monterey
Browser: Chrome 70
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Disable JS or use an older device
Visit any page
Type in search box
Click search icon
❌ AC1: Expected: search performed

Chrome 70 (Grade C per https://www.mediawiki.org/wiki/Compatibility#Basic_(Grade_C)) with JS turned off

Screen Recording 2022-03-01 at 9.24.48 AM.mov.gif (938×882 px, 345 KB)

Chrome 70 with JS turned on

Screen Recording 2022-03-01 at 9.26.13 AM.mov.gif (938×882 px, 1 MB)

hi @Edtadros -- I might be misunderstanding the bug and the fix but testing mediawiki mobile search with javascript disabled, I was under the impression we are testing clicking on the search icon over to the right, not the one inside the search input itself:

Screen Shot 2022-03-02 at 12.11.00 PM.png (1×1 px, 444 KB)

If you compare to prod enwiki (mobile, javascript disabled - on 1.38.0-wmf.23) https://en.m.wikipedia.org/wiki/Dog, enter a search term, and then click on the icon over to the right, it doesn't do anything but on mediawiki (mobile, javascript disabled - on 1.38.0-wmf.24), it does return results in the main content area.

Test Result - Beta

Thanks @cjming, I'm retesting now looking at the correct search icon.

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome with JS disabled
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Disable JS or use an older device
Visit any page
Type in search box
Click search icon
✅ AC1: Expected: search performed

Screen Recording 2022-03-03 at 10.26.35 AM.mov.gif (1×1 px, 971 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome with JS disabled
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Disable JS or use an older device
Visit any page
Type in search box
Click search icon
✅ AC1: Expected: search performed

Screen Recording 2022-03-07 at 9.22.45 AM.mov.gif (1×934 px, 534 KB)

Edtadros updated the task description. (Show Details)