Page MenuHomePhabricator
Create Task
Maniphest T302643

Beta Meta-Wiki throws an error on Special:Preferences: DomainException: HTMLForm::getField: no field named globalwatchlist-prefs
Closed, ResolvedPublicBUG REPORT
Actions

Description

Special:Preferences throws an error on Beta Meta-Wiki.

https://meta.wikipedia.beta.wmflabs.org/wiki/Special:Preferences

GlobalWatchlist is only installed on Meta-Wiki.

[Yhl5CwPi1uq8kC9ZFWR-mwAAAAQ] /wiki/Special:Preferences DomainException: HTMLForm::getField: no field named globalwatchlist-prefs

Backtrace:

from /srv/mediawiki/php-master/includes/htmlform/HTMLForm.php(441)
#0 /srv/mediawiki/php-master/includes/preferences/DefaultPreferencesFactory.php(326): HTMLForm->getField(string)
#1 /srv/mediawiki/php-master/includes/preferences/DefaultPreferencesFactory.php(251): MediaWiki\Preferences\DefaultPreferencesFactory->loadPreferenceValues(User, RequestContext, array)
#2 /srv/mediawiki/php-master/extensions/GlobalPreferences/includes/GlobalPreferencesFactory.php(116): MediaWiki\Preferences\DefaultPreferencesFactory->getFormDescriptor(User, RequestContext)
#3 /srv/mediawiki/php-master/includes/preferences/DefaultPreferencesFactory.php(1755): GlobalPreferences\GlobalPreferencesFactory->getFormDescriptor(User, RequestContext)
#4 /srv/mediawiki/php-master/includes/specials/SpecialPreferences.php(132): MediaWiki\Preferences\DefaultPreferencesFactory->getForm(User, RequestContext, string)
#5 /srv/mediawiki/php-master/includes/specials/SpecialPreferences.php(110): SpecialPreferences->getFormObject(User, RequestContext)
#6 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(671): SpecialPreferences->execute(NULL)
#7 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(1378): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-master/includes/MediaWiki.php(315): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(910): MediaWiki->performRequest()
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(564): MediaWiki->main()
#11 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#12 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}

Details

SubjectRepoBranchLines +/-
Re-apply "preferences: Use a faster and simpler form descriptor when validating"mediawiki/coremaster+45 -3
Revert "preferences: Use a faster and simpler form descriptor when validating"mediawiki/corewmf/1.38.0-wmf.24+2 -42
Revert "preferences: Use a faster and simpler form descriptor when validating"mediawiki/coremaster+2 -42
Customize query in gerrit

Related Objects

Event Timeline

Dylsss created this task.Feb 26 2022, 12:53 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptFeb 26 2022, 12:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Dylsss triaged this task as Unbreak Now! priority.Feb 26 2022, 1:50 AM
Dylsss added a project: Regression.

Train blocker, this would break Special:Preferences and Special:GlobalPreferences on Meta-Wiki and testwiki in production

Caused by 07b4daf.

Zabe added a parent task: T300200: 1.38.0-wmf.24 deployment blockers.Feb 26 2022, 1:53 AM
Dylsss added a project: MediaWiki-Core-Preferences.Feb 26 2022, 2:01 AM
Func subscribed.Feb 26 2022, 2:08 AM
gerritbot added a comment.Feb 26 2022, 2:58 AM

Change 766206 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] DefaultPreferencesFactory: Skip the attempt of loading value for info fields

https://gerrit.wikimedia.org/r/766206

gerritbot added a project: Patch-For-Review.Feb 26 2022, 2:58 AM
brennen subscribed.Mar 1 2022, 5:49 PM
brennen added a subscriber: DannyS712.Mar 1 2022, 6:24 PM

@DannyS712 any thoughts here?

brennen added subscribers: Krinkle, Jdforrester-WMF, Ladsgroup.Mar 1 2022, 6:34 PM

Also cc: @Jdforrester-WMF, @Krinkle, @Ladsgroup as reviewers listed on above patch.

Stashbot mentioned this in T300200: 1.38.0-wmf.24 deployment blockers.Mar 1 2022, 6:57 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-01T18:57:31Z] <brennen> 1.38.0-wmf.24 train (T300200): there's currently a single blocker at T302643; staging to testwikis and holding there until backport's available

gerritbot added a comment.Mar 1 2022, 7:33 PM

Change 767088 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] Revert \"preferences: Use a faster and simpler form descriptor when validating\"

https://gerrit.wikimedia.org/r/767088

gerritbot added a comment.Mar 1 2022, 7:34 PM

Change 767089 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@wmf/1.38.0-wmf.24] Revert \"preferences: Use a faster and simpler form descriptor when validating\"

https://gerrit.wikimedia.org/r/767089

Krinkle updated the task description. (Show Details)Mar 1 2022, 7:36 PM
gerritbot added a comment.Mar 1 2022, 7:53 PM

Change 767088 merged by jenkins-bot:

[mediawiki/core@master] Revert \"preferences: Use a faster and simpler form descriptor when validating\"

https://gerrit.wikimedia.org/r/767088

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 1 2022, 8:00 PM
gerritbot added a comment.Mar 1 2022, 8:27 PM

Change 767089 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.24] Revert \"preferences: Use a faster and simpler form descriptor when validating\"

https://gerrit.wikimedia.org/r/767089

Stashbot added a comment.Mar 1 2022, 8:30 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-01T20:30:49Z] <brennen@deploy1002> Synchronized php-1.38.0-wmf.24/includes: Backport: [[gerrit:767089|Revert "preferences: Use a faster and simpler form descriptor when validating" (T302643)]] (duration: 00m 55s)

brennen lowered the priority of this task from Unbreak Now! to Needs Triage.Mar 1 2022, 8:31 PM
brennen removed a parent task: T300200: 1.38.0-wmf.24 deployment blockers.

Revert tested and deployed. Removing as train blocker; leaving open in case there is some followup.

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.24; 2022-02-28); removed MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 1 2022, 9:00 PM
gerritbot added a comment.Mar 10 2022, 11:17 PM

Change 766206 merged by jenkins-bot:

[mediawiki/core@master] Re-apply "preferences: Use a faster and simpler form descriptor when validating"

https://gerrit.wikimedia.org/r/766206

matmarex closed this task as Resolved.Mar 10 2022, 11:38 PM
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.26; 2022-03-14); removed MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Mar 11 2022, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 11 2022, 12:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits