This is occurring because we removed the RecentChange_save hook in rEGREdc377d2963ec: Tag newcomer task edits via VisualEditor or post-edit dialog in favor of applying the tags manually when we are saving edits. That works for associating change tags with an edit, but it won't add them to the RecentChanges feed.

Change 773879 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] [WIP] Apply newcomer task change tags to RecentChange object in job

https://gerrit.wikimedia.org/r/773879

In T304747#7807637, @kostajh wrote:

This is occurring because we removed the RecentChange_save hook in rEGREdc377d2963ec: Tag newcomer task edits via VisualEditor or post-edit dialog in favor of applying the tags manually when we are saving edits. That works for associating change tags with an edit, but it won't add them to the RecentChanges feed.

... and the reason it doesn't show up in RC feed is documented in T24509: RCFeed should include change tags. I'll see if I can implement a workaround.

@kostajh -- just for our information, when this is fixed, will the diffs from the "bug era" show up in RecentChanges retroactively, or will it only apply for diffs made after the fix?

In T304747#7812095, @MMiller_WMF wrote:

@kostajh -- just for our information, when this is fixed, will the diffs from the "bug era" show up in RecentChanges retroactively, or will it only apply for diffs made after the fix?

After the fix is in production, we'll start seeing the tags in RecentChanges, but we won't see tags for edits made while this was broken, unless we run, rebuildrecentchanges.php for that time period. I can ask around to see if it is feasible to do that, but because it is potentially a huge amount of rows to update, I am not sure if it is going to be a popular idea.

Change 774875 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] selenium: Temporarily disable tests so VisualEditor patch can merge

https://gerrit.wikimedia.org/r/774875

Change 774020 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/VisualEditor@master] Allow hook implementations to modify params

https://gerrit.wikimedia.org/r/774020

Change 774876 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] selenium: Re-enable tests

https://gerrit.wikimedia.org/r/774876

In T304747#7812488, @kostajh wrote:

After the fix is in production, we'll start seeing the tags in RecentChanges, but we won't see tags for edits made while this was broken, unless we run, rebuildrecentchanges.php for that time period. I can ask around to see if it is feasible to do that, but because it is potentially a huge amount of rows to update, I am not sure if it is going to be a popular idea.

As it is limited to RCs, I think we are good to let things as they are.
At big wikis, the feed is too big: no one would (or can) filter out edits being a while ago. At smaller wikis, checking RCs is more likely done entry by entry. And they are other ways to check on recent edits: watchlists, Special:Contributions, etc.

For Tech News :

During a few days, edits suggested to newcomers were not tagged in the Special:RecentChanges feed. This bug has been fixed.

Notes for testing:

• testwiki wmf.5 for March 29 - edits made by Zilant17 (RC filters are bookmarked): the edits with Newcomer tags are not shown on RC
• 'View history' shows Newcomer tags
• RC filter "Page edits" shows the tagged edits just as Page edits (the tags are not shown).

In T304747#7814146, @Trizek-WMF wrote:

In T304747#7812488, @kostajh wrote:

After the fix is in production, we'll start seeing the tags in RecentChanges, but we won't see tags for edits made while this was broken, unless we run, rebuildrecentchanges.php for that time period. I can ask around to see if it is feasible to do that, but because it is potentially a huge amount of rows to update, I am not sure if it is going to be a popular idea.

As it is limited to RCs, I think we are good to let things as they are.
At big wikis, the feed is too big: no one would (or can) filter out edits being a while ago. At smaller wikis, checking RCs is more likely done entry by entry. And they are other ways to check on recent edits: watchlists, Special:Contributions, etc.

I agree. It's fine for those diffs to be missing. I just wanted to know what to expect.

Change 774875 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] selenium: Temporarily disable tests so VisualEditor patch can merge

https://gerrit.wikimedia.org/r/774875

Change 774020 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Allow hook implementations to modify params

https://gerrit.wikimedia.org/r/774020

Change 774876 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] VisualEditorHooks: Update hook compatibility, re-enable Selenium tests

https://gerrit.wikimedia.org/r/774876

If I understand correctly, this hasn't been fixed yet, right?

In T304747#7846081, @Trizek-WMF wrote:

If I understand correctly, this hasn't been fixed yet, right?

I re-checked Recent Changes on several wikis (wmf.6) and edits with #Newcomer task tag are present in RC, but not those with Suggested: add images and Suggested: add links tags.

Thank you Elena. Looping back to Tech News.

Change 784247 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Re-add RC tags Selenium test

https://gerrit.wikimedia.org/r/784247

Moving to QA. There is an open patch for adding another Selenium test, but the feature itself should be ready for checking.

Note that the tags are only added for VE-based edits.

Change 773879 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] RecentChanges: Fix newcomer task tags display

https://gerrit.wikimedia.org/r/773879

Per today's standup, I'll move back to in progress for tagging wikitext edits.

Doing this for the various editors is a number of distinct changes. I'm repurposing this task to be about VE only.

Checked in testwiki wmf.9 - all Newcomer tags are visible in RC.

Additional check is done in testwiki 10 - no problems were found.

Change 784247 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Re-add RC tags Selenium test

https://gerrit.wikimedia.org/r/784247