Page MenuHomePhabricator
Create Task
Maniphest T307468

[M] Appearance update of "Sister project widgets" on Special:Search
Closed, ResolvedPublic
Actions

Assigned To
SimoneThisDot
Authored By
Seddon
May 3 2022, 2:24 PM
Tags
Referenced Files
F35490051: IMG_1883.PNG
Aug 25 2022, 6:17 PM
F35490049: IMG_1882.PNG
Aug 25 2022, 6:17 PM
F35456475: Screenshot_20220815-132749_Chrome (1).jpg
Aug 15 2022, 8:56 PM
F35456473: Screenshot_20220815-133933_Chrome.jpg
Aug 15 2022, 8:56 PM
F35456471: Screen Shot 2022-08-15 at 1.28.58 PM.png
Aug 15 2022, 8:56 PM
F35456458: Screen Shot 2022-08-15 at 1.20.58 PM.png
Aug 15 2022, 8:56 PM
F35456455: Screen Shot 2022-08-15 at 1.01.09 PM.png
Aug 15 2022, 8:56 PM
F35456453: Screen Shot 2022-08-15 at 1.01.36 PM.png
Aug 15 2022, 8:56 PM
View All 14 Files
Subscribers
Aklapper
AUgolnikova-WMF
CBogen
Etonkovidova
MarkThisDot
Seddon
Sneha

Description

Problem

The sister projects on the right are often unnoticed by users. Some users think they may be ads. Most users are not aware of these sister projects often noted in the user interviews.

Current presentation of sister projects

sister projects.png (1×3 px, 852 KB)

User story

When going through search on special:search page … 
… I want to be able to see links to relevant non-wikipedia content like linked galleries, wikiquotes etc,
… so that I can discover and explore other wikiprojects for relevant content.

Proposed design
Link to Desktop specs in Figma

sister projects.png (800×1 px, 113 KB)

Link to Mobile specs in Figma

Mobile_sister projects.png (800×360 px, 52 KB)

Acceptance Criteria

  • Remove the header "Results from sister projects"
  • Remove background box
  • Update sister projects icons. These are the new black and white icons added to design system. All the icons can be found at the bottom of this icon list.
  • Add sister project name as a header (with icon) for each project
  • Update sister project search outlink copy, style and placement. - "See all results" link in the mock.
  • Add new spacing/padding to better align with the overall page. Follow the grid as mentioned in this ticket. The padding within the section can be found on Figma
  • Mobile only: Show sister projects below the results only on the first page. Currently it is repeated on all pages.

Details

SubjectRepoBranchLines +/-
ppearance update of "Sister project widgets" on Special:Searchmediawiki/coremaster+54 -31
Customize query in gerrit

Related Objects
Search...

Event Timeline

Seddon created this task.May 3 2022, 2:24 PM
Aklapper added a project: CSS.May 3 2022, 2:38 PM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.May 3 2022, 3:48 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
Seddon edited parent tasks, added: T306626: [EPIC] Basic UI/UX improvements to the special:search page; removed: T307066: Interim update of existing special:search CSS and minor changes to sister projects structure.May 4 2022, 11:34 AM
CBogen renamed this task from Appearance update of "Sister project widgets" on Special:Search to [M] Appearance update of "Sister project widgets" on Special:Search.May 4 2022, 4:34 PM
CBogen added a comment.May 4 2022, 5:55 PM

Noting that development can begin, but nothing should be merged until we've had the chance to get feedback from the communities (in progress).

CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.May 4 2022, 5:55 PM
CBogen moved this task from Ready for Development to Needs Design on the Structured-Data-Backlog (Current Work) board.
Sneha updated the task description. (Show Details)May 11 2022, 8:36 PM
CBogen moved this task from Needs Design to Ready for Development on the Structured-Data-Backlog (Current Work) board.May 12 2022, 2:59 PM
Sneha updated the task description. (Show Details)May 12 2022, 9:13 PM
Sneha updated the task description. (Show Details)May 12 2022, 10:52 PM
Sneha updated the task description. (Show Details)
Sneha moved this task from Ready for Development to Needs Design on the Structured-Data-Backlog (Current Work) board.May 18 2022, 2:32 PM
Sneha updated the task description. (Show Details)May 26 2022, 6:18 PM
Sneha updated the task description. (Show Details)May 27 2022, 3:27 PM
CBogen moved this task from Needs Design to Ready for Development on the Structured-Data-Backlog (Current Work) board.May 31 2022, 6:25 PM
CBogen updated the task description. (Show Details)May 31 2022, 6:38 PM
CBogen mentioned this in T311165: Add CTR for sister projects on special:search to search improvements dashboard.Jun 22 2022, 6:16 PM
MarkThisDot claimed this task.Jul 1 2022, 3:15 PM
MarkThisDot moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Jul 7 2022, 10:09 AM

Change 811927 had a related patch set uploaded (by MarkThisDot; author: MarkThisDot):

[mediawiki/core@master] ppearance update of "Sister project widgets" on Special:Search

https://gerrit.wikimedia.org/r/811927

gerritbot added a project: Patch-For-Review.Jul 7 2022, 10:09 AM
MarkThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Jul 8 2022, 12:11 PM
MarkThisDot reassigned this task from MarkThisDot to SimoneThisDot.Jul 8 2022, 12:27 PM
MarkThisDot subscribed.

Completed and handover to Simone

bmartinezcalvo mentioned this in T314661: Add Wikimedia logos icons in OOUI and Codex.Aug 5 2022, 3:20 PM
gerritbot added a comment.Aug 5 2022, 5:42 PM

Change 811927 abandoned by Seddon:

[mediawiki/core@master] ppearance update of "Sister project widgets" on Special:Search

Reason:

https://gerrit.wikimedia.org/r/811927

gerritbot added a comment.Aug 5 2022, 5:42 PM

Change 811927 restored by Seddon:

[mediawiki/core@master] ppearance update of "Sister project widgets" on Special:Search

https://gerrit.wikimedia.org/r/811927

PatchDemoBot added a comment.Aug 5 2022, 10:11 PM

Test wiki created on Patch demo by Seddon using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/a551069181/w

gerritbot added a comment.Aug 9 2022, 8:09 PM

Change 811927 merged by jenkins-bot:

[mediawiki/core@master] ppearance update of "Sister project widgets" on Special:Search

https://gerrit.wikimedia.org/r/811927

Seddon moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Aug 9 2022, 8:12 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 9 2022, 9:00 PM
CBogen moved this task from Backlog to Milestone 1: CSS changes to all wikis on the SDAW-Search-Improvements board.Aug 10 2022, 5:49 PM
CBogen edited projects, added SDAW-Search-Improvements (Milestone 1: CSS changes to all wikis); removed SDAW-Search-Improvements.
Sneha added a comment.Aug 10 2022, 9:48 PM

Update on the new icons to be added to OOUI by design systems team. The ticket has been created T314661 and I am waiting on the status on when it will be available.

Sneha added a comment.Aug 12 2022, 1:28 PM

Update from Volker on DS team: The icons will be available next week on Tuesday. The release goes into next MediaWiki branch cut, which is normally night Mon to Tue PST

Etonkovidova moved this task from Needs QA to Design QA on the Structured-Data-Backlog (Current Work) board.Aug 15 2022, 8:56 PM
Etonkovidova subscribed.

For design review (@Sneha) - the following specs are not yet done
- Update sister projects icons. These are the new black and white icons added to design system. All the icons can be found at the bottom of this icon list.
Based on your comment above, the new icons icons will be available later (after wmf.25 deployment).
- Add sister project name as a header (with icon) for each project
The project names are not present - see the screenshots below.
- Mobile only: Show sister projects below the results only on the first page. Currently it is repeated on all pages.
The sister projects are present on every page.

(1) Desktop: wikiproject name displayed as a link

mockupbetalabsproduction
Screen Shot 2022-08-15 at 1.01.36 PM.png (689×1 px, 143 KB)
Screen Shot 2022-08-15 at 1.01.09 PM.png (603×1 px, 117 KB)
Screen Shot 2022-08-15 at 1.20.58 PM.png (748×1 px, 234 KB)

(2) Mobile

  • no dividing line
  • project icons are displayed on a separate line (due to project names displayed as links)
mockupbetalabsproduction
Screen Shot 2022-08-15 at 1.28.58 PM.png (1×954 px, 643 KB)
Screenshot_20220815-133933_Chrome.jpg (2×1 px, 614 KB)
Screenshot_20220815-132749_Chrome (1).jpg (2×1 px, 469 KB)
Etonkovidova updated the task description. (Show Details)Aug 15 2022, 8:56 PM
Seddon added a comment.Aug 16 2022, 3:40 AM
  • The project name alias' are , when it hits production the project name rather than the domain should show. It performed correctly locally and it should perform as expected in production.
  • Divider added to a qa fix task
  • New task filed to cover switching to new icons.
Seddon moved this task from Design QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Aug 16 2022, 3:42 AM
Seddon moved this task from Verify on Production to Design QA on the Structured-Data-Backlog (Current Work) board.Aug 16 2022, 5:23 AM
Seddon updated the task description. (Show Details)Aug 16 2022, 9:23 AM
Sneha mentioned this in T315324: Outstanding appearance update of "Sister project widgets" on Special:Search.Aug 16 2022, 2:25 PM
Seddon moved this task from Design QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Aug 17 2022, 4:22 PM
CBogen added a comment.Aug 18 2022, 2:40 PM

Note for QA: some AC were not complete and those have been moved to T315324. As long as the rest passes QA, this can be closed.

Etonkovidova closed this task as Resolved.Aug 25 2022, 6:17 PM

Re-checked in wmf.26 (both desktop and mobile) and, also, reviewed T315324: Outstanding appearance update of "Sister project widgets" on Special:Search - all UI display issues are captured there. No additional issues were found - closing this task as Resolved.

Interesting, that cawiki adds its own version of sister wikis reference when there are no search results found.
Compare

cawikienwiki
IMG_1882.PNG (1×640 px, 119 KB)
IMG_1883.PNG (1×640 px, 93 KB)
PatchDemoBot added a comment.Oct 18 2022, 2:13 PM

Test wiki on Patch demo by Seddon using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/a551069181/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits