[wmf.17-mobile] "Suggestions" label has no padding
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Etonkovidova
	Jun 27 2022, 11:00 PM

Description

On mobile go to any structured task.
In the suggestion mode "Suggestion" label will be displayed close to the left edge.

Tested in browser emulators and on real devices (both iPhone and Android).

Screen Shot 2022-06-27 at 3.45.20 PM.png (990×760 px, 95 KB)

Details

Subject	Repo	Branch	Lines +/-
selenium: Verify that close button exists on mobile	mediawiki/extensions/GrowthExperiments	master	+67 -14
Structured task: Add 'cancel' to the list of allowed commands	mediawiki/extensions/GrowthExperiments	wmf/1.39.0-wmf.17	+1 -1
Structured task: Add 'cancel' to the list of allowed commands	mediawiki/extensions/GrowthExperiments	wmf/1.39.0-wmf.18	+1 -1
Structured task: Add 'cancel' to the list of allowed commands	mediawiki/extensions/GrowthExperiments	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T306763: No timeout recovery when switching between visual and source editor
T310694: While using the mobile site with a keyboard, pressing escape does not close the visual editor
T310695: Pressing Escape when the focus is outside of the editor (e.g. the sidebar language popup is open) closes VE

Event Timeline

Etonkovidova created this task.Jun 27 2022, 11:00 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 27 2022, 11:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• mewoph claimed this task.Jun 28 2022, 4:53 PM

• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

This is caused by missing back button. This regressed from VE's change to use cancel command for ve.ui.MWBackTool, which is extended by MachineSuggestionsBack. GrowthExperiments maintains an allow list of commands that can be used for structured tasks, since cancel was not in the list of allowed commands, the back tool is deemed unavailable.

This bug was introduced by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/805810, which addresses T310694, T310695, T306763.

Change 809221 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Structured task: Add 'cancel' to the list of allowed commands

https://gerrit.wikimedia.org/r/809221

gerritbot added a project: Patch-For-Review.Jun 28 2022, 5:00 PM

• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 28 2022, 5:01 PM

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 28 2022, 5:11 PM

Add link	Add image

Change 809221 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Structured task: Add 'cancel' to the list of allowed commands

https://gerrit.wikimedia.org/r/809221

Maintenance_bot removed a project: Patch-For-Review.Jun 28 2022, 6:30 PM

Change 809549 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.17] Structured task: Add 'cancel' to the list of allowed commands

https://gerrit.wikimedia.org/r/809549

Change 809550 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.18] Structured task: Add 'cancel' to the list of allowed commands

https://gerrit.wikimedia.org/r/809550

Added to our incident tracking (https://www.mediawiki.org/wiki/Growth/Engineering/Incident_tracking), cc @MShilova_WMF

Change 809550 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.18] Structured task: Add 'cancel' to the list of allowed commands

https://gerrit.wikimedia.org/r/809550

Mentioned in SAL (#wikimedia-operations) [2022-06-29T20:32:29Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.18/extensions/GrowthExperiments/modules/ext.growthExperiments.StructuredTask/TargetInitializer.js: Backport: [[gerrit:809550|Structured task: Add 'cancel' to the list of allowed commands (T311467)]] (duration: 03m 37s)

Change 809549 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.17] Structured task: Add 'cancel' to the list of allowed commands

Reason:

didn't get done in the backport window, but the wmf.18 patch did, so abandoning this one

https://gerrit.wikimedia.org/r/809549

Maintenance_bot removed a project: Patch-For-Review.Jun 30 2022, 12:30 PM

• mewoph removed • mewoph as the assignee of this task.Jul 1 2022, 4:41 PM

Checked in wmf.18 - the issue is fixed.

This seems to be broken again for me locally, but looks OK in wmf.19.

False alarm, I didn't run git submodule update in VE.

Change 811919 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] selenium: Verify that close button exists on mobile

https://gerrit.wikimedia.org/r/811919

gerritbot added a project: Patch-For-Review.Jul 7 2022, 9:24 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 11 2022, 8:02 PM

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.18; 2022-06-27); removed MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 11 2022, 9:02 PM

Change 811919 merged by jenkins-bot: