Wikitext preview re-renders article preview at the wrong width
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	sgrabarczuk
	Jul 13 2022, 4:14 PM

Description

Steps to replicate the issue (include links if applicable):

Go to this page
Open the page in the old (2010) wikitext editor
Don't edit anything, just preview the page

What happens?:
The content area is narrower than in the viewing mode. This impacts what the content looks like. For instance, the images in the gallery appear in a sequence 1-1-2, while in the viewing mode, it's 1-2-1.

I've tried to replicate this on Russian Wikipedia - with the same result. The content area was narrower in the preview.

View (reading)	Preview

What should have happened instead?:
The content area width should be the same as in the viewing mode

Other information (browser name/version, screenshots, etc.): Firefox 102

Developer notes

Looks like the rule in https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/1a2b6d59a547ce0c395f28226bdd85539396b33a/skinStyles/mediawiki.action.edit.less#4 needs updating

Article is currently rendering at 944px, not 840px.

This rule does look like a bit of a hack, but there is no way to programmatically switch a page from having a max-width applied to not having a max-width applied.

Details

	Subject	Repo	Branch	Lines +/-
	Set width of preview to match reading	mediawiki/skins/Vector	master	+12 -1

Customize query in gerrit

Related Objects

Mentioned In: T319447: [M] Create user preference to turn fixed width on and off
T322337: Using the Vector (2022) theme in conjunction with the realtime preview beta feature makes the font size of the live preview too large.
T321883: Font size too large when editing & previewing using Vector-2022
T321728: Preview font size has increased in Vector 2022
T317945: Vector 2022: category previewed at the wrong width
Mentioned Here: T310309: VE opens at full-width in Vector (2022) in some situations
T322337: Using the Vector (2022) theme in conjunction with the realtime preview beta feature makes the font size of the live preview too large.
T321728: Preview font size has increased in Vector 2022
T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022

Event Timeline

sgrabarczuk created this task.Jul 13 2022, 4:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2022, 4:14 PM

Tagging community tech as they last touched this in T307725.

ppelberg subscribed.Aug 9 2022, 10:33 PM

Both are set to 60em, but one is at 16px font size and the preview is at 14px, hence the difference. Using rem might help, although take care to test in our various supported skins (monobook + vector + vector-2022).

I'm not sure we touched the piece regarding the font size changes and the details in the developer notes seem to confirm otherwise. Tagging @Samwilson for a second pair of more technical eyes

• NRodriguez moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Aug 15 2022, 4:48 PM

• JMcLeod_WMF set the point value for this task to 3.Aug 17 2022, 11:10 AM

• JMcLeod_WMF moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.Aug 17 2022, 7:11 PM

• NRodriguez edited projects, added Community-Tech (CommTech-Sprint-31); removed Community-Tech.Aug 17 2022, 7:14 PM

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-32); removed Community-Tech (CommTech-Sprint-31).Aug 29 2022, 2:30 PM

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-33); removed Community-Tech (CommTech-Sprint-32).Sep 12 2022, 3:00 PM

Una_tantum mentioned this in T317945: Vector 2022: category previewed at the wrong width.Sep 16 2022, 9:04 AM

Although we didn't touch the font sizes, we did change the width and we based it on font size so I think it makes sense for us to fix this too. The difference in font sizes should be fixed, I assume? It doesn't make sense for the preview to be a different size to the final display.

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-34); removed Community-Tech (CommTech-Sprint-33).Sep 26 2022, 8:27 PM

• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-34) board.Sep 26 2022, 8:36 PM

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-35); removed Community-Tech (CommTech-Sprint-34).Oct 11 2022, 10:27 AM

• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-35) board.Oct 11 2022, 10:33 AM

Change 843603 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/skins/Vector@master] Set width of preview to match reading

https://gerrit.wikimedia.org/r/843603

gerritbot added a project: Patch-For-Review.Oct 18 2022, 5:30 AM

Samwilson moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-35) board.Oct 19 2022, 6:06 AM

TheresNoTime moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-35) board.Oct 19 2022, 2:13 PM

Change 843603 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Set width of preview to match reading

https://gerrit.wikimedia.org/r/843603

Maintenance_bot removed a project: Patch-For-Review.Oct 19 2022, 2:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 19 2022, 3:00 PM

Possibly related to this: T321728: Preview font size has increased in Vector 2022

TheresNoTime mentioned this in T321728: Preview font size has increased in Vector 2022.Oct 27 2022, 8:29 AM

Zdzislaw mentioned this in T321883: Font size too large when editing & previewing using Vector-2022.Oct 30 2022, 11:23 AM

In Sprint planning, we decided we wanted this as a fix before we graduate Realtime preview to a preview to all

InsaneHacker mentioned this in T322337: Using the Vector (2022) theme in conjunction with the realtime preview beta feature makes the font size of the live preview too large..Nov 3 2022, 9:14 PM

@NRodriguez In the RTL today, we decided that there wasn't much point continuing to test this. The original bug cannot be reproduced (due to changes in Vector 2022?). The time would be better spent testing the fixes for T322337, T321728 and (possibly) T310309 which will also include testing whether this bug still exists.

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-36); removed Community-Tech (CommTech-Sprint-35).Nov 7 2022, 10:12 PM

• JMcLeod_WMF moved this task from Ready 🎬 to Done 🏁 on the Community-Tech (CommTech-Sprint-36) board.

Jdlrobson mentioned this in T319447: [M] Create user preference to turn fixed width on and off.Nov 29 2022, 10:27 PM

Wikitext preview re-renders article preview at the wrong widthClosed, ResolvedPublic3 Estimated Story PointsBUG REPORTActions