Page MenuHomePhabricator

Coordinates in Structured Data cannot be removed nor edited
Open, Needs TriagePublicBUG REPORT

Description

Coordinates stored in StructuredData cannot be edited/deleted for some files by some users.

User experience:
Attempt 1:

  1. open a file page at Commons with coordinates e.g. (https://commons.wikimedia.org/wiki/File:Overview_of_road_in_Keblov,_Bene%C5%A1ov_District.jpg).
  2. click to the "Structured data" tab to display Structured Data of the file
  3. scroll down to find "coordinates of the point of view" statement and click "Edit"
  4. click the "Remove" icon beside the wrong coordinates.
  5. The coordinates disappear, but the button "Publish changes" remains gray, not active. It is is not possible to confirm and save the change.
  6. After refreshing the page, the coordinates are still there, no edit was made.

Attempt 2:

  1. same as above, but click "Remove all" at the bottom instead of "Remove"
  2. A message window "Remove all?" appears, confirm by clicking on the "Remove" button.
  3. dialogue window and coordinates disappeared, as well as the line with "Publish changes" and "Cancel" buttons.
  4. After refreshing the page, the coordinates are still there, no edit was made.

Attempts to remove coordinates were unsuccessful. In both attempts, it seemed as if the coordinates were successfully deleted. However, not edit was actually done, and coordinates re-appeared after refreshing the page. Similar issues have been reported when trying tying to edit coordinates instead of removing them.

Steps to replicate the issue:
The problem is difficult to replicate, as it does not affect all files nor all users.

According to @Etonkovidova in comment T313638#8262660, this is the most reliable way to replicate the behavior:

  1. Add coordinates of the point of view statement to an image file and publish it.
  2. Click on Edit, then click on the red trash bin icon to remove the statement. The Publish changes button should be active (blue) - all works as expected. Do not click on Publish changes.
  3. Add Network throttling and go to a random page - wait when a page will load.
  4. Return to the image page where coordinates were added - wait when it loads, click on Structured data tab - wait when it loads, i.e. the map will be fully displayed.
  5. Repeat step #2 - the *Publish changes button will be grey and Cancel** is not functioning.
Non-functioning controls - step 5after clicking on Remove all
Screen Shot 2022-09-26 at 2.17.21 PM.png (708×1 px, 88 KB)
Screen Shot 2022-09-26 at 2.17.34 PM.png (448×1 px, 56 KB)

Here is a screen recording - https://drive.google.com/file/d/1Kg42jCaSHFZfjgudqlVRtrQllfx7ZUpu/view?usp=sharing - illustrating the scenarios in the task description.

Other information:

  • The issue is browser-independent
  • The issue is not dependent on the chosen UI language, but switching to another language does help.
  • switching the skin may help
  • editing other statements on the same page may help

Event Timeline

From Commons_talk:Structured_data/Reconciliation#Coordinates_of_the_position_cannot_be_changed It seems that all users concerned are non-native English speakers. Note that a temporary workaround is to change your language setting and then delete the coordinates, which seems to work for one image at a time only.

I tested the bug in two languages, cs and en. The behaviour was identical.

@SJu, did switching languages help temporarily?
I'm not a software expert, but my observation (if confirmed) that native English speakers don't seem to be affected might indicate that the bug is somehow related to the way languages are handled.

El_Grafo subscribed.

Confirmed, same happening for me.

Similar behavior is being reported at Commons:Forum (permalink): Existing coordinates cannot be changed (in Firefox) because the "Publish changes" button is greyed out. Switching skins (!) helps temporarily; problem does not exist in Edge.

This issue might be browser-dependent. I can reproduce it with Firefox (currently 104.0.1, Win 10) but not with MS Edge (Version 105.0.1343.27 (Official Build) (64-Bit)) or Google Chrome (Version 105.0.5195.102 (Official Build) (64-Bit).

El_Grafo renamed this task from Coordinates cannot be removed from the Structured Data to Coordinates in Structured Data cannot be removed from or changed .Sep 21 2022, 1:36 PM
El_Grafo moved this task from Incoming to MediaWiki Interface and i18n on the Commons board.

the solution for this (allow the deletion of false coordinates) is only half way. In principle the bot copied it, the bot shall keep it in sync without user intervention.

the solution for this (allow the deletion of false coordinates) is only half way. In principle the bot copied it, the bot shall keep it in sync without user intervention.

True, but that's a separate issue that needs to be discussed elsewhere, with the bot operator. Nothing MediaWiki/SDC developers can do anything about. I have cleaned up the bug description above to focus it on the technical issues this task is about.

I feel like we're missing some essential tags on this ticket as it has gotten zero response so far. What's missing?

Meanwhile, the issue persists (Firefox again).

Thank you, @SJu for filing the issue!
Both scenarios of the issue are reproducible in production (commons wmf.2) and in commons betalabs. However, the issue is really tricky to reproduce - in all cases that I tried, the issue gets self-resolved after reloading the page or navigating away and returning back.

The issue is not specific to a browser or UI language, but it seems to be specific to the coordinates statement. Also, the amount of time spent on a page and any actions that were performed on the page (editing other statements) will make removal of coordinates statement work as expected.

The scenario that works most reliably for reproducing the issue:

  1. Add coordinates of the point of view statement to an image file and publish it.
  2. Click on Edit, then click on the red trash bin icon to remove the statement. The Publish changes button should be active (blue) - all works as expected. Do not click on Publish changes.
  3. Add Network throttling and go to a random page - wait when a page will load.
  4. Return to the image page where coordinates were added - wait when it loads, click on Structured data tab - wait when it loads, i.e. the map will be fully displayed.
  5. Repeat step #2 - the *Publish changes button will be grey and Cancel** is not functioning.
Non-functioning controls - step 5after clicking on Remove all
Screen Shot 2022-09-26 at 2.17.21 PM.png (708×1 px, 88 KB)
Screen Shot 2022-09-26 at 2.17.34 PM.png (448×1 px, 56 KB)

Here is a screen recording - https://drive.google.com/file/d/1Kg42jCaSHFZfjgudqlVRtrQllfx7ZUpu/view?usp=sharing - illustrating the scenarios in the task description.

El_Grafo renamed this task from Coordinates in Structured Data cannot be removed from or changed to Coordinates in Structured Data cannot be removed nor edited.Oct 9 2023, 9:24 AM
El_Grafo updated the task description. (Show Details)

My method to replicate

Operating system: OS X 14.4.1 (23E224)
Browser: Chrome Version 123.0.6312.123 (Official Build) (arm64)

  1. Open the page . (https://commons.wikimedia.org/wiki/File:Overview_of_road_in_Keblov,_Bene%C5%A1ov_District.jpg).
  2. Use inspect from context menu to open Chrome's debug toolbar.
  3. Select network tab and set slowest possible throtling ("Slow 3G for me")
  4. Reload the page using debug = 1 parameter so the assets such as scripts will be force reloaded https://commons.wikimedia.org/wiki/File:Overview_of_road_in_Keblov,_Bene%C5%A1ov_District.jpg?debug=1
  5. Wait until page is loaded, click on Structured data tab - wait when it loads, i.e. the map will be fully displayed.
  6. The coordinates disappear, but the button "Publish changes" remains gray, not active. It is is not possible to confirm and save the change.

There seems no relevant error messages in javascript console. Both throttling and debug = 1 was needed to reliably reproduce it on every reload.

@Zache - thank you for providing additional steps for the issue!
I re-checked on commons wmf.1 - clicking "Remove all" has its own confirmation popup:

Screen Shot 2024-04-22 at 10.13.04 AM.png (828×1 px, 86 KB)
Screen Shot 2024-04-22 at 10.19.32 AM.png (908×1 px, 156 KB)

Since Remove all provides the confirmation popup, it seems that "Publish changes" is not needed to be activated (could be confusing though). Except for the first field Items portrayed in this file all other fields have Remove all.