Page MenuHomePhabricator
Create Task
Maniphest T319087

[1.41] Remove the PersonalUrls hook
Closed, ResolvedPublic
Actions

Description

In T310017 we deprecated this hook in favor of SkinTemplateNavigation::Universal. We are now hoping to remove this code altogether in MediaWiki 1.41

Migration for this one is relatively simple - you should be able to switch out the use of PersonalUrls with SkinTemplateNavigation::Universal (modifying the 'user-menu' key of the $links parameter instead
Example: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SandboxLink/+/830215

Impacts the following extensions, your help is appreciated!

https://codesearch.wmcloud.org/search/?q=%22PersonalUrls%22&i=nope&files=&excludeFiles=&repos=

Please ignore the following:

Help needed:

  • Can't find appropriate project tag for TuleapIntegration
  • UnifiedTaskOverview - part of BlueSpice - I presume BlueSpice tag is efficient but please help communicate to that project
  • Please untag project from this task's tags once it has been fixed.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedJdlrobsonT319087 [1.41] Remove the PersonalUrls hook
 ResolvedBUG REPORTcicaleseT318213 PersonalUrls hook is deprecated

Event Timeline

Jdlrobson created this task.Oct 1 2022, 12:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2022, 12:00 AM
Jdlrobson updated the task description. (Show Details)Oct 1 2022, 12:01 AM
Jdlrobson mentioned this in T310017: Deprecate PersonalUrls hook.Oct 1 2022, 12:03 AM
Jdlrobson moved this task from Backlog to It's not a priority on the MediaWiki-Core-Skin-Architecture board.
Samwilson added a subtask: T318213: PersonalUrls hook is deprecated.Oct 1 2022, 2:20 AM
cicalese closed subtask T318213: PersonalUrls hook is deprecated as Resolved.Oct 3 2022, 4:16 PM
cicalese removed a project: MediaWiki-extensions-Pluggable-Auth.
xSavitar mentioned this in T323431: [maintenance] PersonalUrls deprecated in 1.39.Nov 19 2022, 10:07 AM
gerritbot added a comment.Nov 19 2022, 10:55 AM

Change 858680 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/Realnames@master] WE-140: Make repo 1.39 compliant and improve code

https://gerrit.wikimedia.org/r/858680

gerritbot added a project: Patch-For-Review.Nov 19 2022, 10:55 AM
gerritbot added a comment.Dec 13 2022, 10:37 PM

Change 858680 merged by jenkins-bot:

[mediawiki/extensions/Realnames@master] WE-140: Make repo 1.39 compliant and improve code

https://gerrit.wikimedia.org/r/858680

xSavitar mentioned this in rERNMe6b480ca71f6: WE-140: Make repo 1.39 compliant and improve code.Dec 13 2022, 10:37 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 13 2022, 11:30 PM
gerritbot added a comment.Dec 28 2022, 6:54 AM

Change 872945 had a related patch set uploaded (by Karima Rafes; author: Karima Rafes):

[mediawiki/extensions/NetworkAuth@master] * Remove the PersonalUrls hook T319087 (cc T325747)

https://gerrit.wikimedia.org/r/872945

gerritbot added a project: Patch-For-Review.Dec 28 2022, 6:54 AM
gerritbot added a comment.Dec 29 2022, 10:39 AM

Change 873491 had a related patch set uploaded (by WgevaertWikiBase; author: WgevaertWikiBase):

[mediawiki/extensions/DisplayTitle@master] Change PersonalUrls hook to SkinTemplateNavigation::Universal hook

https://gerrit.wikimedia.org/r/873491

gerritbot added a comment.Jan 11 2023, 12:18 AM

Change 873491 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@master] Change PersonalUrls hook to SkinTemplateNavigation::Universal hook

https://gerrit.wikimedia.org/r/873491

cicalese mentioned this in rEDPT175655f678d2: Change PersonalUrls hook to SkinTemplateNavigation::Universal hook.Jan 11 2023, 12:19 AM
CCicalese_WMF removed a project: MediaWiki-extensions-DisplayTitle.Jan 11 2023, 12:36 AM
gerritbot added a comment.Jan 25 2023, 4:21 PM

Change 883609 had a related patch set uploaded (by Brian Wolff; author: Derick Alangi):

[mediawiki/extensions/Realnames@REL1_39] WE-140: Make repo 1.39 compliant and improve code

https://gerrit.wikimedia.org/r/883609

gerritbot added a comment.Jan 25 2023, 4:45 PM

Change 883609 merged by Brian Wolff:

[mediawiki/extensions/Realnames@REL1_39] WE-140: Make repo 1.39 compliant and improve code

https://gerrit.wikimedia.org/r/883609

Bawolff mentioned this in rERNMb65c86201853: WE-140: Make repo 1.39 compliant and improve code.Jan 25 2023, 4:57 PM
Yaron_Koren moved this task from Backlog to Already fixed for AR on the MediaWiki-extensions-Approved-Revs board.Feb 1 2023, 6:42 PM
gerritbot added a comment.Feb 5 2023, 2:04 PM

Change 886418 had a related patch set uploaded (by Cicalese; author: WgevaertWikiBase):

[mediawiki/extensions/DisplayTitle@REL1_39] Change PersonalUrls hook to SkinTemplateNavigation::Universal hook

https://gerrit.wikimedia.org/r/886418

gerritbot added a comment.Feb 5 2023, 2:09 PM

Change 886418 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@REL1_39] Change PersonalUrls hook to SkinTemplateNavigation::Universal hook

https://gerrit.wikimedia.org/r/886418

CCicalese_WMF mentioned this in rEDPT6f6c3e0a053e: Change PersonalUrls hook to SkinTemplateNavigation::Universal hook.Feb 5 2023, 3:50 PM
Kizule removed projects: Patch-For-Review, MediaWiki-extensions-Realnames.Feb 5 2023, 4:17 PM
Kizule subscribed.
Kizule unsubscribed.Feb 5 2023, 4:27 PM
gerritbot added a comment.May 13 2023, 8:23 AM

Change 919430 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/NetworkAuth@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919430

gerritbot added a project: Patch-For-Review.May 13 2023, 8:23 AM
gerritbot added a comment.May 13 2023, 8:30 AM

Change 919431 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/OpenID@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919431

gerritbot added a comment.May 13 2023, 8:33 AM

Change 919432 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Sudo@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919432

gerritbot added a comment.May 13 2023, 8:37 AM

Change 919433 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WebToolsManager@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919433

gerritbot added a comment.May 13 2023, 8:43 AM

Change 919434 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AddPersonalUrls@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919434

gerritbot added a comment.May 13 2023, 8:52 AM

Change 919435 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/OAuthAuthentication@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919435

gerritbot added a comment.May 13 2023, 8:53 AM

Change 919436 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Favorites@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919436

gerritbot added a comment.May 13 2023, 8:57 AM

Change 919437 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SiteSettings@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919437

gerritbot added a comment.May 13 2023, 9:04 AM

Change 919438 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/OnlineStatus@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919438

gerritbot added a comment.May 13 2023, 9:07 AM

Change 919439 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Auth_remoteuser@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919439

gerritbot added a comment.May 15 2023, 1:42 PM

Change 919434 merged by jenkins-bot:

[mediawiki/extensions/AddPersonalUrls@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919434

gerritbot added a comment.May 15 2023, 1:42 PM

Change 919437 merged by jenkins-bot:

[mediawiki/extensions/SiteSettings@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919437

Umherirrender mentioned this in rEAPUb50942a9b7a6: Replace deprecated PersonalUrls hook.May 15 2023, 1:43 PM
gerritbot added a comment.May 15 2023, 1:45 PM

Change 919432 merged by jenkins-bot:

[mediawiki/extensions/Sudo@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919432

gerritbot added a comment.May 15 2023, 1:48 PM

Change 919430 merged by jenkins-bot:

[mediawiki/extensions/NetworkAuth@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919430

gerritbot added a comment.May 15 2023, 1:48 PM

Change 919438 merged by jenkins-bot:

[mediawiki/extensions/OnlineStatus@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919438

Umherirrender mentioned this in rENAU3cb09efc525a: Replace deprecated PersonalUrls hook.May 15 2023, 2:33 PM
gerritbot added a comment.May 15 2023, 2:42 PM

Change 919433 merged by jenkins-bot:

[mediawiki/extensions/WebToolsManager@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919433

Umherirrender mentioned this in rEWTMb7e5b8599bd6: Replace deprecated PersonalUrls hook.May 15 2023, 2:46 PM
gerritbot added a comment.May 15 2023, 5:02 PM

Change 919435 merged by Umherirrender:

[mediawiki/extensions/OAuthAuthentication@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919435

gerritbot added a comment.May 15 2023, 5:07 PM

Change 919431 merged by Umherirrender:

[mediawiki/extensions/OpenID@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919431

gerritbot added a comment.May 16 2023, 9:26 AM

Change 919436 merged by jenkins-bot:

[mediawiki/extensions/Favorites@master] Replace deprecated PersonalUrls and SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/919436

gerritbot added a comment.May 16 2023, 9:26 AM

Change 919439 merged by jenkins-bot:

[mediawiki/extensions/Auth_remoteuser@master] Replace deprecated PersonalUrls hook

https://gerrit.wikimedia.org/r/919439

Jdlrobson moved this task from It's not a priority to 1.40 deprecations/removals on the MediaWiki-Core-Skin-Architecture board.May 25 2023, 2:02 PM
gerritbot added a comment.May 30 2023, 7:21 PM

Change 872945 abandoned by Umherirrender:

[mediawiki/extensions/NetworkAuth@master] * Remove the PersonalUrls hook T319087 (cc T325747)

Reason:

Was done in Iefdac61e4394b7a3e612b8f940e38e52f0a9b7e2

https://gerrit.wikimedia.org/r/872945

Maintenance_bot removed a project: Patch-For-Review.May 30 2023, 7:30 PM
Jdlrobson edited projects, added patch-welcome, MW-1.41-release; removed MediaWiki-extensions-WebToolsManager, MediaWiki-extensions-Sudo, MediaWiki-extensions-Site_Settings, MediaWiki-extensions-OAuthAuthentication, MediaWiki-extensions-NetworkAuth, BlueSpice, MediaWiki-extensions-Approved-Revs.Jun 14 2023, 9:22 PM
Jdlrobson triaged this task as High priority.Jun 14 2023, 9:24 PM
Reedy moved this task from Blocker to To deprecate or remove on the MW-1.41-release board.Aug 26 2023, 6:32 PM
gerritbot added a comment.Sep 21 2023, 6:44 PM

Change 959839 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Drop the PersonalUrls hook, deprecated in 1.39

https://gerrit.wikimedia.org/r/959839

gerritbot added a project: Patch-For-Review.Sep 21 2023, 6:44 PM
gerritbot added a comment.Sep 21 2023, 7:11 PM

Change 959839 merged by jenkins-bot:

[mediawiki/core@master] Drop the PersonalUrls hook, deprecated in 1.39

https://gerrit.wikimedia.org/r/959839

Jdlrobson closed this task as Resolved.Sep 21 2023, 7:14 PM
Jdlrobson claimed this task.
Jdlrobson added a subscriber: Jdforrester-WMF.

Thanks @Jdforrester-WMF !

Maintenance_bot removed a project: Patch-For-Review.Sep 21 2023, 7:32 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 21 2023, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL