Page MenuHomePhabricator
Create Task
Maniphest T310017

Deprecate PersonalUrls hook
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Jdlrobson
Authored By
Jdlrobson
Jun 6 2022, 7:31 PM
Tags
Referenced Files
None
Subscribers
Aklapper
cjming
Jdlrobson
• Mabualruz
Nikerabbit

Description

We are targeting having a single hook for modifying menus: SkinTemplateNavigation::Universal

Since 1.36 we've been encouraging use of SkinTemplateNavigation::Universal instead of PersonalUrls hook.

It's a good time now to move over all remaining usages and deprecate this method.

TODO

  • Update remaining usages in Wikimedia deployed extensions
  • Using the PersonalUrls hook should send deprecation warnings.

sign off steps

Details

SubjectRepoBranchLines +/-
Replace deprecated hook PersonalUrlsmediawiki/extensions/ConfirmAccountREL1_39+5 -6
Deprecate PersonalUrls hookmediawiki/extensions/LiquidThreadsREL1_39+9 -6
Deprecate PersonalUrls hookmediawiki/extensions/LiquidThreadswmf/1.39.0-wmf.28+9 -6
Deprecate PersonalUrls hookmediawiki/skins/CologneBlueREL1_39+6 -16
Deprecate PersonalUrls hookmediawiki/extensions/GrowthExperimentsREL1_39+25 -21
Deprecate PersonalUrls hookmediawiki/coreREL1_39+5 -1
PersonalUrls hook is deprecatedmediawiki/skins/MirageREL1_39+19 -20
PersonalUrls hook is deprecatedmediawiki/skins/Miragemaster+19 -20
Replace PersonalUrlsHook by SkinTemplateNavigation__UniversalHookmediawiki/extensions/DarkModeREL1_39+13 -12
Replace deprecated PersonalUrlsHookmediawiki/extensions/AdminLinksREL1_39+13 -17
Replace deprecated PersonalUrlsHookmediawiki/extensions/AdminLinksmaster+13 -17
Replace PersonalUrlsHook by SkinTemplateNavigation__UniversalHookmediawiki/extensions/DarkModemaster+13 -12
Replace deprecated hook PersonalUrlsmediawiki/extensions/ConfirmAccountmaster+5 -6
Deprecate PersonalUrls hookmediawiki/extensions/SandboxLinkREL1_39+12 -9
Deprecate PersonalUrls hookmediawiki/extensions/BetaFeaturesREL1_39+14 -11
Deprecate PersonalUrls hookmediawiki/coremaster+5 -1
Deprecate PersonalUrls hookmediawiki/skins/VectorREL1_39+3 -7
Deprecate PersonalUrls hookmediawiki/extensions/GrowthExperimentsmaster+25 -21
Deprecate PersonalUrls hookmediawiki/extensions/UploadsLinkREL1_39+6 -6
Deprecate PersonalUrls hookmediawiki/skins/CologneBluemaster+6 -16
Deprecate PersonalUrls hookmediawiki/skins/Vectormaster+3 -7
Deprecate PersonalUrls hookmediawiki/extensions/UploadsLinkmaster+6 -6
Deprecate PersonalUrls hookmediawiki/skins/CologneBluemaster+6 -16
Deprecate PersonalUrls hookmediawiki/extensions/GrowthExperimentsmaster+18 -21
Deprecate PersonalUrls hookmediawiki/extensions/UploadsLinkmaster+6 -6
Deprecate PersonalUrls hookmediawiki/extensions/LiquidThreadsmaster+9 -6
Deprecate PersonalUrls hookmediawiki/extensions/BetaFeaturesmaster+14 -11
Deprecate PersonalUrls hookmediawiki/extensions/SandboxLinkmaster+12 -9
Deprecate PersonalUrls hookmediawiki/extensions/Wikibasemaster+17 -16
Deprecate PersonalUrls hookmediawiki/extensions/Wikibasemaster+17 -16
Deprecate PersonalUrls hookmediawiki/extensions/BetaFeaturesmaster+12 -11
Deprecate PersonalUrls hookmediawiki/extensions/GrowthExperimentsmaster+23 -34
eprecate PersonalUrls hookmediawiki/skins/CologneBluemaster+6 -5
Deprecate PersonalUrls hookmediawiki/coremaster+22 -15
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Sep 6 2022, 4:56 PM

Change 830215 had a related patch set uploaded (by Jdlrobson; author: Mabualruz):

[mediawiki/extensions/SandboxLink@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830215

gerritbot added a comment.Sep 6 2022, 4:57 PM

Change 830216 had a related patch set uploaded (by Jdlrobson; author: Mabualruz):

[mediawiki/extensions/BetaFeatures@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830216

• Mabualruz moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 6 2022, 5:08 PM
gerritbot added a comment.Sep 6 2022, 5:15 PM

Change 829157 merged by jenkins-bot:

[mediawiki/extensions/SandboxLink@master] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/829157

gerritbot added a comment.Sep 6 2022, 5:17 PM

Change 829225 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/829225

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 6 2022, 6:00 PM
gerritbot added a comment.Sep 6 2022, 9:49 PM

Change 830274 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830274

gerritbot added a comment.Sep 6 2022, 11:03 PM

Change 829156 merged by Jdlrobson:

[mediawiki/extensions/LiquidThreads@master] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/829156

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 6 2022, 11:34 PM
gerritbot added a comment.Sep 7 2022, 3:01 PM

Change 829158 abandoned by Mabualruz:

[mediawiki/extensions/UploadsLink@master] Deprecate PersonalUrls hook

Reason:

https://gerrit.wikimedia.org/r/829158

gerritbot added a comment.Sep 7 2022, 3:01 PM

Change 830652 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/UploadsLink@master] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830652

gerritbot added a comment.Sep 7 2022, 3:17 PM

Change 830655 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/GrowthExperiments@master] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830655

gerritbot added a comment.Sep 7 2022, 3:18 PM

Change 828572 abandoned by Mabualruz:

[mediawiki/extensions/GrowthExperiments@master] Deprecate PersonalUrls hook

Reason:

https://gerrit.wikimedia.org/r/828572

gerritbot added a comment.Sep 7 2022, 3:31 PM

Change 830274 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830274

gerritbot added a comment.Sep 7 2022, 3:31 PM

Change 830652 merged by jenkins-bot:

[mediawiki/extensions/UploadsLink@master] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830652

Restricted Repository Identity mentioned this in rEULKcc396461761b: Deprecate PersonalUrls hook.Sep 7 2022, 3:37 PM
gerritbot added a comment.Sep 7 2022, 3:40 PM

Change 830660 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/CologneBlue@master] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830660

gerritbot added a comment.Sep 7 2022, 3:42 PM

Change 829166 abandoned by Mabualruz:

[mediawiki/skins/CologneBlue@master] Deprecate PersonalUrls hook

Reason:

https://gerrit.wikimedia.org/r/829166

Klein subscribed.Sep 7 2022, 3:50 PM
Klein unsubscribed.
gerritbot added a comment.Sep 7 2022, 3:56 PM

Change 830660 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@master] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830660

Jdlrobson moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 8 2022, 5:04 PM
Jdlrobson claimed this task.Sep 8 2022, 5:14 PM
Jdlrobson added a subscriber: • Mabualruz.
LGoto set the point value for this task to 3.Sep 8 2022, 5:19 PM
gerritbot added a comment.Sep 8 2022, 9:02 PM

Change 830823 had a related patch set uploaded (by Jdlrobson; author: Mabualruz):

[mediawiki/extensions/UploadsLink@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830823

gerritbot added a comment.Sep 8 2022, 9:04 PM

Change 830823 merged by jenkins-bot:

[mediawiki/extensions/UploadsLink@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830823

gerritbot added a comment.Sep 8 2022, 9:04 PM

Change 830824 had a related patch set uploaded (by Jdlrobson; author: Mabualruz):

[mediawiki/core@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830824

Jdlrobson removed Jdlrobson as the assignee of this task.Sep 8 2022, 9:04 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
Jdlrobson mentioned this in rEULK8a67d53e8a8e: Deprecate PersonalUrls hook.Sep 8 2022, 9:06 PM
gerritbot added a comment.Sep 8 2022, 9:23 PM

Change 830655 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830655

gerritbot added a comment.Sep 8 2022, 9:23 PM

Change 828573 merged by jenkins-bot:

[mediawiki/core@master] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/828573

gerritbot added a comment.Sep 8 2022, 9:27 PM

Change 830825 had a related patch set uploaded (by Jdlrobson; author: Mabualruz):

[mediawiki/skins/Vector@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830825

gerritbot added a comment.Sep 8 2022, 9:29 PM

Change 830825 merged by jenkins-bot:

[mediawiki/skins/Vector@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830825

Jdlrobson claimed this task.Sep 9 2022, 9:32 PM
gerritbot added a comment.Sep 9 2022, 9:32 PM

Change 830216 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830216

gerritbot added a comment.Sep 9 2022, 9:32 PM

Change 830215 merged by jenkins-bot:

[mediawiki/extensions/SandboxLink@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830215

gerritbot added a comment.Sep 9 2022, 10:22 PM

Change 831157 had a related patch set uploaded (by Seb35; author: Seb35):

[mediawiki/extensions/ConfirmAccount@master] Replace deprecated hook PersonalUrls

https://gerrit.wikimedia.org/r/831157

gerritbot added a comment.Sep 9 2022, 11:19 PM

Change 831157 merged by jenkins-bot:

[mediawiki/extensions/ConfirmAccount@master] Replace deprecated hook PersonalUrls

https://gerrit.wikimedia.org/r/831157

Seb35 mentioned this in rECAC21214092ba1b: Replace deprecated hook PersonalUrls.Sep 9 2022, 11:22 PM
gerritbot added a comment.Sep 11 2022, 6:53 PM

Change 831234 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/DarkMode@master] Replace PersonalUrlsHook by SkinTemplateNavigation__UniversalHook

https://gerrit.wikimedia.org/r/831234

gerritbot added a comment.Sep 12 2022, 7:10 PM

Change 831612 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/AdminLinks@master] Replace deprecated PersonalUrlsHook

https://gerrit.wikimedia.org/r/831612

gerritbot added a comment.Sep 13 2022, 12:29 AM

Change 831234 merged by jenkins-bot:

[mediawiki/extensions/DarkMode@master] Replace PersonalUrlsHook by SkinTemplateNavigation__UniversalHook

https://gerrit.wikimedia.org/r/831234

Fomafix mentioned this in rEDKM8963827c1346: Replace PersonalUrlsHook by SkinTemplateNavigation__UniversalHook.Sep 13 2022, 12:30 AM
gerritbot added a comment.Sep 13 2022, 12:36 AM

Change 831612 merged by jenkins-bot:

[mediawiki/extensions/AdminLinks@master] Replace deprecated PersonalUrlsHook

https://gerrit.wikimedia.org/r/831612

Jdlrobson moved this task from Ready for Signoff to Blocked on Others on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 13 2022, 12:46 AM

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/830824 is not merging. Blocked on T317592

Jdlrobson added a subtask: T317592: PHPUnit test failure blocking merges in REL1_39 (testTemplateCategories and testNewRevisionsFromBatch_archive).Sep 13 2022, 12:47 AM
Fomafix mentioned this in rEADL8b7c217bfdd7: Replace deprecated PersonalUrlsHook.Sep 13 2022, 1:21 AM
gerritbot added a comment.Sep 13 2022, 1:29 AM

Change 831559 had a related patch set uploaded (by Universal Omega; author: Fomafix):

[mediawiki/extensions/DarkMode@REL1_39] Replace PersonalUrlsHook by SkinTemplateNavigation__UniversalHook

https://gerrit.wikimedia.org/r/831559

Universal_Omega added a subtask: T317588: AdminLinks uses the PersonalUrls hook, deprecated in MediaWiki 1.39.Sep 13 2022, 1:31 AM
Universal_Omega closed subtask T317588: AdminLinks uses the PersonalUrls hook, deprecated in MediaWiki 1.39 as Resolved.Sep 13 2022, 1:33 AM
gerritbot added a comment.Sep 13 2022, 1:34 AM

Change 831560 had a related patch set uploaded (by Universal Omega; author: Fomafix):

[mediawiki/extensions/AdminLinks@REL1_39] Replace deprecated PersonalUrlsHook

https://gerrit.wikimedia.org/r/831560

gerritbot added a comment.Sep 13 2022, 1:47 AM

Change 831560 merged by jenkins-bot:

[mediawiki/extensions/AdminLinks@REL1_39] Replace deprecated PersonalUrlsHook

https://gerrit.wikimedia.org/r/831560

Universal_Omega mentioned this in rEADL58121dbdf895: Replace deprecated PersonalUrlsHook.Sep 13 2022, 1:48 AM
gerritbot added a comment.Sep 13 2022, 3:12 PM

Change 831559 merged by jenkins-bot:

[mediawiki/extensions/DarkMode@REL1_39] Replace PersonalUrlsHook by SkinTemplateNavigation__UniversalHook

https://gerrit.wikimedia.org/r/831559

Universal_Omega mentioned this in rEDKM760030911a10: Replace PersonalUrlsHook by SkinTemplateNavigation__UniversalHook.Sep 13 2022, 3:13 PM
Jdlrobson lowered the priority of this task from High to Low.Sep 13 2022, 5:13 PM
Nikerabbit added a project: affects-translatewiki.net.Sep 14 2022, 1:31 PM
Nikerabbit subscribed.

We got a flood of deprecation warnings during translatewiki.net deployment.

I'd like to draw the attention to the stable interface policy which says:

Developers or teams deprecating code SHOULD actively support removal of usages in code in the MediaWiki ecosystem, especially in popular extensions. This includes making maintainers aware of the deprecation as well as creating or reviewing patches removing usages.

I don't see any report for SMW about this in https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues?q=PersonalUrls even though the use of this hook is easy to see using the CodeSearch tool.

The translatewiki.net deployers will appreciate if this can be avoided in the future for smoother deployments.

Jdlrobson added a comment.Sep 14 2022, 3:43 PM

@Nikerabbit the stable policy says:

Usage of deprecated code is considered more or less problematic depending on where it occurs: the most critical usages are within the same repository, followed by Wikimedia maintained code, further followed by code in the MediaWiki ecosystem. Usages outside the ecosystem are considered the least relevant.

Our priorities thus are:

Work here is still ongoing.
The problem with 2, is many of the repos in codesearch are not maintained (I've been raising tickets about those). That adds unnecessary noise so it makes it harder to know what to prioritize. Also some extension/skins are optimized for older releases, so often when issues/patches are raised they are stalled for some time (Scratchwiki, Chameleon and Bluespice being certain examples). I've captured this in https://www.mediawiki.org/w/index.php?title=Topic:X34wraaili56q6xy&action=history so we don't go offtopic here.

gerritbot added a comment.Sep 14 2022, 3:47 PM

Change 832284 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Mirage@master] PersonalUrls hook is deprecated

https://gerrit.wikimedia.org/r/832284

Nikerabbit added a comment.Sep 14 2022, 5:35 PM

Thanks! To clarify, I am not expecting you to fix every possible extension and skin yourself. I'd be content just to have issues filed against SMW (which is a recurring pain point for us during deployments) in their issue tracker so that the Language team can help the SMW maintainers to get these resolved before hard deprecation warnings are enabled and before we update translatewiki.net code (we have a weekly deployment schedule currently).

Mainframe98 added a project: MediaWiki-skins-Mirage.Sep 14 2022, 5:45 PM
Mainframe98 moved this task from Backlog to Modernizations and deprecations on the MediaWiki-skins-Mirage board.
gerritbot added a comment.Sep 14 2022, 6:07 PM

Change 832310 had a related patch set uploaded (by Mainframe98; author: Jdlrobson):

[mediawiki/skins/Mirage@REL1_39] PersonalUrls hook is deprecated

https://gerrit.wikimedia.org/r/832310

gerritbot added a comment.Sep 14 2022, 6:13 PM

Change 832284 merged by jenkins-bot:

[mediawiki/skins/Mirage@master] PersonalUrls hook is deprecated

https://gerrit.wikimedia.org/r/832284

gerritbot added a comment.Sep 14 2022, 6:31 PM

Change 832310 merged by jenkins-bot:

[mediawiki/skins/Mirage@REL1_39] PersonalUrls hook is deprecated

https://gerrit.wikimedia.org/r/832310

gerritbot added a comment.Sep 15 2022, 5:26 AM

Change 830824 merged by Jforrester:

[mediawiki/core@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/830824

ReleaseTaggerBot added a project: MW-1.39-notes.Sep 15 2022, 6:00 AM
Jdlrobson updated the task description. (Show Details)Sep 15 2022, 3:40 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Blocked on Others to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
Jdlrobson updated the task description. (Show Details)
matmarex mentioned this in rEIBX026cc60f4df3: Update for PersonalUrls hook deprecation.Sep 22 2022, 8:27 PM
Jdlrobson mentioned this in T319087: [1.41] Remove the PersonalUrls hook.Oct 1 2022, 12:00 AM
Jdlrobson closed this task as Resolved.Oct 1 2022, 12:03 AM

Next up: https://phabricator.wikimedia.org/T319087

Jdlrobson updated the task description. (Show Details)Oct 1 2022, 12:03 AM
gerritbot added a comment.Oct 29 2022, 6:52 PM

Change 850571 had a related patch set uploaded (by Paladox; author: Mabualruz):

[mediawiki/extensions/GrowthExperiments@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/850571

gerritbot added a comment.Nov 7 2022, 1:22 AM

Change 850571 merged by Gergő Tisza:

[mediawiki/extensions/GrowthExperiments@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/850571

gerritbot added a comment.Dec 5 2022, 1:53 AM

Change 863365 had a related patch set uploaded (by Umherirrender; author: Mabualruz):

[mediawiki/skins/CologneBlue@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/863365

gerritbot added a comment.Dec 5 2022, 1:58 AM

Change 863365 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/863365

gerritbot added a comment.Dec 5 2022, 7:58 AM

Change 864671 had a related patch set uploaded (by Abijeet Patro; author: Mabualruz):

[mediawiki/extensions/LiquidThreads@wmf/1.39.0-wmf.28] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/864671

gerritbot added a comment.Dec 5 2022, 8:11 AM

Change 864674 had a related patch set uploaded (by Abijeet Patro; author: Mabualruz):

[mediawiki/extensions/LiquidThreads@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/864674

gerritbot added a comment.Dec 5 2022, 8:12 AM

Change 864671 abandoned by Abijeet Patro:

[mediawiki/extensions/LiquidThreads@wmf/1.39.0-wmf.28] Deprecate PersonalUrls hook

Reason:

In favor of Ia04efa0b5bc6fbfdeef360d421e4a4342503be4f

https://gerrit.wikimedia.org/r/864671

gerritbot added a comment.Dec 6 2022, 4:18 PM

Change 864674 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@REL1_39] Deprecate PersonalUrls hook

https://gerrit.wikimedia.org/r/864674

gerritbot added a comment.Dec 6 2022, 4:23 PM

Change 864924 had a related patch set uploaded (by Umherirrender; author: Seb35):

[mediawiki/extensions/ConfirmAccount@REL1_39] Replace deprecated hook PersonalUrls

https://gerrit.wikimedia.org/r/864924

gerritbot added a comment.Dec 6 2022, 4:42 PM

Change 864924 merged by jenkins-bot:

[mediawiki/extensions/ConfirmAccount@REL1_39] Replace deprecated hook PersonalUrls

https://gerrit.wikimedia.org/r/864924

Umherirrender mentioned this in rEIBX5a1438d7f95e: Update for PersonalUrls hook deprecation.Dec 6 2022, 4:42 PM
Umherirrender mentioned this in rECACd44d94192b03: Replace deprecated hook PersonalUrls.Dec 6 2022, 5:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits