Page MenuHomePhabricator
Create Task
Maniphest T319396

(Unplanned) Either newcomer homepage or userpage/talk page are not displayed on mobile
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
IZapico-WMF
Oct 5 2022, 10:55 AM
Tags
Referenced Files
F35561516: ezgif.com-gif-maker-3.gif
Oct 10 2022, 9:18 PM
F35561510: Screen Recording 2022-10-07 at 1.56.06 PM.mov.gif
Oct 10 2022, 9:18 PM
F35561508: Screen Recording 2022-10-07 at 1.59.31 PM.mov.gif
Oct 10 2022, 9:18 PM
Subscribers
Aklapper
cjming
Edtadros
IZapico-WMF
Jdlrobson
kostajh
KStoller-WMF
View All 10 Subscribers

Description

Steps to replicate the issue (include links if applicable):

  • Open es.m.wikipedia.org (or other wiki with the Growth features enabled) at a mobile web browser
  • Click on your username
  • You will see either the newcomer homepage (but not the tabs of the userpage nor the talk page) or your userpage and the talk page tab (but not the newcomer homepage tab)

What happens?:

  • By clicking my username, I see my user page and the tab of the talk page. But the mobile newcomer homepage tab is not displayed.
  • If I enable at my configuration "Default to newcomer homepage from username link in personal tools", then after clicking my username I land at the newcomer homepage but the tabs with the userpage and the talk page are not displayed.

What should have happened instead?:

  • By clicking the username, should be displayed the newcomer homepage, userpage and talk page tabs (landing either on the userpage or the newcomer homepage depending on the "Default to newcomer homepage from username link in personal tools" configuration).

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Mobile browsers (at least Chrome and Safari)

QA Results - Prod

ACStatusDetails
1✅T319396#8306023

Details

SubjectRepoBranchLines +/-
Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooksmediawiki/corewmf/1.40.0-wmf.3+17 -18
Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooksmediawiki/corewmf/1.40.0-wmf.4+17 -18
Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooksmediawiki/coremaster+17 -18
Mark menus as supported in Minervamediawiki/skins/MinervaNeuemaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

IZapico-WMF created this task.Oct 5 2022, 10:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2022, 10:55 AM
kostajh triaged this task as High priority.Oct 5 2022, 11:36 AM
kostajh edited projects, added Web-Team-Backlog, Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh subscribed.

Thanks for filing this!

Tagging Web-Team-Backlog as this was probably due to some recent changes around menu refactoring.

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 5 2022, 11:37 AM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q2); removed Web-Team-Backlog.Oct 5 2022, 7:00 PM
Jdlrobson added subscribers: cjming, • Mabualruz.
Jdlrobson set the point value for this task to 1.Oct 5 2022, 7:15 PM
gerritbot added a comment.Oct 5 2022, 8:30 PM

Change 838899 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Mark menus as supported in Minerva

https://gerrit.wikimedia.org/r/838899

gerritbot added a project: Patch-For-Review.Oct 5 2022, 8:30 PM
gerritbot added a comment.Oct 5 2022, 9:25 PM

Change 838899 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Mark menus as supported in Minerva

https://gerrit.wikimedia.org/r/838899

Maintenance_bot removed a project: Patch-For-Review.Oct 5 2022, 9:31 PM
gerritbot added a comment.Oct 5 2022, 9:32 PM

Change 838913 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooks

https://gerrit.wikimedia.org/r/838913

gerritbot added a project: Patch-For-Review.Oct 5 2022, 9:32 PM
Jdlrobson subscribed.Oct 5 2022, 9:34 PM

Looks like this was introduced in 44a93ed3938fffff33c7f927cb40934e51768776 which exposed an issue in the backwards compatibility code which makes it a web team bug. https://gerrit.wikimedia.org/r/838913 is the appropriate fix. Can backport tomorrow if I can get a review in time.

Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.Oct 5 2022, 9:36 PM
Jdlrobson mentioned this in T319480: Add Special:Homepage visual regression test to Pixel.Oct 5 2022, 10:00 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 5 2022, 10:00 PM
gerritbot added a comment.Oct 6 2022, 9:06 AM

Change 838913 merged by Mabualruz:

[mediawiki/core@master] Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooks

https://gerrit.wikimedia.org/r/838913

Maintenance_bot removed a project: Patch-For-Review.Oct 6 2022, 9:30 AM
Jdlrobson claimed this task.Oct 6 2022, 6:06 PM
Jdlrobson moved this task from Code Review to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.
gerritbot added a comment.Oct 6 2022, 6:24 PM

Change 839572 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@wmf/1.40.0-wmf.4] Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooks

https://gerrit.wikimedia.org/r/839572

gerritbot added a project: Patch-For-Review.Oct 6 2022, 6:24 PM
gerritbot added a comment.Oct 6 2022, 8:22 PM

Change 839572 merged by jenkins-bot:

[mediawiki/core@wmf/1.40.0-wmf.4] Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooks

https://gerrit.wikimedia.org/r/839572

Stashbot added a comment.Oct 6 2022, 8:24 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-06T20:24:54Z] <thcipriani@deploy1002> Started scap: Backport for [[gerrit:839572|Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooks (T319396)]]

Stashbot added a comment.Oct 6 2022, 8:25 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-06T20:25:18Z] <thcipriani@deploy1002> thcipriani and jdlrobson: Backport for [[gerrit:839572|Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooks (T319396)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

gerritbot added a comment.Oct 6 2022, 8:26 PM

Change 839577 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@wmf/1.40.0-wmf.3] Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooks

https://gerrit.wikimedia.org/r/839577

Stashbot added a comment.Oct 6 2022, 8:34 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-06T20:34:45Z] <thcipriani@deploy1002> Finished scap: Backport for [[gerrit:839572|Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooks (T319396)]] (duration: 09m 51s)

gerritbot added a comment.Oct 6 2022, 8:59 PM

Change 839577 merged by jenkins-bot:

[mediawiki/core@wmf/1.40.0-wmf.3] Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooks

https://gerrit.wikimedia.org/r/839577

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.3; 2022-09-26); removed MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 6 2022, 9:00 PM
Stashbot added a comment.Oct 6 2022, 9:01 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-06T21:01:51Z] <thcipriani@deploy1002> Started scap: Backport for [[gerrit:839577|Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooks (T319396)]]

Stashbot added a comment.Oct 6 2022, 9:02 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-06T21:02:14Z] <thcipriani@deploy1002> thcipriani and jdlrobson: Backport for [[gerrit:839577|Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooks (T319396)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Oct 6 2022, 9:08 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-06T21:08:00Z] <thcipriani@deploy1002> Finished scap: Backport for [[gerrit:839577|Skin: Map namespaces to associated pages inside runOnSkinTemplateNavigationHooks (T319396)]] (duration: 06m 08s)

Jdlrobson renamed this task from Either newcomer homepage or userpage/talk page are not displayed on mobile to (Unplanned) Either newcomer homepage or userpage/talk page are not displayed on mobile.Oct 6 2022, 9:21 PM
Jdlrobson moved this task from Doing to QA in Prod on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.
Maintenance_bot removed a project: Patch-For-Review.Oct 6 2022, 9:29 PM
KStoller-WMF moved this task from Ready for Development to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 10 2022, 1:37 AM
Trizek-WMF added a project: User-notice.Oct 10 2022, 3:51 PM

Adding User-notice as it could have mobile editors of all kind.

kostajh added a comment.Oct 10 2022, 4:56 PM
In T319396#8305535, @Trizek-WMF wrote:

Adding User-notice as it could have mobile editors of all kind.

@Trizek-WMF what should the user notice say? Something like "the menu system for Special:Homepage did not work properly for one week (September 29 - October 6)" ? It might be kind of confusing for people to read; I am not sure.

Edtadros reassigned this task from Jdlrobson to ovasileva.Oct 10 2022, 9:18 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: eswiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Open es.m.wikipedia.org (or other wiki with the Growth features enabled) at a mobile web browser
Click on your username
✅ AC1: By clicking the username, should be displayed the newcomer homepage, userpage and talk page tabs (landing either on the userpage or the newcomer homepage depending on the "Default to newcomer homepage from username link in personal tools" configuration).

Screen Recording 2022-10-07 at 1.59.31 PM.mov.gif (738×1 px, 380 KB)

Screen Recording 2022-10-07 at 1.56.06 PM.mov.gif (738×1 px, 401 KB)

ezgif.com-gif-maker-3.gif (738×1 px, 409 KB)

Edtadros updated the task description. (Show Details)Oct 10 2022, 9:20 PM
Quiddity subscribed.EditedOct 13 2022, 7:31 PM
In T319396#8305670, @kostajh wrote:

@Trizek-WMF what should the user notice say? Something like "the menu system for Special:Homepage did not work properly for one week (September 29 - October 6)" ? It might be kind of confusing for people to read; I am not sure.

The usual format for entries about resolved-bugs in the "Problems" section of Tech News is variations of "[Last week/etc] there was a problem with [X-feature]. This has now been fixed. [1]"

If I understand this task correctly, an entry for this might be:

Two weeks ago, there was a problem with the userpage tabs on the mobile site not showing correctly. This has now been fixed. [ 1 ]

Please fix/improve that as needed, and either edit directly or let me know, within ~24hours (when it will become frozen for translation). Thanks!

Quiddity added a comment.Oct 14 2022, 8:26 PM

I'm freezing Tech News for translation now, so it would have to appear in the 24 October edition.
I'd hesitantly suggest it doesn't warrant inclusion, as we don't tend to announce things that were briefly broken for small numbers (IIUC) of editors, and especially 3 weeks later. But up to you.

kostajh added a comment.Oct 17 2022, 8:29 AM
In T319396#8317897, @Quiddity wrote:

I'm freezing Tech News for translation now, so it would have to appear in the 24 October edition.
I'd hesitantly suggest it doesn't warrant inclusion, as we don't tend to announce things that were briefly broken for small numbers (IIUC) of editors, and especially 3 weeks later. But up to you.

I'd say let's not include it. @Trizek-WMF if you disagree, please say so.

Aklapper added a project: MediaWiki-Core-Skin-Architecture.Oct 17 2022, 10:36 AM
Trizek-WMF added a comment.Oct 17 2022, 4:57 PM
In T319396#8320109, @kostajh wrote:
In T319396#8317897, @Quiddity wrote:

I'm freezing Tech News for translation now, so it would have to appear in the 24 October edition.
I'd hesitantly suggest it doesn't warrant inclusion, as we don't tend to announce things that were briefly broken for small numbers (IIUC) of editors, and especially 3 weeks later. But up to you.

I'd say let's not include it. @Trizek-WMF if you disagree, please say so.

Both your comments make sense. Let's keep it outside on TN.

Quiddity removed a project: User-notice.Oct 17 2022, 7:09 PM
Quiddity unsubscribed.
ovasileva closed this task as Resolved.Oct 17 2022, 7:53 PM

I think we're all good here, resolving.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits