Description

On the function viewer page, we give users the option of:

"Show name in other languages/hide list" on the function about page (referring to the name of the function)
"Show more languages/hide list" on the function details page (referring to the names of inputs)

These buttons are visible/clickable regardless of is there is anything more to show. We should consider disabling them or just hiding them if clicking them will not change the UI.

Details

	Subject	Repo	Branch	Lines +/-
	Hide the "show more languages" button on the Function Viewer Details tab if there is only one language.	mediawiki/extensions/WikiLambda	master	+100 -10
	Ensure there is not an error in the FunctionViewerSidebar if a type was not set for an argument.	mediawiki/extensions/WikiLambda	master	+12 -8

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	BUG REPORT	None	T344206 Special:MathStatus exception error on Wikifunctions
Open		None	T342865 Post-creation work for wikifunctionswiki
Resolved		BTullis	T289316 Prepare and check storage layer for Wikifunctions.org (new public content wiki)
Resolved		Jdforrester-WMF	T275945 Create Wikifunctions.org
Resolved		Jdforrester-WMF	T299176 Phase Theta – Root task
Resolved		SDunlap	T294388 Run some full end-to-end browser integration tests on Beta Cluster Wikifunctions now it exists
Resolved		SDunlap	T276847 Write a suite of user experience end-to-end integration tests for WikiLambda in selenium/etc. sufficient for us to launch with
Resolved		Teleosteen	T321933 E2E test for CUJ 2: Create a function definition
Resolved		DVrandecic	T318930 CUJ 2: Create a function definition
Resolved		None	T311172 Design review for edit function and view function
Resolved		DVrandecic	T323804 Design: create a function definition
Resolved		Ddwaal	T321399 Don't show / disable the "show more languages" / "Show name in other languages" buttons when there aren't any to show

Event Timeline

• JKieserman created this task.Oct 21 2022, 2:15 PM

gengh moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Oct 24 2022, 6:54 PM

gengh edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

gengh moved this task from Incoming to Ready: G4. Function view on the Abstract Wikipedia team (Phase θ – Throttling) board.

gengh added a project: Design.

@AAlhazwani-WMF What do you think? It seems a nice low hanging fruit, and maybe an appropriate good first task for volunteers.

In "About" page:

Screenshot from 2022-10-24 20-58-21.png (328×405 px, 16 KB)

Screenshot from 2022-10-24 20-59-53.png (300×357 px, 13 KB)

In "Details" page:

Screenshot from 2022-10-24 20-58-28.png (336×328 px, 20 KB)

Screenshot from 2022-10-24 20-58-35.png (338×337 px, 17 KB)

Jdforrester-WMF renamed this task from The "show more languages" / "Show name in other languages" buttons when useless to Don't show / disable the "show more languages" / "Show name in other languages" buttons when there aren't any to show.Nov 7 2022, 8:00 PM

Change 857050 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Ensure there is not an error in the FunctionViewerSidebar if a type was not set for an argument.

https://gerrit.wikimedia.org/r/857050

gerritbot added a project: Patch-For-Review.Nov 15 2022, 8:11 PM

Ddwaal claimed this task.Nov 15 2022, 8:19 PM

Change 857051 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Hide the "show more languages" button on the Function Viewer Details tab if there is only one language.

https://gerrit.wikimedia.org/r/857051

Change 857050 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Ensure there is not an error in the FunctionViewerSidebar if a type was not set for an argument.

https://gerrit.wikimedia.org/r/857050

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 16 2022, 8:00 PM

Change 857051 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Hide the "show more languages" button on the Function Viewer Details tab if there is only one language.

https://gerrit.wikimedia.org/r/857051

Maintenance_bot removed a project: Patch-For-Review.Nov 22 2022, 10:30 AM

Ddwaal moved this task from Ready: G4. Function view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 23 2022, 6:30 PM

AAlhazwani-WMF mentioned this in T323804: Design: create a function definition.Dec 19 2022, 12:01 PM

AAlhazwani-WMF added a parent task: T323804: Design: create a function definition.Dec 19 2022, 12:23 PM

DVrandecic closed this task as Resolved.Dec 21 2022, 3:51 AM

	F35622068: Screenshot from 2022-10-24 20-58-35.png
	Oct 24 2022, 7:00 PM

	F35622062: Screenshot from 2022-10-24 20-58-28.png
	Oct 24 2022, 7:00 PM

	F35622056: Screenshot from 2022-10-24 20-59-53.png
	Oct 24 2022, 7:00 PM

	F35622049: Screenshot from 2022-10-24 20-58-21.png
	Oct 24 2022, 7:00 PM

Don't show / disable the "show more languages" / "Show name in other languages" buttons when there aren't any to showClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Don't show / disable the "show more languages" / "Show name in other languages" buttons when there aren't any to show
Closed, ResolvedPublic
Actions

Related Objects
Search...