Page MenuHomePhabricator

Set default for edit button in sticky header across all wikis
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

The results from T294506: Run A/B test to evaluate impact of sticky header editing affordance showed that the edit button in the sticky header performed better overall in terms of edit completion as well as revert rates when compared to the control group. This means we would like the edit button in the sticky header to be the default across all wikis

Currently the feature is only available to pilot Wikipedias, we'd like to enable it for projects where Vector 2022 is opt-in e.g. not default.

Acceptance criteria

  • Make the edit button in the sticky header default for all wikis (which have a sticky header) via backport deploy
  • Remove the feature flag once we're sure everything is fine.

Event Timeline

ovasileva triaged this task as Medium priority.Dec 8 2022, 10:17 PM
Jdlrobson subscribed.

If we are sure we don't need the feature flag any more I suggest cleaning up the code so it defaults to on and letting it roll out on the train. Does that work for you @ovasileva ?

If we are sure we don't need the feature flag any more I suggest cleaning up the code so it defaults to on and letting it roll out on the train. Does that work for you @ovasileva ?

Sure, that sounds good!

Jdlrobson set the point value for this task to 1.Dec 10 2022, 12:29 AM
LGoto renamed this task from Set default for edit button in sticky header across wikis to [M] Set default for edit button in sticky header across wikis.Dec 12 2022, 6:43 PM
ovasileva renamed this task from [M] Set default for edit button in sticky header across wikis to Set default for edit button in sticky header across wikis.Jan 10 2023, 5:55 PM
ovasileva raised the priority of this task from Medium to High.
ovasileva changed the point value for this task from 1 to 3.

Change 880533 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[operations/mediawiki-config@master] Show edit button in sticky header for desktop-improvement wikis

https://gerrit.wikimedia.org/r/880533

Do we have a follow-up to remove this config once enabled on all sites?

@Esanders yes that's part of this ticket ( Remove the feature flag once we're sure everything is fine.)

Change 880533 merged by Ebernhardson:

[operations/mediawiki-config@master] Show edit button in sticky header for desktop-improvement wikis

https://gerrit.wikimedia.org/r/880533

Mentioned in SAL (#wikimedia-operations) [2023-01-17T22:04:04Z] <ebernhardson@deploy1002> Started scap: Backport for [[gerrit:880533|Show edit button in sticky header for desktop-improvement wikis (T324799)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-17T22:05:47Z] <ebernhardson@deploy1002> ebernhardson and jdrewniak: Backport for [[gerrit:880533|Show edit button in sticky header for desktop-improvement wikis (T324799)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-17T22:14:47Z] <ebernhardson@deploy1002> Finished scap: Backport for [[gerrit:880533|Show edit button in sticky header for desktop-improvement wikis (T324799)]] (duration: 10m 43s)

Jdlrobson renamed this task from Set default for edit button in sticky header across wikis to Set default for edit button in sticky header across all wikis.Jan 17 2023, 10:22 PM
Jdlrobson updated the task description. (Show Details)

Change 881016 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[operations/mediawiki-config@master] Make sticky header edit button default for all wikis

https://gerrit.wikimedia.org/r/881016

Change 881016 merged by jenkins-bot:

[operations/mediawiki-config@master] Make sticky header edit button default for all wikis

https://gerrit.wikimedia.org/r/881016

Mentioned in SAL (#wikimedia-operations) [2023-01-17T22:38:04Z] <ebernhardson@deploy1002> Started scap: Backport for [[gerrit:881016|Make sticky header edit button default for all wikis (T324799)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-17T22:39:46Z] <ebernhardson@deploy1002> ebernhardson and jdrewniak: Backport for [[gerrit:881016|Make sticky header edit button default for all wikis (T324799)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-17T22:48:39Z] <ebernhardson@deploy1002> Finished scap: Backport for [[gerrit:881016|Make sticky header edit button default for all wikis (T324799)]] (duration: 10m 34s)

Change 881712 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Make sticky header edit the default

https://gerrit.wikimedia.org/r/881712

ovasileva lowered the priority of this task from High to Medium.Jan 24 2023, 5:40 PM
ovasileva changed the point value for this task from 3 to 2.Jan 30 2023, 6:46 PM

Change 881712 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Make sticky header edit the default

https://gerrit.wikimedia.org/r/881712

Edtadros moved this task from QA to QA in Production on the Web-Team FY2022-23 Q3 Sprint 2 board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwikibooks
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

@Jdlrobson I skipped beta since this deals with the pilot wikis. I wasn't sure exactly what to verify, so I found a non-pilot wiki that had vector 2010 as a default (enwikibooks) and set the skin to Vector 2022, then verified that the edit button appears and works. Is this a sufficient test? Also please, see the ❓ below. Is this testable?

✅ AC1: Make the edit button in the sticky header default for all wikis (which have a sticky header) via backport deploy

Screenshot 2023-02-03 at 7.11.49 PM.png (1×1 px, 323 KB)

❓ AC2: Remove the feature flag once we're sure everything is fine.

Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Doing to Ready for Signoff on the Web-Team FY2022-23 Q3 Sprint 2 board.

@Edtadros LGTM. Testing on en.wikibooks was a sufficient test for sure! As for AC2 this one is technical and I can verify this is done!