[subtask] SyntaxError: Element.closest: '#mw-content-text a[href][title]:not(.extiw, .mw-selflink, .image, .new, .internal, .external, .mw-cite-backlink a, .oo-ui-buttonedElement-button, .ve-ce-surface a, .cancelLink a), #mw-content-text .reference a[ href*="#" ]' is not a valid selector
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 13 2022, 10:09 PM

Description

Caused by T325007

The use of closest will throw a SyntaxError on browsers that do not support the not selector with multiple arguments.

This is causing a huge amount of JS errors (around 150k in the last hour alone) and means the page previews feature is unusable to older browsers.

Screen Shot 2022-12-13 at 2.18.39 PM.png (351×645 px, 43 KB)

https://grafana.wikimedia.org/d/000000566/overview?orgId=1&from=1670884156220&to=1670969903151

QA Results - Prod

AC	Status	Details
1	✅	T325113#8473043

Details

Subject	Repo	Branch	Lines +/-
Account for syntax errors in closest selector	mediawiki/extensions/Popups	wmf/1.40.0-wmf.14	+6 -4
Account for syntax errors in closest selector	mediawiki/extensions/Popups	wmf/1.40.0-wmf.13	+6 -4
Account for syntax errors in closest selector	mediawiki/extensions/Popups	master	+6 -4

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Physikerwelt	T208758 Display popups for annotated <math> tags without touching popups extension code
Resolved		ovasileva	T233099 [For visibility] Page previews should be externally extendable
Resolved	BUG REPORT	ovasileva	T325007 [regression,subtask] page preview doesn't display when mouse hovers over wikilinked text that has italic and / or span (and perhaps other html) markup
Resolved	BUG REPORT	ovasileva	T325113 [subtask] SyntaxError: Element.closest: '#mw-content-text a[href][title]:not(.extiw, .mw-selflink, .image, .new, .internal, .external, .mw-cite-backlink a, .oo-ui-buttonedElement-button, .ve-ce-surface a, .cancelLink a), #mw-content-text .reference a[ href*="#" ]' is not a valid selector

Event Timeline

Jdlrobson created this task.Dec 13 2022, 10:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2022, 10:09 PM

Jdlrobson renamed this task from SyntaxError: Element.closest: '#mw-content-text a[href][title]:not(.extiw, .mw-selflink, .image, .new, .internal, .external, .mw-cite-backlink a, .oo-ui-buttonedElement-button, .ve-ce-surface a, .cancelLink a), #mw-content-text .reference a[ href*="#" ]' is not a valid selector to [subtask] SyntaxError: Element.closest: '#mw-content-text a[href][title]:not(.extiw, .mw-selflink, .image, .new, .internal, .external, .mw-cite-backlink a, .oo-ui-buttonedElement-button, .ve-ce-surface a, .cancelLink a), #mw-content-text .reference a[ href*="#" ]' is not a valid selector.Dec 13 2022, 10:10 PM

Jdlrobson triaged this task as Unbreak Now! priority.

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-2022-23-Q2).

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Needs Analysis to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.

Jdlrobson updated the task description. (Show Details)

Change 867720 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Account for syntax errors in closest selector

https://gerrit.wikimedia.org/r/867720

gerritbot added a project: Patch-For-Review.Dec 13 2022, 10:15 PM

Jdlrobson updated the task description. (Show Details)Dec 13 2022, 10:18 PM

Jdlrobson updated the task description. (Show Details)

Change 867617 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@wmf/1.40.0-wmf.13] Account for syntax errors in closest selector

https://gerrit.wikimedia.org/r/867617

Change 867618 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@wmf/1.40.0-wmf.14] Account for syntax errors in closest selector

https://gerrit.wikimedia.org/r/867618

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.Dec 13 2022, 10:22 PM

Change 867720 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Account for syntax errors in closest selector

https://gerrit.wikimedia.org/r/867720

Jdlrobson updated the task description. (Show Details)Dec 13 2022, 10:27 PM

Change 867617 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.40.0-wmf.13] Account for syntax errors in closest selector

https://gerrit.wikimedia.org/r/867617

Mentioned in SAL (#wikimedia-operations) [2022-12-13T22:33:11Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:867617|Account for syntax errors in closest selector (T325113)]]

Mentioned in SAL (#wikimedia-operations) [2022-12-13T22:34:58Z] <jdrewniak@deploy1002> jdrewniak and jdlrobson: Backport for [[gerrit:867617|Account for syntax errors in closest selector (T325113)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-12-13T22:42:31Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:867617|Account for syntax errors in closest selector (T325113)]] (duration: 09m 20s)

Change 867618 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.40.0-wmf.14] Account for syntax errors in closest selector

https://gerrit.wikimedia.org/r/867618

Mentioned in SAL (#wikimedia-operations) [2022-12-13T22:48:57Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:867618|Account for syntax errors in closest selector (T325113)]]

Mentioned in SAL (#wikimedia-operations) [2022-12-13T22:50:49Z] <jdrewniak@deploy1002> jdrewniak and jdlrobson: Backport for [[gerrit:867618|Account for syntax errors in closest selector (T325113)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-12-13T22:57:26Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:867618|Account for syntax errors in closest selector (T325113)]] (duration: 08m 29s)

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Dec 13 2022, 11:00 PM

Thanks to @Jdrewniak this is backported now. The graph is starting to recover

Screen Shot 2022-12-13 at 3.11.08 PM.png (732×1 px, 82 KB)

Jdlrobson assigned this task to Edtadros.Dec 13 2022, 11:11 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.

Jdlrobson moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2022, 11:30 PM

thcipriani moved this task from Untriaged to Dec 2022 on the Wikimedia-production-error board.Dec 15 2022, 4:26 PM

Test Result - Prod

Status: ✅ PASS
Environment:
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Verify errors have returned to normal levels after the backport on 12/13.

Screenshot 2022-12-15 at 6.58.28 PM.png (346×1 px, 70 KB)

Edtadros updated the task description. (Show Details)Dec 16 2022, 3:01 AM

ovasileva closed this task as Resolved.Dec 16 2022, 3:56 PM

phuedx added a parent task: T325007: [regression,subtask] page preview doesn't display when mouse hovers over wikilinked text that has italic and / or span (and perhaps other html) markup .Jan 4 2023, 10:08 AM

	F35869638: Screenshot 2022-12-15 at 6.58.28 PM.png
	Dec 16 2022, 3:00 AM

	F35862136: Screen Shot 2022-12-13 at 3.11.08 PM.png
	Dec 13 2022, 11:11 PM

	F35862092: Screen Shot 2022-12-13 at 2.18.39 PM.png
	Dec 13 2022, 10:18 PM

Description

QA Results - Prod

Details

Related ObjectsSearch...

Event Timeline

Test Result - Prod

QA Steps

Related Objects
Search...