Change 864781 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: adjust min-height for unactivated state

https://gerrit.wikimedia.org/r/864781

The undesired gutter here is coming from the min-height values introduced in T323572: NewImpact: Minimal loading state. The text in Arabic is one line long whereas in English it's two. The problem is related to content height rather than a particular language.

I've submitted a patch to reduce the approximate values by 50px which catches the reduced content issue in Arabic. Is not an ideal solution since it will likely increase vertical bumps in general. For taller content we're covered since the module height is not limited. I don't think we have situations where we can show less content aside from the ones we're already covering:

I don't think we can do much about this if we want the height of the module to vary depending on content inside. An alternative approach could be to have a fixed height for each state. We would need to decide on a fixed height for the articles list. Ideas welcome cc @RHo @kostajh

In T325339#8484213, @Sgs wrote:

The undesired gutter here is coming from the min-height values introduced in T323572: NewImpact: Minimal loading state. The text in Arabic is one line long whereas in English it's two. The problem is related to content height rather than a particular language.

I've submitted a patch to reduce the approximate values by 50px which catches the reduced content issue in Arabic. Is not an ideal solution since it will likely increase vertical bumps in general. For taller content we're covered since the module height is not limited. I don't think we have situations where we can show less content aside from the ones we're already covering:

View/State	Unactivated	Activated (1 single article)
Desktop	min-height: 320px;	min-height: 500px;
Mobile summary	min-height: 130px;	min-height: 180px;
Mobile overlay	- footer is fixed to top	- footer is fixed to top

I don't think we can do much about this if we want the height of the module to vary depending on content inside. An alternative approach could be to have a fixed height for each state. We would need to decide on a fixed height for the articles list. Ideas welcome cc @RHo @kostajh

One idea (hack) I think could work would be to set a minimal height of ~300px for the content inside the impact module as well (minus the module header and padding), and then set display:flex; justify-content:space-between:

In T325339#8501522, @RHo wrote:

One idea (hack) I think could work would be to set a minimal height of ~300px for the content inside the impact module as well (minus the module header and padding), and then set display:flex; justify-content:space-between

That did work well indeed. Thank you!

Change 864781 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: set a min-height for the unactivated state content

https://gerrit.wikimedia.org/r/864781