Page MenuHomePhabricator

MUL - Remove descriptions for `mul` language code from the user workflow on desktop termbox [1 of 2: when viewing]
Closed, ResolvedPublic5 Estimated Story Points

Description

Problem:
Currently, it appears as if editors can add mul descriptions in the termbox. But when they try, they receive an error message, that says mul is not allowed for descriptions. We need to make this more intuitive.

Notes:

  • In story writing, it was decided to split the original task into viewing (T329644) and editing (T338302).
  • T332174 does the same thing for mobile
  • The reason is that we only allow the language code mul for Labels and Aliases and not for descriptions (T313027).

Solution:

  • Remove descriptions for mul language code from the users' termbox workflow
  • The n-dash symbol "โ€“" (disabled field) needs to be translateable to be understood in all cultures (e.g. in Japanese). We need to create e new translation and should indicate to the respective volunteers that the symbol is meant to show that the description is intentionally missing, and that we welcome translations that might communicate this fact better in their language.

Mockups:

Screenshot 2023-06-13 at 12.07.02.png (1ร—2 px, 527 KB)

Acceptance criteria:

  • When viewing an Item on desktop, the termbox shows an n-dash ("โ€“") as a description for mul (see mockup).
  • The n-dash symbol "โ€“" (disabled field) is localized (and a new translation string is created).
  • Users of screen reader technology receive the right prompt (see specs)
  • Release to test.wikidata.org

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptFeb 14 2023, 4:55 PM
Manuel renamed this task from MUL - Remove descriptions for `mul` language code from the user workflow to MUL - Remove descriptions for `mul` language code from the user workflow on desktop termbox.Mar 15 2023, 2:03 PM
Manuel updated the task description. (Show Details)
Manuel renamed this task from MUL - Remove descriptions for `mul` language code from the user workflow on desktop termbox to MUL - Remove descriptions for `mul` language code from the user workflow on desktop termbox [1 of 2: when viewing].Jun 7 2023, 10:09 AM
Manuel assigned this task to Sarai-WMDE.
Manuel updated the task description. (Show Details)
Manuel added a project: Wikidata-UX.

Sprint Planning:

  • The dash will have to be localized, and create a new translation string to ensure that we are providing a message appropriate for its context.
ItamarWMDE set the point value for this task to 5.Jun 13 2023, 9:47 AM
Manuel updated the task description. (Show Details)

Task Breakdown Notes

  • We should research which is the best way to make this screen reader friendly, preferably with an alt text
  • A possible starting point for this would be Wikibase/view/src/TermsListView.php or have a look at the stack traces mentioned in T329655#8922650

Change 930199 had a related patch set uploaded (by Michael GroรŸe; author: Michael GroรŸe):

[mediawiki/extensions/Wikibase@master] Show dash instead of usual description placeholder in legacy termbox

https://gerrit.wikimedia.org/r/930199

Change 930199 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Show dash instead of usual description placeholder in legacy termbox

https://gerrit.wikimedia.org/r/930199

Change 932226 had a related patch set uploaded (by Michael GroรŸe; author: Michael GroรŸe):

[mediawiki/extensions/Wikibase@master] Fix wikibase-descriptionview-mul template for editing

https://gerrit.wikimedia.org/r/932226

Change 932226 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix wikibase-descriptionview-mul template for editing

https://gerrit.wikimedia.org/r/932226

Change 932240 had a related patch set uploaded (by Michael GroรŸe; author: Michael GroรŸe):

[mediawiki/extensions/Wikibase@master] Mark `mul` descriptions as N/A in legacy Termbox via js

https://gerrit.wikimedia.org/r/932240

Change 932240 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Mark `mul` descriptions as N/A in legacy Termbox via js

https://gerrit.wikimedia.org/r/932240

hoo subscribed.

AFAICT this is done and ready for verification now.

Hi, thx for the ping! I will verify this after it is deployed on Test Wikidata.

Thank you for the changes! The mouseover makes a lot of sense to me. There is a dotted line below the "-". Would it be easy to not show that?

@Sarai-WMDE, this is how it now looks like:

image.png (217ร—928 px, 17 KB)

Thank you for the changes! The mouseover makes a lot of sense to me. There is a dotted line below the "-". Would it be easy to not show that?

Not showing the line (and a different cursor) is the plan. Not fully sure why the original styles are showing again. Will look into it.

Change 935738 had a related patch set uploaded (by Michael GroรŸe; author: Michael GroรŸe):

[mediawiki/extensions/Wikibase@master] Fix styles for js-generated mul description placeholder

https://gerrit.wikimedia.org/r/935738

Change 935738 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix styles for js-generated mul description placeholder

https://gerrit.wikimedia.org/r/935738

Thank you for checking! It is now working perfectly on beta! \o/