Page MenuHomePhabricator

VisualEditor "double click to edit cell" stopped working (in Firefox)
Closed, ResolvedPublicBUG REPORT

Event Timeline

Izno changed the subtype of this task from "Task" to "Bug Report".Feb 18 2023, 2:28 AM

Not sure why the fix there targets all ce=false nodes instead of just focusable nodes? Changing to the latter would probably fix this.

The default MediaWiki:Visualeditor-tablecell-tooltip is "Double click to edit cell". At https://en.wikipedia.org/wiki/MediaWiki:Visualeditor-tablecell-tooltip I have added "(in Firefox: single click and press Enter)". I suggest doing the same to the default if the bug is not fixed quickly.

Curiously, double-clicking works if you click on the last (bottom-right-most) table cell.

Curiously, double-clicking works if you click on the last (bottom-right-most) table cell.

It fails for me in Firefox. In some tables I get a vertical non-blinking line longer than the normal blinking cursor but I cannot change the cell. In other tables I get nothing.

Change 890455 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] Revert "Try to prevent selections inside ref/template nodes on Firefox"

https://gerrit.wikimedia.org/r/890455

Change 890455 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Revert "Try to prevent selections inside ref/template nodes on Firefox"

https://gerrit.wikimedia.org/r/890455

Change 890503 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (08c5c702b)

https://gerrit.wikimedia.org/r/890503

Change 890503 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (08c5c702b)

https://gerrit.wikimedia.org/r/890503

Change 890456 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@wmf/1.40.0-wmf.23] Revert "Try to prevent selections inside ref/template nodes on Firefox"

https://gerrit.wikimedia.org/r/890456

Change 890504 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.40.0-wmf.23] Update VE core submodule to f2528875026a

https://gerrit.wikimedia.org/r/890504

Change 890456 merged by jenkins-bot:

[VisualEditor/VisualEditor@wmf/1.40.0-wmf.23] Revert "Try to prevent selections inside ref/template nodes on Firefox"

https://gerrit.wikimedia.org/r/890456

Change 890504 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.40.0-wmf.23] Update VE core submodule to f2528875026a

https://gerrit.wikimedia.org/r/890504

Mentioned in SAL (#wikimedia-operations) [2023-02-20T21:23:59Z] <zabe@deploy1002> zabe: T329983 T330104 synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-02-20T21:33:40Z] <zabe@deploy1002> Finished scap: T329983 T330104 (duration: 11m 51s)

matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.

Should be fixed on all Wikimedia wikis now.

ppelberg claimed this task.