Page MenuHomePhabricator

Update TheWikipediaLibrary extension for IP masking
Closed, ResolvedPublic

Description

See https://office.wikimedia.org/wiki/Product/IP_Masking

IP masking will impact TheWikipediaLibrary extension. The extension will not work with temp accounts because it depends upon setting a preference, which temp accounts can't do (see T326816: Update features for temporary accounts).

We already have a number of simple checks on user accounts in our code that decides whether or not to send a notification, and all we need to do is add an additional check for $user->isTemp().

Deadline: September 2023

Event Timeline

jsn.sherman moved this task from Ready to Code review on the Moderator-Tools-Team (Kanban) board.

I ended up looking at this out of order, and it's pretty straightforward.
The extension is not currently safe for wikis with temp accounts, but it is very straightforward to fix.
The extension will not work with temp accounts because it depends upon setting a preference, which temp accounts can't do (see T326816: Update features for temporary accounts).

We already have a number of simple checks on user accounts in our code that decides whether or not to send a notification, and all we need to do is add an additional check for $user->isTemp().

Samwalton9-WMF renamed this task from Investigate whether TheWikipediaLibrary extension will be affected by IP masking to Update TheWikipediaLibrary extension for IP masking.Jul 25 2023, 9:13 AM
Samwalton9-WMF updated the task description. (Show Details)
Samwalton9-WMF updated the task description. (Show Details)

Updated task description and backlogged for now.

Change 950064 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/TheWikipediaLibrary@master] Update TheWikipediaLibrary extension for IP masking

https://gerrit.wikimedia.org/r/950064

jsn.sherman changed the task status from Open to In Progress.Aug 18 2023, 2:59 AM
jsn.sherman moved this task from Ready to Code review on the Moderator-Tools-Team (Kanban) board.

Change 950064 merged by jenkins-bot:

[mediawiki/extensions/TheWikipediaLibrary@master] Update TheWikipediaLibrary extension for IP masking

https://gerrit.wikimedia.org/r/950064