Page MenuHomePhabricator
Create Task
Maniphest T333514

Show a text label when there is No IP data for temporary user on Special:Block
Closed, ResolvedPublic
Actions

Description

Following T324602#8690912 and T324602#8712185 Show no data label on Special:Block

Acceptance criteria

  • If there is no IP data for a temporary user show the label that reads `No IP data for this temporary user for the last X days`

Details

SubjectRepoBranchLines +/-
Use PLURAL in checkuser-tempaccount-no-ip-results messagemediawiki/extensions/CheckUsermaster+1 -1
Show text label when no IPs returned on Special:Blockmediawiki/extensions/CheckUsermaster+28 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

• TThoabala removed • TThoabala as the assignee of this task.Mar 30 2023, 12:51 AM
• TThoabala created this task.
• TThoabala mentioned this in T324602: SpecialBlock: Once a temporary account is selected, below the username field display IP addresses associated with the account.
JJMC89 removed a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 30 2023, 1:48 AM
JJMC89 removed subscribers: Niharika, • Prtksxna, Tchanders and 11 others.
Dreamy_Jazz subscribed.Mar 30 2023, 12:41 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Needs Design/Product 🎨 on the Anti-Harassment (AHaT Sprint 27: The Big Yellow Hat) board.Mar 30 2023, 4:18 PM
Tchanders added a subscriber: • Prtksxna.

`No IP data for this temporary user for the last X days`

@Prtksxna Can we change this to something like `No IP data for this temporary user due to time elapsed`? The API doesn't return when the last IP address associated with an account was purged.

• Prtksxna added a comment.Apr 4 2023, 10:53 AM

I meant X to be whatever the policy for data retention would be 90 or 180 days, not the actual time elapsed since the purge.

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 28: The Mad Hatter Hat); removed Anti-Harassment (AHaT Sprint 27: The Big Yellow Hat).Apr 11 2023, 5:07 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Needs Design/Product 🎨 on the Anti-Harassment (AHaT Sprint 28: The Mad Hatter Hat) board.
Tchanders moved this task from Needs Design/Product 🎨 to Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) on the Anti-Harassment (AHaT Sprint 28: The Mad Hatter Hat) board.Apr 11 2023, 5:23 PM
gerritbot added a comment.Apr 12 2023, 1:32 AM

Change 908008 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Show text label when no IPs returned on Special:Block

https://gerrit.wikimedia.org/r/908008

gerritbot added a project: Patch-For-Review.Apr 12 2023, 1:32 AM
STran claimed this task.Apr 12 2023, 1:32 AM
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 28: The Mad Hatter Hat) board.
STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 28: The Mad Hatter Hat) board.Apr 12 2023, 3:38 AM
gerritbot added a comment.Apr 17 2023, 3:25 PM

Change 908008 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Show text label when no IPs returned on Special:Block

https://gerrit.wikimedia.org/r/908008

Maintenance_bot removed a project: Patch-For-Review.Apr 17 2023, 3:30 PM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 28: The Mad Hatter Hat) board.Apr 17 2023, 4:21 PM
gerritbot added a comment.Apr 18 2023, 12:49 PM

Change 909665 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Use PLURAL in checkuser-tempaccount-no-ip-results message

https://gerrit.wikimedia.org/r/909665

gerritbot added a project: Patch-For-Review.Apr 18 2023, 12:49 PM
gerritbot added a comment.Apr 18 2023, 1:40 PM

Change 909665 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use PLURAL in checkuser-tempaccount-no-ip-results message

https://gerrit.wikimedia.org/r/909665

Maintenance_bot removed a project: Patch-For-Review.Apr 18 2023, 2:14 PM
GMikesell-WMF added a comment.Apr 24 2023, 6:38 PM

@TThoabala I see in the description you have No IP data for this temporary user for the last X days. Is it supposed to be the number of actual days that it had no IP data since you had "x", which the IP data just got deleted last week for the example below, or is the description of your ticket should have "90" days?

T333514_IPMasking_SpecialBlock_DeletedIP.png (655×3 px, 171 KB)

Tchanders added a subscriber: GMikesell-WMF.Apr 25 2023, 4:46 PM
In T333514#8802704, @GMikesell-WMF wrote:

@TThoabala I see in the description you have No IP data for this temporary user for the last X days. Is it supposed to be the number of actual days that it had no IP data since you had "x", which the IP data just got deleted last week for the example below, or is the description of your ticket should have "90" days?

T333514_IPMasking_SpecialBlock_DeletedIP.png (655×3 px, 171 KB)

It's supposed to be the second one, as per @Prtksxna :

In T333514#8753913, @Prtksxna wrote:

I meant X to be whatever the policy for data retention would be 90 or 180 days, not the actual time elapsed since the purge.

Tchanders moved this task from AHaT Sprint 28: The Mad Hatter Hat to AHaT Sprint 29: The Ikseongwan on the Anti-Harassment board.Apr 25 2023, 5:50 PM
Tchanders edited projects, added Anti-Harassment (AHaT Sprint 29: The Ikseongwan); removed Anti-Harassment (AHaT Sprint 28: The Mad Hatter Hat).
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 29: The Ikseongwan) board.
dom_walden added subscribers: Tchanders, dom_walden.Apr 26 2023, 5:35 AM
In T333514#8805303, @Tchanders wrote:
In T333514#8802704, @GMikesell-WMF wrote:

@TThoabala I see in the description you have No IP data for this temporary user for the last X days. Is it supposed to be the number of actual days that it had no IP data since you had "x", which the IP data just got deleted last week for the example below, or is the description of your ticket should have "90" days?

T333514_IPMasking_SpecialBlock_DeletedIP.png (655×3 px, 171 KB)

It's supposed to be the second one, as per @Prtksxna :

In T333514#8753913, @Prtksxna wrote:

I meant X to be whatever the policy for data retention would be 90 or 180 days, not the actual time elapsed since the purge.

It is the value of $wgCUDMaxAge, right?

Tchanders added a comment.May 3 2023, 4:18 PM

It is the value of $wgCUDMaxAge, right?

Yes (so not always 90 necessarily)

Tchanders moved this task from AHaT Sprint 29: The Ikseongwan to AHaT Sprint 30: Avanton Gold Cone on the Anti-Harassment board.May 9 2023, 5:44 PM
Tchanders edited projects, added Anti-Harassment (AHaT Sprint 30: Avanton Gold Cone); removed Anti-Harassment (AHaT Sprint 29: The Ikseongwan).
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 30: Avanton Gold Cone) board.May 9 2023, 5:48 PM
GMikesell-WMF added a comment.May 10 2023, 4:56 PM

@Tchanders Ok sounds good. I didn't come across anything else regarding this issue so I'll move this to Done. Thanks!

GMikesell-WMF moved this task from QA/Testing 🐞 to Done Q4 2022-2023 on the Anti-Harassment (AHaT Sprint 30: Avanton Gold Cone) board.May 10 2023, 4:56 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 2:47 PM
Tchanders closed this task as Resolved.Jun 20 2023, 3:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits