Page MenuHomePhabricator

Enable IP multireveal for all users
Closed, ResolvedPublic

Description

Currently only checkusers can use the multireveal feature. All users (will include checkusers, sysops/admins, and the tbd patrollers) should be able to use the multireveal feature.

AC:

  • no checks on who can use the multireveal. It'll be assumed that if you can access ips you can multireveal.

Details

Event Timeline

Change 906060 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Enable IP multireveal for all users

https://gerrit.wikimedia.org/r/906060

Change 906060 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Enable IP multireveal for all users

https://gerrit.wikimedia.org/r/906060

Modified from Expected behavior and testing notes for T327946: Admins and checkusers unveil all IPs on the page for a temp account by clicking one button

  • This is best tested locally
  • Necessary config:
    • $wgAutoCreateTempUser['enabled'] = true;
    • $wgGroupPermissions['checkuser']['checkuser-temporary-account'] = true;
    • $wgGroupPermissions['sysop']['checkuser-temporary-account'] = true;
    • $wgGroupPermissions['user']['checkuser-temporary-account'] = true; (to test non-admins/checkusers)
  • For admins and checkusers anyone with the 'checkuser-temporary-account' right, clicking "Show IP" against a given temp username will reveal ALL instances of that temp username on the page irrespective of the IP address
    • On pages with revision IDs (e.g. history pages, Special:RecentChanges), the IPs revealed may be different
    • On pages with no revision IDs (e.g. Special:Log), the IPs revealed are the same - the latest IP used
  • For non-admins/checkusers who have the checkuser-temporary-account right, clicking "Show IP" will only reveal the IP next to the clicked button
dom_walden subscribed.

The multireveal now works for users who have the checkuser-temporary-account right, even if they are not admins or checkusers.

I tested on:

  • Revision history
  • Special:RecentChanges
  • Special:Log
  • Special:Contributions

Skins:

  • Vector 2022
  • Vector 2010
  • Minerva

Browsers:

  • Firefox 102
  • Chromium 112

I briefly tried throttling my connection and clicking "Show IP" multiple times. I didn't see any duplicate requests or other misbehaviour.

Test environment: local docker CheckUser 2.5 (db5f9f9) 06:59, 13 April 2023.