Page MenuHomePhabricator

+2 in mediawiki/ for Winston Sung
Closed, ResolvedPublic

Assigned To
Authored By
Legoktm
Apr 10 2023, 2:43 AM
Referenced Files
None
Tokens
"Love" token, awarded by SD_hehua."Love" token, awarded by Jdlrobson."Love" token, awarded by Aca."Like" token, awarded by WMDE-leszek."Like" token, awarded by Aklapper."Like" token, awarded by Zabe."Like" token, awarded by DannyS712."Love" token, awarded by ashley."Like" token, awarded by Jdforrester-WMF."Like" token, awarded by sbassett."Love" token, awarded by Kizule.

Description

I am nominating @Winston_Sung for +2 rights largely for their work in a relatively neglected area of MediaWiki: language conversion. Winston was involved in getting the Serbo-Croatian language converter across the finish line (credited as co-author on the merged patch, see also this abandoned patch). This included some minor architectural changes and fixes to tests as well. And, even, more, language converter patches. Plus they organized the MediaWiki-Language-converter workboard.

My interactions with them have always been good, and I'm impressed with how they respond to CR feedback (recent example).

Winston has less patches than people I've nominated in the past, but I hope their willingness and desire to work in an area needing more developers makes up for that. I trust they'll use +2 powers to merge patches that they're qualified to review and slowly expand that capacity over time.

Event Timeline

I was the person coordinating the efforts to get the Serbo-Croatian language converter that @Aca made over the finish line. Reflecting on that process and my later interactions with @Winston_Sung (he is one of few people with knowledge in this area), I can only say positive things about his help.

He provided constructive criticism and discussed with us to help us understand the specifics on this less-understood part of the code-base. I was impressed to see his principled and opinionated approach to code review, something I feel is unfortunately too rare. All while engaging in dialog, being open to other approaches and generally a pleasant conversation partner.

Although Winston was helpful, I am certain that had the patch not ended up meeting his standards, he would not have given his +1. I feel confident that given +2 rights, @Winston_Sung would use these thoughtfully and responsibly, and I hope that we can soon see him use them in action.

ashley subscribed.

Happy to see LanguageConverter getting some volunteer love! 👍

I strongly believe that Winston will be a great addition to the team! Based on the previous cooperation, I got the impression that he is a very accommodating and reliable contributor. These privileges will help him better manage tasks in the language converter area.

I endorse. I recently worked with @Winston_Sung on changes to meta tags across all wiki pages that were impacting Chinese Wikipedia (T54429). Given the riskiness of such a change I was impressed with our exchange there and how the resulting code was much better. I agree with the assessment that Winston would use +2 rights thoughtfully and responsibly based on what I've seen there. Language-related patches account for many of our open Gerrit patches so hopefully more stewardship in the area will help.

PS. Winston please remember to update https://mediawiki.org/wiki/Maintainers and list yourself as a maintainer/consultant for relevant areas if this is granted!

PS. Winston please remember to update https://mediawiki.org/wiki/Maintainers and list yourself as a maintainer/consultant for relevant areas if this is granted!

Will do. Thanks for the information.

Legoktm claimed this task.

Closing as successful. Congrats @Winston_Sung :)

PS. Winston please remember to update https://mediawiki.org/wiki/Maintainers and list yourself as a maintainer/consultant for relevant areas if this is granted!

Done.